| Message ID | 1492650631-15510-1-git-send-email-peng.fan@nxp.com |
|---|---|
| State | Accepted |
| Commit | 8fbbb6c27f8a3927b50bc8cd00fd288194ef83fc |
| Delegated to: | Tom Rini |
| Headers | show |
Hi Peng, On 19 April 2017 at 19:10, Peng Fan <peng.fan@nxp.com> wrote: > Change tbu/l type to unsigned int. Why do this, please? > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > Cc: Simon Glass <sjg@chromium.org> > Cc: Tom Rini <trini@konsulko.com> > --- > arch/arm/include/asm/global_data.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/include/asm/global_data.h b/arch/arm/include/asm/global_data.h > index dfcbcce..92d9c97 100644 > --- a/arch/arm/include/asm/global_data.h > +++ b/arch/arm/include/asm/global_data.h > @@ -32,8 +32,8 @@ struct arch_global_data { > #endif > /* "static data" needed by most of timer.c on ARM platforms */ > unsigned long timer_rate_hz; > - unsigned long tbu; > - unsigned long tbl; > + unsigned int tbu; > + unsigned int tbl; > unsigned long lastinc; > unsigned long long timer_reset_value; > #if !(defined(CONFIG_SYS_ICACHE_OFF) && defined(CONFIG_SYS_DCACHE_OFF)) > -- > 2.6.6 > Regards, Simon
Hi Tom, Will you pick up this patch set? Thanks, Peng. On Thu, Apr 20, 2017 at 09:10:30AM +0800, Peng Fan wrote: >Change tbu/l type to unsigned int. > >Signed-off-by: Peng Fan <peng.fan@nxp.com> >Cc: Simon Glass <sjg@chromium.org> >Cc: Tom Rini <trini@konsulko.com> >--- > arch/arm/include/asm/global_data.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/arch/arm/include/asm/global_data.h b/arch/arm/include/asm/global_data.h >index dfcbcce..92d9c97 100644 >--- a/arch/arm/include/asm/global_data.h >+++ b/arch/arm/include/asm/global_data.h >@@ -32,8 +32,8 @@ struct arch_global_data { > #endif > /* "static data" needed by most of timer.c on ARM platforms */ > unsigned long timer_rate_hz; >- unsigned long tbu; >- unsigned long tbl; >+ unsigned int tbu; >+ unsigned int tbl; > unsigned long lastinc; > unsigned long long timer_reset_value; > #if !(defined(CONFIG_SYS_ICACHE_OFF) && defined(CONFIG_SYS_DCACHE_OFF)) >-- >2.6.6 > >_______________________________________________ >U-Boot mailing list >U-Boot@lists.denx.de >https://lists.denx.de/listinfo/u-boot
On Mon, May 08, 2017 at 05:58:06PM +0800, Peng Fan wrote: > Hi Tom, > > Will you pick up this patch set? Yes, but can you v2 it with details of why in the commit messages? Thanks!
diff --git a/arch/arm/include/asm/global_data.h b/arch/arm/include/asm/global_data.h index dfcbcce..92d9c97 100644 --- a/arch/arm/include/asm/global_data.h +++ b/arch/arm/include/asm/global_data.h @@ -32,8 +32,8 @@ struct arch_global_data { #endif /* "static data" needed by most of timer.c on ARM platforms */ unsigned long timer_rate_hz; - unsigned long tbu; - unsigned long tbl; + unsigned int tbu; + unsigned int tbl; unsigned long lastinc; unsigned long long timer_reset_value; #if !(defined(CONFIG_SYS_ICACHE_OFF) && defined(CONFIG_SYS_DCACHE_OFF))
Change tbu/l type to unsigned int. Signed-off-by: Peng Fan <peng.fan@nxp.com> Cc: Simon Glass <sjg@chromium.org> Cc: Tom Rini <trini@konsulko.com> --- arch/arm/include/asm/global_data.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)