From patchwork Sun Dec 12 15:07:52 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Blue Swirl X-Patchwork-Id: 75253 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 6645EB7082 for ; Mon, 13 Dec 2010 02:12:47 +1100 (EST) Received: from localhost ([127.0.0.1]:38965 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PRnbP-0003Fk-C9 for incoming@patchwork.ozlabs.org; Sun, 12 Dec 2010 10:12:43 -0500 Received: from [140.186.70.92] (port=42770 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PRnX7-000157-A5 for qemu-devel@nongnu.org; Sun, 12 Dec 2010 10:08:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PRnX4-0005Jy-6K for qemu-devel@nongnu.org; Sun, 12 Dec 2010 10:08:15 -0500 Received: from mail-pw0-f45.google.com ([209.85.160.45]:37740) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PRnX3-0005Js-V2 for qemu-devel@nongnu.org; Sun, 12 Dec 2010 10:08:14 -0500 Received: by pwj6 with SMTP id 6so1162014pwj.4 for ; Sun, 12 Dec 2010 07:08:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:content-type :content-transfer-encoding; bh=Yh/W+4I6tch3M/rRCJJ+oStm/bJb4ursMubhEPM5C/Q=; b=dEjmRvruspZnhluJQd9VOfJC7Dcy1tYFuqOGjGVqyDevkVwFRMGl+J6ofTQkAI91AA RT61ZMMHEQOKFY4aOGhQHnBqFaOFZgBmlR9Yqyi+MXjxNYLsWXfjj3eaNU1cgaROqV0w 5L3LdWQj1Dlf3XadGXH5BPWRBxQT6McnwA8fk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type:content-transfer-encoding; b=UvoJjAAJUCpVQfTMk/IG+UCEKpNBmXG0PrEbLS5dAGoKNzlDlsCoF/3MbnAdmzDuz4 5ymLdnaZz7gWGOl8yY06w68e1e7YblW1JcTxG432cB8sgMj0J8Nsq4uulBOKkX9XC39Z sjkEyLLFaBzIn4eVzL9OXyqOP9h4rhdUkk9mQ= Received: by 10.142.51.21 with SMTP id y21mr2307343wfy.119.1292166492795; Sun, 12 Dec 2010 07:08:12 -0800 (PST) MIME-Version: 1.0 Received: by 10.142.135.1 with HTTP; Sun, 12 Dec 2010 07:07:52 -0800 (PST) In-Reply-To: <20101212113513.GA2017@playa.tlv.redhat.com> References: <1290955607-25821-1-git-send-email-alevy@redhat.com> <20101207102019.GC31414@playa.tlv.redhat.com> <4D0399DB.4090008@redhat.com> <20101212113513.GA2017@playa.tlv.redhat.com> From: Blue Swirl Date: Sun, 12 Dec 2010 15:07:52 +0000 Message-ID: Subject: Re: [Qemu-devel] [PATCH 0/6] usb-ccid (v8) To: Hans de Goede , qemu-devel@nongnu.org X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) Cc: X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On Sun, Dec 12, 2010 at 11:35 AM, Alon Levy wrote: > On Sat, Dec 11, 2010 at 03:55:10PM +0000, Blue Swirl wrote: >> On Sat, Dec 11, 2010 at 3:33 PM, Hans de Goede wrote: >> > Hi, >> > >> > On 12/11/2010 10:43 AM, Blue Swirl wrote: >> >> >> >> On Tue, Dec 7, 2010 at 10:20 AM, Alon Levy  wrote: >> >>> >> >>> ping. >> >> >> >> I don't think Anthony's concerns (or mine) have been addressed. >> >> >> > >> > Could you be a bit more verbose please ? >> >> I'm not sure if this answer was OK for Anthony given the previous discussion: >> http://article.gmane.org/gmane.comp.emulators.qemu/85793 >> > > I'm pretty sure it's ok by anthony since he suggested the inclusion of > libcacard in qemu in the first place. (that's not a typo - I've renamed > it to avoid the double card, I'll send an updated patch merging 4/6 and > including this rename). > >> About my concerns, see my previous mail about merging the shared >> library fix to 4/6 and about other stuff that does not belong to QEMU >> but which should be a separate project. >> > your concerns were: >  usb-ccid.c: >  endianess - I've added network to host convertions (used as guest to host). >  coding style - answer_t and bulk_in_t renamed >  hungarian style usage - gave 'excuse' (spec uses those names) >  anonymous structs usage - named >  libcaccard: >  don't build a library that qemu doesn't use: v8.1, will fold in and send v9 > > Am I missing anything? No. But now that I tried to build it, there are other problems. There is a typo in configure: Build also fails when compiling in an object directory: make: *** libcaccard: No such file or directory. Stop. make: *** [subdir-libcaccard] Error 2 I'd even remove the configure option and build the card by default if the dependencies are found. There were also whitespace problems when applying: Applying ccid: add ccid-card-emulated device (v2) .dotest/patch:37: trailing whitespace. * for i in 1 2 3; do certutil -d /etc/pki/nssdb -x -t "CT,CT,CT" -S -s "CN=user$i" -n user$i; done warning: 1 line applied after fixing whitespace errors. Applying ccid: add docs .dotest/patch:121: trailing whitespace. [APDU<->APDU repeats several times] warning: 1 line applied after fixing whitespace errors. diff --git a/configure b/configure index 4b55904..7288b09 100755 --- a/configure +++ b/configure @@ -2142,7 +2142,7 @@ if test "$smartcard" != "no" ; then QEMU_CFLAGS="$QEMU_CFLAGS $smartcard_cflags $libcaccard_cflags" LIBS="$libcaccard_libs $LIBS" else - if test "smartcard" = "yes" ; then + if test "$smartcard" = "yes" ; then feature_not_found "smartcard" fi smartcard="no"