From patchwork Wed Apr 19 20:48:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roy Pledge X-Patchwork-Id: 752464 X-Patchwork-Delegate: scottwood@freescale.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3w7Z5L10Mgz9s65 for ; Thu, 20 Apr 2017 06:55:18 +1000 (AEST) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3w7Z5L0DbRzDqV3 for ; Thu, 20 Apr 2017 06:55:18 +1000 (AEST) X-Original-To: linuxppc-dev@lists.ozlabs.org Delivered-To: linuxppc-dev@lists.ozlabs.org Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0044.outbound.protection.outlook.com [104.47.34.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3w7Yy95fdlzDq8M for ; Thu, 20 Apr 2017 06:49:05 +1000 (AEST) Received: from DM5PR03CA0050.namprd03.prod.outlook.com (10.174.189.167) by BLUPR03MB245.namprd03.prod.outlook.com (10.255.213.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.10; Wed, 19 Apr 2017 20:49:00 +0000 Received: from BY2FFO11FD024.protection.gbl (2a01:111:f400:7c0c::128) by DM5PR03CA0050.outlook.office365.com (2603:10b6:4:3b::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.10 via Frontend Transport; Wed, 19 Apr 2017 20:48:59 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BY2FFO11FD024.mail.protection.outlook.com (10.1.15.213) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1019.14 via Frontend Transport; Wed, 19 Apr 2017 20:48:59 +0000 Received: from otc-sw1.am.freescale.net (otc-sw1.am.freescale.net [10.29.200.182]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id v3JKmswl006946; Wed, 19 Apr 2017 13:48:58 -0700 From: Roy Pledge To: , , , , Subject: [PATCH v2 04/11] soc/fsl/qbman: Drop set/clear_bits usage Date: Wed, 19 Apr 2017 16:48:43 -0400 Message-ID: <1492634930-10765-5-git-send-email-roy.pledge@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1492634930-10765-1-git-send-email-roy.pledge@nxp.com> References: <1492634930-10765-1-git-send-email-roy.pledge@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131371085397381116; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39850400002)(39380400002)(39400400002)(39840400002)(39450400003)(39410400002)(39860400002)(2980300002)(1110001)(1109001)(339900001)(189002)(199003)(9170700003)(8676002)(104016004)(86362001)(2201001)(38730400002)(5003940100001)(36756003)(8936002)(50986999)(50226002)(4326008)(2950100002)(76176999)(81166006)(6666003)(85426001)(77096006)(305945005)(189998001)(5660300001)(50466002)(48376002)(356003)(2906002)(105606002)(53936002)(47776003)(43066003)(8656002)(106466001)(3450700001)(33646002)(54906002)(2101003); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR03MB245; H:az84smr01.freescale.net; FPR:; SPF:Fail; MLV:ovrnspm; MX:1; A:1; PTR:InfoDomainNonexistent; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD024; 1:I5aMxpx8jGhQ35E/4XJG8oBABiUNZgZ2EZkw/GVBYfVnyv34i9E3+UJCFLGkR+PSX0H8zORQymLY6wryVNmnu8lfNUD5MUKRPpBNbvYQOSoWYrHGAS9/g1iPYV56rhFdYq8bmVqpVQfUMMG7DXZ0BVgFbP+lZ1t1Sxsxvib87AuLHO6P4YbsqTTZgAbKXF6BSZYuZ+kByXYgS5trtV2nagtKS1XeK9lGKFuKEBhyAyCGgzYhizTINzI0ax8OV/yGgAfpA+6dFM4Y3dTG20p3Ryo7lNvU2tZYzqg+S/6Q1a/MwBs5hJdcA7HkD87cSylNsgC+SOAZklnUFz5lTEwBU+iiBr2cUklG34+7UAsThQB26eELVCXb2oESZ7T9Mg6CzJg2iVL2m6ItMRE1MdNoOn4L1WN19voi33sTcegkefgvuU1C+no5Kig4AL78ZplZJ5dsVWqnfVGIX3XBwLabfrw58cq5P6sxRT9ca44DFawM4imSAUncL1PFfJfIMokbmOV7GRrL0NT6JSzNWV8AdECbBIqpVX4CFrnf44a1HqDSnirXw7mnw14J35GrqFmq91cBreZ/L4KqWkbbCgO/Kl2KNFQC6XtTDT1rj0++h8tNgbFRLs5+ikjLXPdNpLb0pHNQ0D+9FzqpcGOsNGHq6GuFo+tUXv5a+AoCYhah5DtXugbg8HngzwG9ZFivl4DDGUVmjc3mv35pH/CSf1pyrU91EDXGyeJi4p6zRS6H2Wv2xL4okKdH6RkWVeJx+s09 MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 94ddb7af-5e0a-467a-ee9b-08d487658152 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131430075)(201703131517081); SRVR:BLUPR03MB245; X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB245; 3:rXw0XSnnavqqeg7BPWmo18sSW+95zgCSSGOZGy39vMDeHGXXuqMhyfYKGNLcvfvWUxxFtp3zFw+OE8xG+yXlgG0xT/Cd1pBWHR/h7w7cvdemJSVTHblkS0MzMeoF+nf1Urqo0MkOWBobKHNL52qBuRHcV9LRQNosOyvL7MSIW/BEn/E0Yrr7VrcpFmwrE8i3slPjB3prReufQlsB/RdbemI9X2SM1angBetZY8z0uq5htY5anxU0uvmkmTeuicTuZWUmRbwJNFAL1skZCXyh++HvBpTLjen0Z5stETdJrUSjvQcsNJbbruYuTwHm11bsXulEoDIp2kDzqywv0bL/gZs5jqBEUF1y7x4phqFZIe5NeuBoK6jQyNnOZIF8oJjEdaHpRzaGV1aHfIIrw37wrXIYVVs0ms6DZMloUqkPVwSaTuRK7hlwvTvbrSwdwbJJ; 25:sIIQ3slmMptRKNc/hJqIPI1N+dgJsebw4qvoyexWBiWtm5NOi0EByCD39tV92vMJqLMgbFgdAByU/XGbYep5Ar02iyxfU7ecTXQR9anYDqhsUqQX5qH8OrvIwK3nuWaXiqL5ajjFt2PmnbY/LCPAhyxMbpyy0rt7zOu232tN84Y52AuFDgqoYlRMjf3wimr32tPgyxRBA+jJ2877qFOsTtSrU+Aepvvde+BgXieyt/qsBesDGYJzJuJgYWHzJtWMqpbi+4IUiDIvr2DnToJgg5kvWpgpQrTxYk9QArAoJfJs0cLDR75MMVM/XHwgHkfL+m4FCuoIsr7MyNVSFzogMNvvuy+XWKSTERsJCvILPBLD+gDdKXESgpWiHqroDlPIKOJo2UnpDFavCt3OEnBJ/aSn9pHMcvao3YS/cInmwuEKAhrJ2jkfOBiZe6ejB3Y0wBbHrjIHBujE6lMAM/xoLg== X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB245; 31:J3uNVSBu7KnWD6/mBMG7EruKmLntnE/LbzBEsGSDnrngz7d7fN3eT7fimkK182GnYyD+dgjuDnR06tOIvpzRBSVO4DEae5xYgCv00A8A9rMUp69I26eqNvvprqb7X4KTZBDCUSTD4Y+gBYuGz1ybzMvzm4RyA0OWXzHvhtSZx0JJf9IORwnJvXoCauVEU/1zDbw7W07jXWGzdC6lSlww7yQd1sXH7ZRC9/wOefiL4Bw8VUk96hieXQX9ID95uys4VpLSFo2t80y5QX/HWRj0d+zpfr4Rct7X+boQ0pPT9oU= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(788757137089); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(601004)(2401047)(13017025)(13015025)(8121501046)(5005006)(13023025)(13024025)(13018025)(3002001)(10201501046)(93006095)(93001095)(6055026)(6096035)(20161123561025)(20161123556025)(20161123563025)(201703131430075)(201703131433075)(201703131441075)(201703131448075)(201703161259150)(20161123565025); SRVR:BLUPR03MB245; BCL:0; PCL:0; RULEID:(400006); SRVR:BLUPR03MB245; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR03MB245; 4:BPGx8UFiOZL4X5PKP4xuKUxsnFxHUSC5gsG4CNDQYZv?= =?us-ascii?Q?BYhuN8XchAs3F6bCIDR9Jd11+s20jy1F924hGgzr8/jebWA2NvRYGrg3TCXy?= =?us-ascii?Q?K2WTdNWQaMRYXWp0TWN1/zyJs9rNv8BLCpBX2g2r7zitxB6+GqwOHMPnga3Y?= =?us-ascii?Q?qUKQfNAVQ4K+zWxZAaVVoPjtQUKhDRPJ/9g7Cf/wCeFlLG58ZUeJTUtCUODK?= =?us-ascii?Q?5FPEpu9DCMoU+rfCReOYJmNybnymOQR344ms56LvEDIObI2+oY/y5fJvKJjI?= =?us-ascii?Q?JmNRJz4Qk+u+IRdCA8Av1ZrjkV0tJATUpEeUr1jjSfNI9bguet/e5yPoxUmX?= =?us-ascii?Q?H6n1eqyuOne216SSHEK5I0ROD5fo+D6uam3s01gfbdTBa2YQA2yUrx9yXnOq?= =?us-ascii?Q?A30Nb4k2NMafhWQvWCf2sXw8ULVyJ7+YxIObhqlvuaOcv/EuW0Xirtm6yWSd?= =?us-ascii?Q?mpe3KKXS+3xHBTlpWji7/u7JDnHUAsSWaGVtjNMOUFKUfImeVlAYeyUEbLW7?= =?us-ascii?Q?8YAlafIR6iFIRG1TebBU9THrgU9KSTV1+Hsl4BfvzuC14kJa2DwWxjFLhy5a?= =?us-ascii?Q?fFrkwaleEQSt3i/QV5NX2wNoKASRO7XYbzI52i3G+EI4UIqzlzMugMEpef0L?= =?us-ascii?Q?xo8IbcxL+EyJf5OzxiPOxY3QQOtKjNaEgjWSC+hzGPnXLnn8VQnNhk6y/OlJ?= =?us-ascii?Q?GuMhyrykfB9ZgwZ2RL+0/HrHNT8l6+ho5ZyGjzurLlRM/2C4LsgxSa8ooMI1?= =?us-ascii?Q?7f7IsJ8c4u0/KP56jVeMLN8+OUgkLA8HF97AMnAJNS47EjBD4K+bdvrNxLZU?= =?us-ascii?Q?YPsKkghBlK8e9Jyx3Xbj4rSxITI7vqxv++QLmAUMswy1UiajiQo5ENQTkLDN?= =?us-ascii?Q?wk4iWc2TTyUCF9zA0YT9S2ANdt+BNjSdlgR6EkF6Hg4Ee/CXz+0FRqehKP6s?= =?us-ascii?Q?8uB/ACzxitDf4LYpuiWM1AiBoRPmzyBVMy8v8lQ=3D=3D?= X-Forefront-PRVS: 028256169F X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR03MB245; 23:/rnA0pR9Ns5n7JycEGFQ2AmwPDSwXqS1qoorphwPf9?= =?us-ascii?Q?oeMq+3tu4tx5+zyghKOBG3CtNCrzc5XwJ/yZWoDxYPChjRT4DFTqtX0QtIC7?= =?us-ascii?Q?MI1W1aiDZaznt2M/lezxdd9e6PUi8HM2TyAUzS2/G8Qtua/GqB/BeB/Qo3Li?= =?us-ascii?Q?4zcKw0a6MQ1yK7Fl6XoXfkRaNzEZTJMSWXKo1DDo9IMAPPrDRX0jAk50sA7I?= =?us-ascii?Q?cm12lqj4A5cssrM3Afuc7RJfIXGLEKdAtQLdA81xkdJD/aAzSLrg0zRr2A70?= =?us-ascii?Q?cOGACdXYl9YFzKXuY/Pw00v2lKpMbeTBts4rqYZIJiW4QhEC8V9Lb6VME87a?= =?us-ascii?Q?hStyozRjJPxfkU7KdoP1YlTf0aICzVLP1Z/dU0kWIHvLuSBmXvgTx0183KMD?= =?us-ascii?Q?JYsUdZqbtXgK6hk0Hm6JefmSGWVSijnlG25YXFO2zbc9Wb3YiaXrr93u4Agf?= =?us-ascii?Q?9Nkz3Kr5eue42LfIelrZxqruTGuppkOZw8QXOEBYM8W1w7zZfxQ52NTmchXj?= =?us-ascii?Q?O2t/5PYLRodg0Yoj+Elnr0fmCNemWVGQfSrF593mFSvssylFHcF6b9dUoVDU?= =?us-ascii?Q?Cq/3Tw9AEk7ZOc7/dcVslkZRwqs50kYyXNeBPhBuYYOIy6f2OzeZ8rO0KiS1?= =?us-ascii?Q?UBnGCGb5Oz2BPOuzXH8rqyNy51b+pSVXYTiLM6P6seJSRX/2H3mVjEytmLN1?= =?us-ascii?Q?8Y6CHy7yqi1yBcvZpgW6U46o36o4KHbIVLyrpyBr7NqWnVVv6O5PP/y13kyk?= =?us-ascii?Q?7a5oFIlkbCqsbbofjVrAJ1ys/+iX/NH5AEYR09Nxr+ox1iRVCil19D2Jr4C/?= =?us-ascii?Q?i6MRGKmGsumCxC8QqhmsM/c3EquLsZG8UQSkmEN0TI5h7rFvpgCRAAS74cmY?= =?us-ascii?Q?IxjyKI4tujoTJFFgULu8mEYgnvPI+uy1maFp/X9EHUhbrwfh9VI0afyszjPY?= =?us-ascii?Q?3W4TUATs/DrNIopT/b3Iv8amsF4TElTBx1vmu1I6NFWG8F5PFvPOLaCTokI4?= =?us-ascii?Q?RDJ7BMglLHRJ8aNIK7Jul04mnbbPZI20GIWBZexKTLCHasvhQXNxYxbA7Y5S?= =?us-ascii?Q?+sXqwt3/m1gPhwG3u5+G8XmVRocwM21aDntns7e9LDVTKYMbr7tynrj1YBSe?= =?us-ascii?Q?mI4XGaJ8UsEiZC4UIobn+iZLev8+ua5/UhElIvxsVCQX+L/rmEP/LbjZeTzd?= =?us-ascii?Q?h52o78Op/8MbGiskum4s1MKSQI9QU3M0d1kGhhAfB252QXqZlZP28IBuw5rN?= =?us-ascii?Q?IgmFrYcLkiobRTejE=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB245; 6:Olu/gBIy7m+qVwkFBH2iOg1eGzb7Q7FdAL0JW2EIMoMIIxU3Dci42FWgZsiFf6hxRB7JECCsKoFw5Dt/grPyo7TgloHUsZSEYQ9aLsl/Tstq6ucfXosqZrxECywTlw7MQ38/+NYxqQHtO4Clu+rzRviNGOukUk+bBaZJ1Zpc012GDnvCMssJOt+kIAwPxUEjAs4003/M41tPy7dtqlzM+Mhrb93Flws7S+TVxncmSs19+kx/hYGtV5qLHu4fhHp6eYYO/pXprUUX5s5mW5OgLtjcJmJvyjL3G/f1vqDyHlu3MVRQwsmWq99Zw7v+m7H9uI3WJCEKxiHptqNX4RXCr8W9Q0bRzW8fFaKw6nqcNJm8DOkdeunLmpMZqc1NnxWGRPAMGQpH4S2zUqLJbaYaKogYiKzQrMiPLmc57tdbuQcjC8RQGDmjr28wT2ZeQp9B3JJ5fMkYskF500W9iPwT+mZNmaZY5IVTvDUiYhSfp5lMzztK2Nov5SPzJnNMf9b4yeTyxhWQA9sKISsmhqWnsA==; 5:qpbEeos26yBBQIIlap+9owZkzgI01hdhIHC/L2aNS5Z6iBxUNapOXBlwYhYWdhS99UqirZLYYV/EJur1LDdkw8RUVx7E7V6CVY+KS67ka//X4EJd0tpQ7utRQVIUWH+8MqtRUqNOqwoMrknoh8zZMWPSp6HI8uIyopqDkZNnE0R9rKz0qeZnFa0M30Wn3u/U; 24:nTdy/UuHI+E2O3fZXOLdadWpmtZ7Rq+1P8N2BdtvricJZ7DH9cUevGeNhFX6HmvLc68GdVX6gVsw6WDCSW9nJ2GpEbI5nStGDlYgj1sLPrk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB245; 7:XQrAunRntPckk83HOASQXoHVoMEPLRRueRQ3bdmKAXuto1b3qkqvjSZ1nraLS8DFiUxQi3Kccs42EPXgZNscywz5QzMnEulOlNYU89QcHK2O222v+iKCI+EdQtq5wzD5knPo7OpMCl+7VGhB3JkAXbRsgW6KSzzGEIA/Rptt4+dcvbkggYbxlXeSs/gJgqlqzH+Wp1Bt3MiakfRxrCCjbhW4bEnqVJGstT/dINY1TI4A16/ltb3hx81noXmvpbUL5rGI3fUNMRXwP92IRCWYS25Ij/TRGX5uFuDPSZudoysOyfVIIqviITLxRl0ZMyIyYx2mf00I2vXowZeMSl1DEA== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2017 20:48:59.6133 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB245 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: roy.pledge@nxp.com Cc: Claudiu Manoil , Roy Pledge , madalin.bucur@nxp.com Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" From: Madalin Bucur Replace PPC specific set/clear_bits API with standard bit twiddling so driver is portalable outside PPC. Signed-off-by: Madalin Bucur Signed-off-by: Claudiu Manoil Signed-off-by: Roy Pledge --- drivers/soc/fsl/qbman/bman.c | 2 +- drivers/soc/fsl/qbman/qman.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/soc/fsl/qbman/bman.c b/drivers/soc/fsl/qbman/bman.c index a3d6d7c..3acded1 100644 --- a/drivers/soc/fsl/qbman/bman.c +++ b/drivers/soc/fsl/qbman/bman.c @@ -607,7 +607,7 @@ int bman_p_irqsource_add(struct bman_portal *p, u32 bits) unsigned long irqflags; local_irq_save(irqflags); - set_bits(bits & BM_PIRQ_VISIBLE, &p->irq_sources); + p->irq_sources |= bits & BM_PIRQ_VISIBLE; bm_out(&p->p, BM_REG_IER, p->irq_sources); local_irq_restore(irqflags); return 0; diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c index 3d891db..3f60289 100644 --- a/drivers/soc/fsl/qbman/qman.c +++ b/drivers/soc/fsl/qbman/qman.c @@ -909,12 +909,12 @@ static inline int qm_mc_result_timeout(struct qm_portal *portal, static inline void fq_set(struct qman_fq *fq, u32 mask) { - set_bits(mask, &fq->flags); + fq->flags |= mask; } static inline void fq_clear(struct qman_fq *fq, u32 mask) { - clear_bits(mask, &fq->flags); + fq->flags &= ~mask; } static inline int fq_isset(struct qman_fq *fq, u32 mask) @@ -1561,7 +1561,7 @@ void qman_p_irqsource_add(struct qman_portal *p, u32 bits) unsigned long irqflags; local_irq_save(irqflags); - set_bits(bits & QM_PIRQ_VISIBLE, &p->irq_sources); + p->irq_sources |= bits & QM_PIRQ_VISIBLE; qm_out(&p->p, QM_REG_IER, p->irq_sources); local_irq_restore(irqflags); } @@ -1584,7 +1584,7 @@ void qman_p_irqsource_remove(struct qman_portal *p, u32 bits) */ local_irq_save(irqflags); bits &= QM_PIRQ_VISIBLE; - clear_bits(bits, &p->irq_sources); + p->irq_sources &= ~bits; qm_out(&p->p, QM_REG_IER, p->irq_sources); ier = qm_in(&p->p, QM_REG_IER); /*