From patchwork Wed Apr 19 16:49:17 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Wakely X-Patchwork-Id: 752349 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3w7Sf46z84z9s75 for ; Thu, 20 Apr 2017 02:49:48 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="JGlo87xG"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; q=dns; s=default; b=nyQ1ROy+QXh6FYxUQ d24j1t6tsEYrA7cydxOybHPPkalGrrZcc7L0uT64U+rYqW05bzuDrN7DbHcsZV8W 1gT154VD4cGJEvfLuJJ0pza5b8ZUwAnY5FGh0QgpTiJ5nNbo/3ZEwXl5XHt7KBP9 KGrhcbCUh61BiOlnlfqL4YPZa0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=default; bh=ZSN33m61hVDSkaKTzvvThFY PhUA=; b=JGlo87xGx7o6DOatxvgdj1GbGhqY6VMTpMW2b/YuC/F1SLZwk78Y5PA hVCJ0EDPISKVcgTNueJ91xjr53f+eAFS30fFpNWy+wXKvWUR78Sc1gdgUnNAJl3d 785LO2qkKUmOnkJg4CGLGRBMiP98nySwCBGDTApE4k3/qViGCTM4= Received: (qmail 83889 invoked by alias); 19 Apr 2017 16:49:22 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 83797 invoked by uid 89); 19 Apr 2017 16:49:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Application, wwww3org, UD:www.w3.org, xmlns X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Apr 2017 16:49:17 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 558964DD70; Wed, 19 Apr 2017 16:49:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 558964DD70 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jwakely@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 558964DD70 Received: from localhost (unknown [10.33.36.2]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0676480F7F; Wed, 19 Apr 2017 16:49:17 +0000 (UTC) Date: Wed, 19 Apr 2017 17:49:17 +0100 From: Jonathan Wakely To: Gerald Pfeifer Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Subject: Re: [libstdc++] Adjust to the new location of the C++ ABI Message-ID: <20170419164917.GX3412@redhat.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.8.0 (2017-02-23) On 12/04/17 08:37 +1000, Gerald Pfeifer wrote: >On Thu, 30 Mar 2017, Gerald Pfeifer wrote: >> (Jonathan, I'm going to take care of the libstdc++/doc links as >> well in case you wonder.) > >Done thusly. > >Jonathan, do you think one of the three references in >doc/xml/manual/abi.xml could be avoided? That'll make it easier >next time this document moves. :-} Well, they go to three different places (or did, before your change). One link was the the ABI spec, one is to a specific section of the spec, and one is a bibliography entry linking to the homepage of the project. I've changed the first one to link to the bibliography entry, so there are only two now, but I don't think it's am improvement really. When you click on the link it jumps to the bottom of the page, but not necessarily to the actual anchor (because it's too near the bottom of the page). I certainly don't think we should remove the second one. I don't want to have a hypertext document that says "see section N of [biblio.cxxabi]" rather than just hyperlinking directly to it. >(Also, if you could regenerate and upload the docs?) Sure. Committed to trunk. commit ed7eeb361974a8c64803b617bd760612060cc3ab Author: Jonathan Wakely Date: Wed Apr 19 17:45:42 2017 +0100 Rationalise ABI links in libstdc++ manual * doc/xml/manual/abi.xml: Rephrase one of the references to the Itanium C++ ABI. * doc/xml/manual/test.xml: Document DejaGnu 1.5.3 requirement. * doc/html/*: Regenerate. diff --git a/libstdc++-v3/doc/xml/manual/abi.xml b/libstdc++-v3/doc/xml/manual/abi.xml index 0e56068..1c816b1 100644 --- a/libstdc++-v3/doc/xml/manual/abi.xml +++ b/libstdc++-v3/doc/xml/manual/abi.xml @@ -40,10 +40,9 @@ alignment and in a particular layout, mangling names according to a well-defined algorithm, has specific arrangements for the support of virtual functions, etc. These details are defined as the compiler - Application Binary Interface, or ABI. The GNU C++ compiler uses an - industry-standard C++ ABI starting with version 3. Details can be - found in the ABI - specification. + Application Binary Interface, or ABI. From GCC version 3 onwards the + GNU C++ compiler uses an industry-standard C++ ABI, the + Itanium C++ ABI. @@ -1116,7 +1115,7 @@ gcc test.c -g -O2 -L. -lone -ltwo /usr/lib/libstdc++.so.5 /usr/lib/libstdc++.so. <link xmlns:xlink="http://www.w3.org/1999/xlink" xlink:href="https://itanium-cxx-abi.github.io/cxx-abi/"> - C++ ABI Summary + Itanium C++ ABI </link> diff --git a/libstdc++-v3/doc/xml/manual/test.xml b/libstdc++-v3/doc/xml/manual/test.xml index 8ae88b3..7cb7daf 100644 --- a/libstdc++-v3/doc/xml/manual/test.xml +++ b/libstdc++-v3/doc/xml/manual/test.xml @@ -563,8 +563,11 @@ cat 27_io/objects/char/3_xin.in | a.out the CXXFLAGS variable when running make, or via options for the DejaGnu test framework (described below). The latter approach uses the - option that was shown earlier. - For example, to run the tests with + option that was shown earlier, + but requires DejaGnu version 1.5.3 or newer to work reliably, so that the + dg-options in the test aren't overridden. + For example, to run the tests with + you could use: make RUNTESTFLAGS=--target_board=unix/-O1/-D_GLIBCXX_ASSERTIONS