| Message ID | 20170419164137.13085-1-russell@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
On Wed, Apr 19, 2017 at 12:41:37PM -0400, Russell Bryant wrote: > Commit b89d25e5694b made the "router" DHCPv4 option optional instead of > mandatory. This did not actually change the schema, but there's no good > way for a client of the northbound database to know if this change is > present without bumping the schema version. This is needed for a client to > work with versions before and after this change. > > Reported-at: https://bugs.launchpad.net/networking-ovn/+bug/1670666 > Fixes: b89d25e5694b ("ovn: Modify the DHCPv4 router option to optional") > Signed-off-by: Russell Bryant <russell@ovn.org> Acked-by: Ben Pfaff <blp@ovn.org> However, keep in mind that this version distinction is only useful if ovn-northd and the OVSDB schema are upgraded almost simultaneously.
On Mon, Apr 24, 2017 at 2:04 PM, Ben Pfaff <blp@ovn.org> wrote: > On Wed, Apr 19, 2017 at 12:41:37PM -0400, Russell Bryant wrote: >> Commit b89d25e5694b made the "router" DHCPv4 option optional instead of >> mandatory. This did not actually change the schema, but there's no good >> way for a client of the northbound database to know if this change is >> present without bumping the schema version. This is needed for a client to >> work with versions before and after this change. >> >> Reported-at: https://bugs.launchpad.net/networking-ovn/+bug/1670666 >> Fixes: b89d25e5694b ("ovn: Modify the DHCPv4 router option to optional") >> Signed-off-by: Russell Bryant <russell@ovn.org> > > Acked-by: Ben Pfaff <blp@ovn.org> > > However, keep in mind that this version distinction is only useful if > ovn-northd and the OVSDB schema are upgraded almost simultaneously. Good point, thanks. ovn-ctl is set up to update the schema if needed before starting ovn-northd, including during a restart, so it should generally be the case. I applied this to master.
diff --git a/ovn/ovn-nb.ovsschema b/ovn/ovn-nb.ovsschema index dd0ac3d..5033d17 100644 --- a/ovn/ovn-nb.ovsschema +++ b/ovn/ovn-nb.ovsschema @@ -1,7 +1,7 @@ { "name": "OVN_Northbound", - "version": "5.5.0", - "cksum": "2099428463 14236", + "version": "5.5.1", + "cksum": "1924970369 14236", "tables": { "NB_Global": { "columns": {
Commit b89d25e5694b made the "router" DHCPv4 option optional instead of mandatory. This did not actually change the schema, but there's no good way for a client of the northbound database to know if this change is present without bumping the schema version. This is needed for a client to work with versions before and after this change. Reported-at: https://bugs.launchpad.net/networking-ovn/+bug/1670666 Fixes: b89d25e5694b ("ovn: Modify the DHCPv4 router option to optional") Signed-off-by: Russell Bryant <russell@ovn.org> --- ovn/ovn-nb.ovsschema | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)