[ovs-dev,ovs,V2] Documentation: fix broken links in maintainers page

Submitted by Roi Dayan on April 19, 2017, 1:52 p.m.

Details

Message ID 1492609941-5333-1-git-send-email-roid@mellanox.com
State Superseded
Headers show

Commit Message

Roi Dayan April 19, 2017, 1:52 p.m.
Missing the internals sub folder.

Signed-off-by: Roi Dayan <roid@mellanox.com>
---

V2
    - fix links but keep GitHub style as it's a top-level document


 MAINTAINERS.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Stephen Finucane April 19, 2017, 2:23 p.m.
On Wed, 2017-04-19 at 16:52 +0300, Roi Dayan wrote:
> Missing the internals sub folder.
> 
> Signed-off-by: Roi Dayan <roid@mellanox.com>

I wonder should these links be updated to point to the absolute URL on
docs.openvswitch.org, e.g.

  `here <http://docs.openvswitch.org/en/latest/internals/committer-
responsibilities.rst>`__

or, cleaner:

  `here`__

  __ http://docs.openvswitch.org/en/latest/internals/committer-responsi
bilities.rst

I should have mentioned this before but I didn't think of it ­čś». Thi
s can be fixed at merge time though, so for this as-is:

Acked-by: Stephen Finucane <stephen@that.guru>

> ---
> 
> V2
>     - fix links but keep GitHub style as it's a top-level document
> 
> 
>  MAINTAINERS.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/MAINTAINERS.rst b/MAINTAINERS.rst
> index 28831ab..60fa1f5 100644
> --- a/MAINTAINERS.rst
> +++ b/MAINTAINERS.rst
> @@ -29,10 +29,10 @@ Open vSwitch committers are the people who have
> been granted access to push
>  changes to to the Open vSwitch git repository.
>  
>  The responsibilities of an Open vSwitch committer are documented
> -`here <Documentation/committer-responsibilities.rst>`__.
> +`here <Documentation/internals/committer-responsibilities.rst>`__.
>  
>  The process for adding or removing committers is documented
> -`here <Documentation/committer-grant-revocation.rst>`__.
> +`here <Documentation/internals/committer-grant-revocation.rst>`__.
>  
>  This is the current list of Open vSwitch committers:
>

Patch hide | download patch | download mbox

diff --git a/MAINTAINERS.rst b/MAINTAINERS.rst
index 28831ab..60fa1f5 100644
--- a/MAINTAINERS.rst
+++ b/MAINTAINERS.rst
@@ -29,10 +29,10 @@  Open vSwitch committers are the people who have been granted access to push
 changes to to the Open vSwitch git repository.
 
 The responsibilities of an Open vSwitch committer are documented
-`here <Documentation/committer-responsibilities.rst>`__.
+`here <Documentation/internals/committer-responsibilities.rst>`__.
 
 The process for adding or removing committers is documented
-`here <Documentation/committer-grant-revocation.rst>`__.
+`here <Documentation/internals/committer-grant-revocation.rst>`__.
 
 This is the current list of Open vSwitch committers: