Patchwork [PATCHv2,net-next,12/15] tcp: remove retransmit_skb_hint clearing from failure

login
register
mail settings
Submitter Ilpo Järvinen
Date Sept. 20, 2008, 9:47 p.m.
Message ID <1221947278-16715-13-git-send-email-ilpo.jarvinen@helsinki.fi>
Download mbox | patch
Permalink /patch/752/
State Accepted
Delegated to: David Miller
Headers show

Comments

Ilpo Järvinen - Sept. 20, 2008, 9:47 p.m.
This doesn't much sense here afaict, probably never has. Since
fragmenting and collapsing deal the hints by themselves, there
should be very little reason for the rexmit loop to do that.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
---
 net/ipv4/tcp_output.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

Patch

diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
index cd83713..97873cc 100644
--- a/net/ipv4/tcp_output.c
+++ b/net/ipv4/tcp_output.c
@@ -2094,10 +2094,8 @@  begin_fwd:
 		if (sacked & (TCPCB_SACKED_ACKED|TCPCB_SACKED_RETRANS))
 			continue;
 
-		if (tcp_retransmit_skb(sk, skb)) {
-			tp->retransmit_skb_hint = NULL;
+		if (tcp_retransmit_skb(sk, skb))
 			return;
-		}
 		NET_INC_STATS_BH(sock_net(sk), mib_idx);
 
 		if (skb == tcp_write_queue_head(sk))