diff mbox

[U-Boot] rockchip: enable debug uart

Message ID 20170418111727.1814-1-eddie.cai.linux@gmail.com
State Accepted
Commit 7474bbe85718954b7565ac72eaffb3fc2e0880d3
Delegated to: Simon Glass
Headers show

Commit Message

Eddie Cai April 18, 2017, 11:17 a.m. UTC
enable debug uart for rk3288 and print something to let people know
where we are

Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com>
---
 arch/arm/mach-rockchip/rk3288-board-spl.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Simon Glass April 19, 2017, 12:12 a.m. UTC | #1
On 18 April 2017 at 05:17, Eddie Cai <eddie.cai.linux@gmail.com> wrote:
> enable debug uart for rk3288 and print something to let people know
> where we are
>
> Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com>
> ---
>  arch/arm/mach-rockchip/rk3288-board-spl.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>

Reviewed-by: Simon Glass <sjg@chromium.org>
Simon Glass April 20, 2017, 9:06 p.m. UTC | #2
On 18 April 2017 at 18:12, Simon Glass <sjg@chromium.org> wrote:
> On 18 April 2017 at 05:17, Eddie Cai <eddie.cai.linux@gmail.com> wrote:
>> enable debug uart for rk3288 and print something to let people know
>> where we are
>>
>> Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com>
>> ---
>>  arch/arm/mach-rockchip/rk3288-board-spl.c | 6 ++----
>>  1 file changed, 2 insertions(+), 4 deletions(-)
>>
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-rockchip/next, thanks!
diff mbox

Patch

diff --git a/arch/arm/mach-rockchip/rk3288-board-spl.c b/arch/arm/mach-rockchip/rk3288-board-spl.c
index 74f3379..8ca6b1e 100644
--- a/arch/arm/mach-rockchip/rk3288-board-spl.c
+++ b/arch/arm/mach-rockchip/rk3288-board-spl.c
@@ -164,7 +164,6 @@  void board_init_f(ulong dummy)
 	int ret;
 
 	/* Example code showing how to enable the debug UART on RK3288 */
-#ifdef EARLY_UART
 #include <asm/arch/grf_rk3288.h>
 	/* Enable early UART on the RK3288 */
 #define GRF_BASE	0xff770000
@@ -183,8 +182,7 @@  void board_init_f(ulong dummy)
 	 * printascii("string");
 	 */
 	debug_uart_init();
-#endif
-
+	debug("\nspl:debug uart enabled in %s\n", __func__);
 	ret = spl_early_init();
 	if (ret) {
 		debug("spl_early_init() failed: %d\n", ret);
@@ -205,7 +203,7 @@  void board_init_f(ulong dummy)
 		debug("Pinctrl init failed: %d\n", ret);
 		return;
 	}
-
+	debug("\nspl:init dram\n");
 	ret = uclass_get_device(UCLASS_RAM, 0, &dev);
 	if (ret) {
 		debug("DRAM init failed: %d\n", ret);