[BZ,19919] iso14651_t1_common: Correct the Malayalam sorting order of 0D36 and 0D37

Message ID CACjkf4BtMazxSwPZgR9Uumd2vKcFBfPz=KGUdVo3aW3rtiF2og@mail.gmail.com
State New
Headers show

Commit Message

Santhosh Thottingal April 18, 2017, 9:40 a.m.
The Malayalam characters ശ(U+0D36) and ഷ(U+0D37) should be sorted just
like the order of their unicode code points. In the master version of
glibc, the order is swapped.
Attached the patch to fix this.

Steps to reproduce the issue and test is given in BZ 19919

Comments

Pravin Satpute April 18, 2017, 9:57 a.m. | #1
>----- Original Message -----
>From: "Santhosh Thottingal" <santhosh.thottingal@gmail.com>
>To: libc-alpha@sourceware.org
>Cc: "Pravin Satpute" <pravin.d.s@gmail.com>
>Sent: Tuesday, April 18, 2017 3:10:22 PM
>Subject: [PATCH][BZ 19919] iso14651_t1_common: Correct the Malayalam sorting order of 0D36 and 0D37
>
>The Malayalam characters ശ(U+0D36) and ഷ(U+0D37) should be sorted just
>like the order of their unicode code points. In the master version of
>glibc, the order is swapped.
>Attached the patch to fix this.
>
>Steps to reproduce the issue and test is given in BZ 19919

Patch applies clean and providing results as expected. Santhosh please provide Changelog entries as well for this patch. Providing on bugzilla is fine, so if someone committing this patch he can directly copy-paste it for localedata/Changelog file.

Thanks Santhosh for this patch.

Best Regards,
Pravin Satpute
Santhosh Thottingal June 11, 2017, 3:34 a.m. | #2
On Tue, Apr 18, 2017 at 3:27 PM, Pravin Satpute <psatpute@redhat.com> wrote:
> Patch applies clean and providing results as expected. Santhosh please provide Changelog entries as well for this patch. Providing on bugzilla is fine, so if someone committing this patch he can directly copy-paste it for localedata/Changelog file.

Ping.
Zack Weinberg June 11, 2017, 2:14 p.m. | #3
On 06/10/2017 11:34 PM, Santhosh Thottingal wrote:
> On Tue, Apr 18, 2017 at 3:27 PM, Pravin Satpute <psatpute@redhat.com>
> wrote:
>> Patch applies clean and providing results as expected. Santhosh
>> please provide Changelog entries as well for this patch. Providing
>> on bugzilla is fine, so if someone committing this patch he can
>> directly copy-paste it for localedata/Changelog file.
> 
> Ping.

I have committed this patch along with the one for #19922.  The
ChangeLog entry I wrote for them is

2017-06-11  Santhosh Thottingal  <santhosh.thottingal@gmail.com>

	[BZ #19922]
	* locales/iso14651_t1_common: Add collation rules for U+07DA
	to U+07DF.

	[BZ #19919]
	* locales/iso14651_t1_common: Correct collation of U+0D36
	and U+0D37.

If you would prefer to be identified some other way please email me
off-list with your preferred name and/or email address.

On behalf of the glibc maintainers I would like to apologize for the
unconscionable delay in applying the fixes you provided for these bugs.

zw
Zack Weinberg June 11, 2017, 2:34 p.m. | #4
On 06/11/2017 10:14 AM, Zack Weinberg wrote:
> On 06/10/2017 11:34 PM, Santhosh Thottingal wrote:
>> On Tue, Apr 18, 2017 at 3:27 PM, Pravin Satpute <psatpute@redhat.com>
>> wrote:
>>> Patch applies clean and providing results as expected. Santhosh
>>> please provide Changelog entries as well for this patch. Providing
>>> on bugzilla is fine, so if someone committing this patch he can
>>> directly copy-paste it for localedata/Changelog file.
>>
>> Ping.
> 
> I have committed this patch along with the one for #19922.

I have also applied the patches for #19919 and #19922 to the release
branches for 2.23, 2.24, and 2.25.  This is the same set of release
branches that the patch for #20974 was applied to.

zw

Patch

diff --git a/localedata/locales/iso14651_t1_common b/localedata/locales/iso14651_t1_common
index eef75ba..c364a21 100644
--- a/localedata/locales/iso14651_t1_common
+++ b/localedata/locales/iso14651_t1_common
@@ -1042,9 +1042,9 @@  collating-element <ml-bh> from "<U0D2D><U0D4D>"
 collating-element <ml-m> from "<U0D2E><U0D4D>"
 collating-element <ml-y> from "<U0D2F><U0D4D>"
 collating-element <ml-v> from "<U0D35><U0D4D>"
-collating-element <ml-s> from "<U0D38><U0D4D>"
 collating-element <ml-ss> from "<U0D36><U0D4D>"
 collating-element <ml-sh> from "<U0D37><U0D4D>"
+collating-element <ml-s> from "<U0D38><U0D4D>"
 collating-element <ml-h> from "<U0D39><U0D4D>"
 collating-element <ml-zh> from "<U0D34><U0D4D>"
 collating-element <ml-rr> from "<U0D31><U0D4D>"
@@ -1103,8 +1103,8 @@  collating-symbol <ml-rra>
 collating-symbol <ml-la>
 collating-symbol <ml-lla>
 collating-symbol <ml-va>
-collating-symbol <ml-sha>
 collating-symbol <ml-ssa>
+collating-symbol <ml-sha>
 collating-symbol <ml-sa>
 collating-symbol <ml-ha>
 collating-symbol <ml-avagrah>
@@ -7311,9 +7311,9 @@  order_start <MALAYALAM>;forward;forward;forward;forward,position
 <ml-v>	"<ml-va><ml-virama>";<BAS>;<MIN>;IGNORE
 <U0D35>	"<ml-va><ml-virama><mlvw-shorta>";<BAS>;<MIN>;IGNORE
 <ml-ss>	"<ml-ssa><ml-virama>";<BAS>;<MIN>;IGNORE
-<U0D37>	"<ml-ssa><ml-virama><mlvw-shorta>";<BAS>;<MIN>;IGNORE
+<U0D36>	"<ml-ssa><ml-virama><mlvw-shorta>";<BAS>;<MIN>;IGNORE
 <ml-sh>	"<ml-sha><ml-virama>";<BAS>;<MIN>;IGNORE
-<U0D36>	"<ml-sha><ml-virama><mlvw-shorta>";<BAS>;<MIN>;IGNORE
+<U0D37>	"<ml-sha><ml-virama><mlvw-shorta>";<BAS>;<MIN>;IGNORE
 <ml-s>	"<ml-sa><ml-virama>";<BAS>;<MIN>;IGNORE
 <U0D38>	"<ml-sa><ml-virama><mlvw-shorta>";<BAS>;<MIN>;IGNORE
 <ml-h>	"<ml-ha><ml-virama>";<BAS>;<MIN>;IGNORE