[ovs-dev,v2,2/2] lib/automake.mk: don't install runtime directories

Submitted by aaron conole on April 17, 2017, 5:59 p.m.

Details

Message ID 20170417175950.8290-3-aconole@redhat.com
State Accepted
Headers show

Commit Message

aaron conole April 17, 2017, 5:59 p.m.
The Open vSwitch run, log, and DB directories are installed as part of the
normal `make install` process.  However, this means they are created with
user and group ownership that may conflict with the desired user.  For
example, running `make install` as root will install those files as
root:root, whereas the runtime user desired may be openvswitch:openvswitch.

Since these directories are automatically created as part of the ovs-ctl
command, and with the correct user:group permissions, it makes sense to
delay creation until these directories are actually required.

Signed-off-by: Aaron Conole <aconole@redhat.com>
Acked-by: Ben Pfaff <blp@ovn.org>
---
v1->v2:
* no change

 lib/automake.mk | 3 ---
 1 file changed, 3 deletions(-)

Patch hide | download patch | download mbox

diff --git a/lib/automake.mk b/lib/automake.mk
index 62b2f38..faace79 100644
--- a/lib/automake.mk
+++ b/lib/automake.mk
@@ -534,10 +534,7 @@  EXTRA_DIST += build-aux/extract-ofp-msgs
 
 INSTALL_DATA_LOCAL += lib-install-data-local
 lib-install-data-local:
-	$(MKDIR_P) $(DESTDIR)$(RUNDIR)
 	$(MKDIR_P) $(DESTDIR)$(PKIDIR)
-	$(MKDIR_P) $(DESTDIR)$(LOGDIR)
-	$(MKDIR_P) $(DESTDIR)$(DBDIR)
 	$(MKDIR_P) $(DESTDIR)$(sysconfdir)/openvswitch
 
 man_MANS += lib/ovs-fields.7