Patchwork vlan: Fix typos in proc output string

login
register
mail settings
Submitter Ferenc Wagner
Date Nov. 6, 2008, 11:18 a.m.
Message ID <877i7hyuf0.fsf@tac.ki.iif.hu>
Download mbox | patch
Permalink /patch/7514/
State Accepted
Delegated to: David Miller
Headers show

Comments

Ferenc Wagner - Nov. 6, 2008, 11:18 a.m.
Signed-off-by: Ferenc Wagner <wferi@niif.hu>
---
 net/8021q/vlanproc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
David Miller - Nov. 10, 2008, 9:38 p.m.
From: Ferenc Wagner <wferi@niif.hu>
Date: Thu, 06 Nov 2008 12:18:27 +0100

> Signed-off-by: Ferenc Wagner <wferi@niif.hu>
 ...
> @@ -314,7 +314,7 @@ static int vlandev_seq_show(struct seq_file *seq, void *offset)
>  		   dev_info->ingress_priority_map[6],
>  		   dev_info->ingress_priority_map[7]);
>  
> -	seq_printf(seq, "EGRESSS priority Mappings: ");
> +	seq_printf(seq, " EGRESS priority mappings: ");
>  	for (i = 0; i < 16; i++) {
>  		const struct vlan_priority_tci_mapping *mp
>  			= dev_info->egress_priority_map[i];

The typo fix is clearly correct, but adding the leading
space is not.  Are you simply trying to make the values
line up with the INGRESS ones on the previous line?

Anyways, I'm applying this fix, but I wish you had clarified
the change as it wasn't totally clear even to me.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ferenc Wagner - Nov. 10, 2008, 11:20 p.m.
David Miller <davem@davemloft.net> writes:

> From: Ferenc Wagner <wferi@niif.hu>
> Date: Thu, 06 Nov 2008 12:18:27 +0100
>
>> Signed-off-by: Ferenc Wagner <wferi@niif.hu>
>  ...
>> @@ -314,7 +314,7 @@ static int vlandev_seq_show(struct seq_file *seq, void *offset)
>>  		   dev_info->ingress_priority_map[6],
>>  		   dev_info->ingress_priority_map[7]);
>>  
>> -	seq_printf(seq, "EGRESSS priority Mappings: ");
>> +	seq_printf(seq, " EGRESS priority mappings: ");
>>  	for (i = 0; i < 16; i++) {
>>  		const struct vlan_priority_tci_mapping *mp
>>  			= dev_info->egress_priority_map[i];
>
> The typo fix is clearly correct, but adding the leading
> space is not.  Are you simply trying to make the values
> line up with the INGRESS ones on the previous line?

Not as much the values, as those are separated by single spaces on the
egress line but double spaces on the ingress line, except for 6 and 7,
so that is a mess anyway (shall I send another most important patch to
this end?)  But I find the titles easier to parse when their common
parts are lined up.

> Anyways, I'm applying this fix, but I wish you had clarified
> the change as it wasn't totally clear even to me.

Thanks, sorry, and next time I will try to be more explicit.

Patch

diff --git a/net/8021q/vlanproc.c b/net/8021q/vlanproc.c
index 0feefa4..3628e0a 100644
--- a/net/8021q/vlanproc.c
+++ b/net/8021q/vlanproc.c
@@ -314,7 +314,7 @@  static int vlandev_seq_show(struct seq_file *seq, void *offset)
 		   dev_info->ingress_priority_map[6],
 		   dev_info->ingress_priority_map[7]);
 
-	seq_printf(seq, "EGRESSS priority Mappings: ");
+	seq_printf(seq, " EGRESS priority mappings: ");
 	for (i = 0; i < 16; i++) {
 		const struct vlan_priority_tci_mapping *mp
 			= dev_info->egress_priority_map[i];