diff mbox

[U-Boot,v2,3/3] arm: Warn that starting with v2018.01 gcc-6 or later is required

Message ID 1492435080-16788-1-git-send-email-trini@konsulko.com
State Accepted
Commit d2366dfe1d1c0b760022a034ced944784156c9d4
Delegated to: Tom Rini
Headers show

Commit Message

Tom Rini April 17, 2017, 1:18 p.m. UTC
There are more and more cases where if we do not use gcc-6.0 or later we
run into problems where our binaries are too large for the targets.
Given the prevalence of gcc-6.0 or later toolchains at this point in
time, we give notice now that starting with v2018.01 we will require
gcc-6 (or later) for ARM.

Signed-off-by: Tom Rini <trini@konsulko.com>
---
Changes in v2:
- Move logic out of THUMB check so we always do it, as noted by
  Masahiro.
- Reword the message slightly so it's shorter than 80 characters.
---
 arch/arm/config.mk | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

Comments

Tom Rini April 28, 2017, 1:07 p.m. UTC | #1
On Mon, Apr 17, 2017 at 09:18:00AM -0400, Tom Rini wrote:

> There are more and more cases where if we do not use gcc-6.0 or later we
> run into problems where our binaries are too large for the targets.
> Given the prevalence of gcc-6.0 or later toolchains at this point in
> time, we give notice now that starting with v2018.01 we will require
> gcc-6 (or later) for ARM.
> 
> Signed-off-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/arch/arm/config.mk b/arch/arm/config.mk
index 907c69371b94..eb09b0e37878 100644
--- a/arch/arm/config.mk
+++ b/arch/arm/config.mk
@@ -45,7 +45,7 @@  endif
 
 # Only test once
 ifeq ($(CONFIG_$(SPL_)SYS_THUMB_BUILD),y)
-archprepare: checkthumb
+archprepare: checkthumb checkgcc6
 
 checkthumb:
 	@if test "$(call cc-name)" = "gcc" -a \
@@ -55,8 +55,18 @@  checkthumb:
 		echo '*** Your board is configured for THUMB mode.'; \
 		false; \
 	fi
+else
+archprepare: checkgcc6
 endif
 
+checkgcc6:
+	@if test "$(call cc-name)" = "gcc" -a \
+			"$(call cc-version)" -lt "0600"; then \
+		echo -n '*** Your GCC is older than 6.0 and will not be '; \
+		echo 'supported starting in v2018.01.'; \
+	fi
+
+
 # Try if EABI is supported, else fall back to old API,
 # i. e. for example:
 # - with ELDK 4.2 (EABI supported), use: