From patchwork Fri Dec 10 16:58:26 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John David Anglin X-Patchwork-Id: 75109 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id D8A7BB7043 for ; Sat, 11 Dec 2010 03:58:38 +1100 (EST) Received: (qmail 8383 invoked by alias); 10 Dec 2010 16:58:35 -0000 Received: (qmail 8368 invoked by uid 22791); 10 Dec 2010 16:58:34 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL, BAYES_00, TW_BG, TW_IB, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from hiauly1.hia.nrc.ca (HELO hiauly1.hia.nrc.ca) (132.246.10.84) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 10 Dec 2010 16:58:29 +0000 Received: by hiauly1.hia.nrc.ca (Postfix, from userid 1000) id BD7FA4E2A; Fri, 10 Dec 2010 11:58:26 -0500 (EST) Date: Fri, 10 Dec 2010 11:58:26 -0500 From: John David Anglin To: Ralf Wildenhues , gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org Cc: libtool-patches@gnu.org Subject: Re: [patch libgfortran] path to libquadmath Message-ID: <20101210165825.GA28835@hiauly1.hia.nrc.ca> Reply-To: John David Anglin References: <20101128204243.GA2551@hiauly1.hia.nrc.ca> <20101128205655.GO2003@gmx.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20101128205655.GO2003@gmx.de> User-Agent: Mutt/1.5.16 (2007-06-09) Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Sun, 28 Nov 2010, Ralf Wildenhues wrote: > * John David Anglin wrote on Sun, Nov 28, 2010 at 09:42:43PM CET: > > The current relative path to libquadmath can be incorrectly interpreted > > on systems that hard code library paths. In particular, on 32-bit > > hppa*-*hpux*, the '..' part of the path is relative to the final executable. > > As a result, all libgfortran tests fail due to a dynamic loader error. > > > > The patch changes the path to an absolute path. > > > > Tested on hppa2.0w-hp-hpux11.11 and i686-apple-darwin9 with no observed > > regressions. > > > > OK for trunk? > > That doesn't seem to make sense to me. The fix should be in ltmain.sh > or in libtool.m4. Please post the output of how libquadmath is linked > on your system (the 'libtool --mode=link' command plus all of its > output). The attached change to ltmain.sh fixes the above problem on on 32-bit hppa*-*hpux*. Tested on hppa2.0w-hp-hpux11.11 and hppa64-hp-hpux11.11. Would you please apply if ok to libtool, gcc and sourceware? Thanks, Dave Index: ltmain.sh =================================================================== --- ltmain.sh (revision 167668) +++ ltmain.sh (working copy) @@ -5928,7 +5928,7 @@ test "$hardcode_direct_absolute" = no; then add="$dir/$linklib" elif test "$hardcode_minus_L" = yes; then - add_dir="-L$dir" + add_dir="-L$absdir" # Try looking first in the location we're being installed to. if test -n "$inst_prefix_dir"; then case $libdir in