From patchwork Fri Apr 14 16:58:25 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 750895 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3w4P656WB4z9s8F for ; Sat, 15 Apr 2017 02:59:57 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751696AbdDNQ7D (ORCPT ); Fri, 14 Apr 2017 12:59:03 -0400 Received: from mout.web.de ([212.227.15.14]:61971 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751463AbdDNQ7C (ORCPT ); Fri, 14 Apr 2017 12:59:02 -0400 Received: from [192.168.1.2] ([77.182.208.89]) by smtp.web.de (mrweb002 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MP047-1cwZZu3lUl-006P7E; Fri, 14 Apr 2017 18:58:34 +0200 To: linux-gpio@vger.kernel.org, Chris Packham , Kalyan Kinthada , Laxman Dewangan , Linus Walleij , Paul Gortmaker , Rob Herring , Russell King From: SF Markus Elfring Subject: [PATCH] pinctrl-armada-xp: Use devm_kmalloc_array() in armada_xp_pinctrl_probe() Cc: LKML , kernel-janitors@vger.kernel.org Message-ID: Date: Fri, 14 Apr 2017 18:58:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 Content-Language: en-GB X-Provags-ID: V03:K0:cuJ4mYfK90nSvm9mRa0WYZYRhQIApNffJvyVHOcHvE6nL4sMtK+ zpWsUOhJT64nXqba3zyWms+TCIbCSiEOs57l5VB5HpbmwVkKWkBb+7Z2TwJEvPyiMgG2l3j /4a2NVWWoA6irjxNklGOWMkKL1O2W+Qk0wRXcMeU08Nch7xa/VLZHtGZjfJTtSuiBn+/UyV GyhfD2w7/ry5kMSjs8C0A== X-UI-Out-Filterresults: notjunk:1; V01:K0:6ZNv5ZNA4AQ=:eoVq9ccS0A0zotXic7w9Bp GHyMlp4/JA2nH/DMzxq0IB6oiRwNgJyysK7QWt2sh5sjjGV9yPEHYYj0SCtk9VHQpoVdGMWWn NwfjRjlc78uouRcLaZz0brHJAFvntdAMKIDbBfwVuQXCMFSl7IpPFKrp+2zOio3BU2TCxIFst swEXXXSlZBtQMfAypwvZRLqcszbq0kaoWtyLzBUFa8m31IQhssh4zaJMXG5lNE4HSVQ7x48sl 63HPR1AZHktQ5WVVypy4sLX8FupjxogbvP+vgL94M0qZyO0C/r0XfdcdscbieZH9b5F4vf9Pt Rek8Bbqp+7XE/CIk8ZwCnHEWEYJEEjWfdJaBWYtNncmyfsnDA1QA3zVDWohfAw5mnaNm8vpNi +Cc0dgwwUy01SAgv+140fPEJkDq47LvnXktrlH3TKpjw9pye9af1Vply9r5Pu7cYzp9iOxuRL LjHgQ30yv7uG+iNQKhPzsOYXvF1ZIt6OtrmzV/b4J660dW6mzh/WHMTtP6/61vBANuhm46APd Kln0MJ3LEg/DZn5yhQXDGm4XQK/P01NqLmmvz2CaOtKy/CueIjDY2U8sB67CL8VHj2TAh5SJm djRjETqx05n76Ng6iKV8EjE3FEf118U2mIa/xCh2OTkb0rtXogMJSg7q0Bs1671Ce7Gfrbxd4 Ce8wOY8+U+21LiPuVwkkcgsBdHgmcUy7CmA9YspNfdBZ2hMkw1otJjN4MfCYgWnDe2p+wHqZN aMigufXYsOexeUrnZIMMLvJxhevWjiyEYQG6iCoLRAlJmFa6SKzENMKp6dG6BpAOgKfA3khra 72G0aFg Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org From: Markus Elfring Date: Fri, 14 Apr 2017 18:48:15 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "devm_kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. * Delete the local variable "nregs" which became unnecessary with this refactoring. Signed-off-by: Markus Elfring Reviewed-by: Chris Packham --- drivers/pinctrl/mvebu/pinctrl-armada-xp.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-xp.c b/drivers/pinctrl/mvebu/pinctrl-armada-xp.c index b854f1ee5de5..457c54c8fed3 100644 --- a/drivers/pinctrl/mvebu/pinctrl-armada-xp.c +++ b/drivers/pinctrl/mvebu/pinctrl-armada-xp.c @@ -574,7 +574,6 @@ static int armada_xp_pinctrl_probe(struct platform_device *pdev) struct mvebu_pinctrl_soc_info *soc = &armada_xp_pinctrl_info; const struct of_device_id *match = of_match_device(armada_xp_pinctrl_of_match, &pdev->dev); - int nregs; if (!match) return -ENODEV; @@ -628,10 +627,11 @@ static int armada_xp_pinctrl_probe(struct platform_device *pdev) break; } - nregs = DIV_ROUND_UP(soc->nmodes, MVEBU_MPPS_PER_REG); - - mpp_saved_regs = devm_kmalloc(&pdev->dev, nregs * sizeof(u32), - GFP_KERNEL); + mpp_saved_regs = devm_kmalloc_array(&pdev->dev, + DIV_ROUND_UP(soc->nmodes, + MVEBU_MPPS_PER_REG), + sizeof(*mpp_saved_regs), + GFP_KERNEL); if (!mpp_saved_regs) return -ENOMEM;