| Message ID | 1492180234-2496-1-git-send-email-aisheng.dong@nxp.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
> -----Original Message----- > From: Dong Aisheng [mailto:aisheng.dong@nxp.com] > Sent: Friday, April 14, 2017 10:31 PM > To: linux-kernel@vger.kernel.org > Cc: A.S. Dong; Rob Herring; Mark Rutland; devicetree@vger.kernel.org > Subject: [PATCH v2 1/2] dt-binding: regulator: anatop: make regulator name > property required > > We actually can't allow the missing of the regualor name, thus update the > binding doc to make regulator-name property to be required. > > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: devicetree@vger.kernel.org > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> Sorry, Mark, missed you about this one. Regards Dong Aisheng > --- > Documentation/devicetree/bindings/regulator/anatop-regulator.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/regulator/anatop- > regulator.txt b/Documentation/devicetree/bindings/regulator/anatop- > regulator.txt > index 1d58c8c..a3106c7 100644 > --- a/Documentation/devicetree/bindings/regulator/anatop-regulator.txt > +++ b/Documentation/devicetree/bindings/regulator/anatop-regulator.txt > @@ -2,6 +2,7 @@ Anatop Voltage regulators > > Required properties: > - compatible: Must be "fsl,anatop-regulator" > +- regulator-name: A string used as a descriptive name for regulator > +outputs > - anatop-reg-offset: Anatop MFD register offset > - anatop-vol-bit-shift: Bit shift for the register > - anatop-vol-bit-width: Number of bits used in the register > -- > 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Apr 14, 2017 at 10:30:33PM +0800, Dong Aisheng wrote: > We actually can't allow the missing of the regualor name, thus update > the binding doc to make regulator-name property to be required. > > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: devicetree@vger.kernel.org > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > --- > Documentation/devicetree/bindings/regulator/anatop-regulator.txt | 1 + > 1 file changed, 1 insertion(+) Acked-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Apr 19, 2017 at 03:33:03PM +0000, A.S. Dong wrote: > > We actually can't allow the missing of the regualor name, thus update the > > binding doc to make regulator-name property to be required. > Sorry, Mark, missed you about this one. Please resend, I don't have a copy.
diff --git a/Documentation/devicetree/bindings/regulator/anatop-regulator.txt b/Documentation/devicetree/bindings/regulator/anatop-regulator.txt index 1d58c8c..a3106c7 100644 --- a/Documentation/devicetree/bindings/regulator/anatop-regulator.txt +++ b/Documentation/devicetree/bindings/regulator/anatop-regulator.txt @@ -2,6 +2,7 @@ Anatop Voltage regulators Required properties: - compatible: Must be "fsl,anatop-regulator" +- regulator-name: A string used as a descriptive name for regulator outputs - anatop-reg-offset: Anatop MFD register offset - anatop-vol-bit-shift: Bit shift for the register - anatop-vol-bit-width: Number of bits used in the register
We actually can't allow the missing of the regualor name, thus update the binding doc to make regulator-name property to be required. Cc: Rob Herring <robh+dt@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: devicetree@vger.kernel.org Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> --- Documentation/devicetree/bindings/regulator/anatop-regulator.txt | 1 + 1 file changed, 1 insertion(+)