diff mbox

[net-next] ibmvnic: Report errors when failing to release sub-crqs

Message ID 20170414164517.50438.14612.stgit@ltcalpine2-lp23.aus.stglabs.ibm.com
State Changes Requested, archived
Delegated to: David Miller
Headers show

Commit Message

Nathan Fontenot April 14, 2017, 4:45 p.m. UTC 
From: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>

Add reporting of errors when releasing sub-crqs fails.

Signed-off-by: Thomas Falcon <tlfalcon@us.ibm.com>
Signed-off-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>
---
 drivers/net/ethernet/ibm/ibmvnic.c |    6 ++++++
 1 file changed, 6 insertions(+)

Comments

David Miller April 17, 2017, 5:49 p.m. UTC | #1 
Please do not submit a set of changes to the same driver like this.

Instead, submit a proper patch series which is numbered (so that the
dependencies betweeen changes, if any, are explciit) and also with
a proper "[PATCH 0/N] ..." header posting which describes what the
patch series is doing, how it is doing it, and why it is doing it
that way.

Thanks.
diff mbox

Patch

diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index 7ba43cf..7bf3507 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -1309,6 +1309,12 @@  static void release_sub_crq_queue(struct ibmvnic_adapter *adapter,
 					scrq->crq_num);
 	} while (rc == H_BUSY || H_IS_LONG_BUSY(rc));
 
+	if (rc) {
+		netdev_err(adapter->netdev,
+			   "Failed to release sub-CRQ %16lx, rc = %ld\n",
+			   scrq->crq_num, rc);
+	}
+
 	dma_unmap_single(dev, scrq->msg_token, 4 * PAGE_SIZE,
 			 DMA_BIDIRECTIONAL);
 	free_pages((unsigned long)scrq->msgs, 2);