From patchwork Fri Apr 14 09:07:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 750774 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3w4Bdp034Mz9sNZ for ; Fri, 14 Apr 2017 19:08:14 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753450AbdDNJIM (ORCPT ); Fri, 14 Apr 2017 05:08:12 -0400 Received: from mout.web.de ([212.227.15.3]:55022 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753383AbdDNJIL (ORCPT ); Fri, 14 Apr 2017 05:08:11 -0400 Received: from [192.168.1.2] ([77.182.208.89]) by smtp.web.de (mrweb002 [213.165.67.108]) with ESMTPSA (Nemesis) id 0LdEif-1cH7zn3W9B-00iXrU; Fri, 14 Apr 2017 11:07:55 +0200 Subject: [PATCH 02/10] pinctrl: imx: Use devm_kcalloc() in two functions From: SF Markus Elfring To: linux-gpio@vger.kernel.org, Arnd Bergmann , Gary Bisson , Laxman Dewangan , Linus Walleij , Paul Gortmaker , Peng Fan , Shawn Guo , Vladimir Zapolskiy References: <59fae4ac-9e07-232a-4843-92dd9e0cf2ef@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org Message-ID: <4c55e8b6-a904-408f-58c4-18f3053bb633@users.sourceforge.net> Date: Fri, 14 Apr 2017 11:07:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <59fae4ac-9e07-232a-4843-92dd9e0cf2ef@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:KArqCJ/kpoq+LxGmIjnA8JkgokCIg8Gc3VD6D939WOR0vPb6m3N T5r0nyAv341dY7SRJYCy1Z8LtLCLdXjTk7ccEx+Iiph0dg0vBbKBy2uqXWd+M4VAbQPcnKr 0d1avu2D7oAY3dWSJi0Ex9qU749Cb9uolNifDly58x3zaU6Hv4kyEdjgRKJ/0F2im/O8yLD 8IrZ38J6f2ihacgfg1Wog== X-UI-Out-Filterresults: notjunk:1; V01:K0:ksaXvtVRwwc=:+h8C9FJd+lv0O+Q6YBLkIp F/YHyMmannK3Qd76Er+fC8knJq/N7CJKHJNm65IYMmYGDzPOpU8L3CnRJRUQeqQ+sGzW8RQEc eC2Ty4/5CoM8+JdA8j/Q35lYRQDgDpi6N+K1n3Fumhtr9/rBRXsRS5z7uDZkZfU4kLlwdnaVm dJAwv0AHflkcJcTMuvE4z8BiynMKW5mRLVRVESNy/TsYwe0GkjbU1YRkXxx58bkLSOiT4tELd 1wbnsLtT9UxWY7QkpDdHHxrDar+9Ppslz9IkoMgytwXBfqJg8fcOZGn0uSn7jFiCyAzNlMhqM w0j+akNUyOStaqrhGPYDSh5BxiF+HG3x6JAsCJuFL+uW8BOaac/ET0JaWozPUpViAr4Q9dwpj mYsvBe0bbk5RwhVg86VIWUecSXNS3sAgQvvaghH1q7rDqVxpKE3yZC4I18bUCgTtc6LspGvH5 iTP7PBx6SRf/3/aQmifj1e/Q5e7JDehN/OYz2iHZxt4SSXS/YlfKPvLKmVF5XbExG5hy0nH/x fBHQkn6j+RbXFJGTxJJEVfQYNkc+YVKqWXVyrOnOuxc8yy5qvCq2ap4ZiCz7D51MrI/cB1N63 53wqXL2SVNMvvFz/unupaOVK1qno8IQ7ezkp0omjwjMA2qDJS6JXF5DskAXJElCldcA7dnNKH tvm9XdRpTev8yJzkA3HgquPH+AMjvfe+vSmyxAroaR7t6cyjoM8B8U9l0rrs/QQwK0u9hj72l 5+D279oJ1MNtO7SpDe8/Gnz3oom+NuzGpA3ggKCyA8k8BNdvizS823TrnBkGM9SXauZBZLouF SxUSaly Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org From: Markus Elfring Date: Thu, 13 Apr 2017 14:13:00 +0200 * Multiplications for the size determination of memory allocations indicated that array data structures should be processed. Thus use the corresponding function "devm_kcalloc". This issue was detected by using the Coccinelle software. * Replace the specification of data types by pointer dereferences to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/pinctrl/freescale/pinctrl-imx.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c index 563d24e7989d..975ed40cb774 100644 --- a/drivers/pinctrl/freescale/pinctrl-imx.c +++ b/drivers/pinctrl/freescale/pinctrl-imx.c @@ -509,10 +509,10 @@ static int imx_pinctrl_parse_groups(struct device_node *np, } grp->num_pins = size / pin_size; - grp->data = devm_kzalloc(info->dev, grp->num_pins * + grp->data = devm_kcalloc(info->dev, grp->num_pins, sizeof(struct imx_pin), GFP_KERNEL); - grp->pins = devm_kzalloc(info->dev, grp->num_pins * - sizeof(unsigned int), GFP_KERNEL); + grp->pins = devm_kcalloc(info->dev, grp->num_pins, + sizeof(*grp->pins), GFP_KERNEL); if (!grp->pins || !grp->data) return -ENOMEM; @@ -581,9 +581,10 @@ static int imx_pinctrl_parse_functions(struct device_node *np, dev_err(info->dev, "no groups defined in %s\n", np->full_name); return -EINVAL; } - func->group_names = devm_kzalloc(info->dev, - func->num_group_names * - sizeof(char *), GFP_KERNEL); + func->group_names = devm_kcalloc(info->dev, + func->num_group_names, + sizeof(*func->group_names), + GFP_KERNEL); for_each_child_of_node(np, child) { func->group_names[i] = child->name;