From patchwork Fri Apr 14 09:03:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 750772 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3w4BXd37QCz9sNW for ; Fri, 14 Apr 2017 19:03:45 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753820AbdDNJDa (ORCPT ); Fri, 14 Apr 2017 05:03:30 -0400 Received: from mout.web.de ([212.227.15.14]:50097 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751159AbdDNJD2 (ORCPT ); Fri, 14 Apr 2017 05:03:28 -0400 Received: from [192.168.1.2] ([77.182.208.89]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0McneT-1chhMX0OBt-00Hsj5; Fri, 14 Apr 2017 11:03:04 +0200 Subject: [PATCH 1/10] pinctrl: imx: Use kmalloc_array() in imx_dt_node_to_map() From: SF Markus Elfring To: linux-gpio@vger.kernel.org, Arnd Bergmann , Gary Bisson , Laxman Dewangan , Linus Walleij , Paul Gortmaker , Peng Fan , Shawn Guo , Vladimir Zapolskiy References: <59fae4ac-9e07-232a-4843-92dd9e0cf2ef@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org Message-ID: <7f118f52-1f64-36b2-c4f8-d5a6bf65b494@users.sourceforge.net> Date: Fri, 14 Apr 2017 11:03:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <59fae4ac-9e07-232a-4843-92dd9e0cf2ef@users.sourceforge.net> Content-Language: en-GB X-Provags-ID: V03:K0:Gb2L7W8pOPV6eaJVDngmYVbqus0f1Y3QKBN+KAXOVtcS3oub2DI a35VYRVWEhgIwZdeblAPeqmkci2TEyCFjjW8XF9oekeGJ0SVP8huHWlsMX5GuFI7A71Wzbz WWiTX6PON9aOdctI3atWFl1KOOjejnCYbKm891iq5sgYx1W4BjmxzTJnpiQwaDjasVGbMU1 D/S6kWqGc3F1R4mucoE8w== X-UI-Out-Filterresults: notjunk:1; V01:K0:kipDIc7VGTM=:1/7yzQ1VoQS7DfQyXLWSCQ mz4FNu9foylKLQM83FsCe46rXmMfC4N/4jNPHG71pOQ04BJlWLDrFdxo5A03knUKvKGBtjD9Z +K4TX0rbfulCBJF5G5ek7XmF8AqLHHQ8kXTSNlBzhociwSj0MWm//lQXsKGYdlkbC+Ngo1z4f ujbv2tEc90ly/jCnLYIElH8v+AQZ6+2hujeBRFTRWwr+cbEMoHA+3Ipri/AiJoDWeCj7Dvuz8 lJ3Sto3APXTy2wM9eiSaSzMN2yUdzdPduxVg4qcMo3/prq9MdZD+nS2gEcIeimQ8lGNh2YwRh db3PblsEkiXC8IZpmHDZU7gXwfhcc5ctwv4soaBnFJFvfBmoFn4kVSgRN/knW86r6wNIo+/3g qk2xYH7NKamBOePdJ/vhM0iTkD/vDR4wQFzpyRUd7bKok5ngY1asAB5GV55WnceNttGwK7AYR PoY8OCfeW09FIVYJ1Hm/kX8hTJRAAy8q9V3sQ+w6K0fk44Teezg8oEAYZu1PDYbeh3JRJ0lZd RC0Xg4381xKOmrC9EvnBmINtz7L8xrt4YZj4EldGe+uaz7cJuxHWr6CGNru3F/jqgosKiRlTL QenkXwDsmntOezIbJRKTkAgGhAFzCs4socEH+7j56q8DncuecQeWtsWSjBJwB/8dZBF0SgdAT 7FlrP01ynV/xi0S7OhvVy8DKA0K/5Enxo+covnlVB3uOVGw7JuEKbM75r/r72DcxuMmRI8p1M G04RYFLGXatg2E/+A6S5AeEEtMN14mnxGNJZkLMhPVCAdgZuWixB88oFz2ufb1Su3hS5gzTff enUYhG7 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org From: Markus Elfring Date: Thu, 13 Apr 2017 10:50:11 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/pinctrl/freescale/pinctrl-imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c index a7ace9e1ad81..563d24e7989d 100644 --- a/drivers/pinctrl/freescale/pinctrl-imx.c +++ b/drivers/pinctrl/freescale/pinctrl-imx.c @@ -98,7 +98,7 @@ static int imx_dt_node_to_map(struct pinctrl_dev *pctldev, map_num++; } - new_map = kmalloc(sizeof(struct pinctrl_map) * map_num, GFP_KERNEL); + new_map = kmalloc_array(map_num, sizeof(*new_map), GFP_KERNEL); if (!new_map) return -ENOMEM;