Patchwork [Maverick,SRU] (pre-stable) Fix mic for Dell Vostro 320

login
register
mail settings
Submitter David Henningsson
Date Dec. 10, 2010, 11:57 a.m.
Message ID <4D02159E.40806@canonical.com>
Download mbox | patch
Permalink /patch/75074/
State Accepted
Headers show

Comments

David Henningsson - Dec. 10, 2010, 11:57 a.m.
SRU Justification:

Impact: Non-working mic
Fix: Quirk into model "ideapad", tested by cert lab
Testcase: Try recording from mic

Upstream status: Not yet reached Linus's tree, commit id in Takashi's 
tree is 8a96b1e02029aa512199b1b6d281dcede9ed81f1.

Hope I did everything right this time :-)
Stefan Bader - Dec. 10, 2010, 2:19 p.m.
On 12/10/2010 12:57 PM, David Henningsson wrote:
> SRU Justification:
> 
> Impact: Non-working mic
> Fix: Quirk into model "ideapad", tested by cert lab
> Testcase: Try recording from mic
> 
> Upstream status: Not yet reached Linus's tree, commit id in Takashi's
> tree is 8a96b1e02029aa512199b1b6d281dcede9ed81f1.
> 
> Hope I did everything right this time :-)
> 
I am afraid, no. :-P The BugLink is invalid and should be:

http://bugs.launchpad.net/bugs/497546

Patch looks reasonable. Arguable whether we should wait to apply it until it has
at least made it into Linus tree. It is not a critical issue. On the other hand
it is simple enough and very limited in scope.

Acked-by: Stefan Bader <stefan.bader@canonical.com>
Brad Figg - Dec. 10, 2010, 3:38 p.m.
On 12/10/2010 06:19 AM, Stefan Bader wrote:
> On 12/10/2010 12:57 PM, David Henningsson wrote:
>> SRU Justification:
>>
>> Impact: Non-working mic
>> Fix: Quirk into model "ideapad", tested by cert lab
>> Testcase: Try recording from mic
>>
>> Upstream status: Not yet reached Linus's tree, commit id in Takashi's
>> tree is 8a96b1e02029aa512199b1b6d281dcede9ed81f1.
>>
>> Hope I did everything right this time :-)
>>
> I am afraid, no. :-P The BugLink is invalid and should be:
>
> http://bugs.launchpad.net/bugs/497546
>
> Patch looks reasonable. Arguable whether we should wait to apply it until it has
> at least made it into Linus tree. It is not a critical issue. On the other hand
> it is simple enough and very limited in scope.
>
> Acked-by: Stefan Bader<stefan.bader@canonical.com>
>

It's early so I might have missed it but the SRU text is missing from the
bug. Just adding it as a comment is acceptable, some folks modify the
bug description and add it there.

The patch looks fine however.

Acked-by: Brad Figg <brad.figg@canonical.com>

Brad
Tim Gardner - Dec. 10, 2010, 8:54 p.m.
On 12/10/2010 08:38 AM, Brad Figg wrote:
> On 12/10/2010 06:19 AM, Stefan Bader wrote:
>> On 12/10/2010 12:57 PM, David Henningsson wrote:
>>> SRU Justification:
>>>
>>> Impact: Non-working mic
>>> Fix: Quirk into model "ideapad", tested by cert lab
>>> Testcase: Try recording from mic
>>>
>>> Upstream status: Not yet reached Linus's tree, commit id in Takashi's
>>> tree is 8a96b1e02029aa512199b1b6d281dcede9ed81f1.
>>>
>>> Hope I did everything right this time :-)
>>>
>> I am afraid, no. :-P The BugLink is invalid and should be:
>>
>> http://bugs.launchpad.net/bugs/497546
>>
>> Patch looks reasonable. Arguable whether we should wait to apply it until it has
>> at least made it into Linus tree. It is not a critical issue. On the other hand
>> it is simple enough and very limited in scope.
>>
>> Acked-by: Stefan Bader<stefan.bader@canonical.com>
>>
>
> It's early so I might have missed it but the SRU text is missing from the
> bug. Just adding it as a comment is acceptable, some folks modify the
> bug description and add it there.
>
> The patch looks fine however.
>
> Acked-by: Brad Figg<brad.figg@canonical.com>
>
> Brad

And while you're fixing the commit log, reformat the patch so that it 
applies to Maverick.

rtg

Patch

From 8a96b1e02029aa512199b1b6d281dcede9ed81f1 Mon Sep 17 00:00:00 2001
From: David Henningsson <david.henningsson@canonical.com>
Date: Thu, 9 Dec 2010 07:17:27 +0100
Subject: [PATCH] ALSA: HDA: Quirk for Dell Vostro 320 to make microphone work

BugLink: http://launchpad.net/497546

Confirmed that the ideapad model works better than the current
quirk for Dell Vostro 320.

Cc: stable@kernel.org (2.6.35+)
Signed-off-by: David Henningsson <david.henningsson@canonical.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/pci/hda/patch_conexant.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
index 4ab5ea9..76bd58a 100644
--- a/sound/pci/hda/patch_conexant.c
+++ b/sound/pci/hda/patch_conexant.c
@@ -3096,8 +3096,7 @@  static const char *cxt5066_models[CXT5066_MODELS] = {
 static struct snd_pci_quirk cxt5066_cfg_tbl[] = {
 	SND_PCI_QUIRK_MASK(0x1025, 0xff00, 0x0400, "Acer", CXT5066_IDEAPAD),
 	SND_PCI_QUIRK(0x1028, 0x02d8, "Dell Vostro", CXT5066_DELL_VOSTRO),
-	SND_PCI_QUIRK(0x1028, 0x02f5, "Dell",
-		      CXT5066_DELL_LAPTOP),
+	SND_PCI_QUIRK(0x1028, 0x02f5, "Dell Vostro 320", CXT5066_IDEAPAD),
 	SND_PCI_QUIRK(0x1028, 0x0402, "Dell Vostro", CXT5066_DELL_VOSTRO),
 	SND_PCI_QUIRK(0x1028, 0x0408, "Dell Inspiron One 19T", CXT5066_IDEAPAD),
 	SND_PCI_QUIRK(0x103c, 0x360b, "HP G60", CXT5066_HP_LAPTOP),
-- 
1.7.1