gpio: dwapb: use dwapb_read instead of readl_relaxed

Message ID 20170413094639.484-1-jszhang@marvell.com
State New
Headers show

Commit Message

Jisheng Zhang April 13, 2017, 9:46 a.m.
Commit 67809b974a07 ("GPIO: gpio-dwapb: Change readl&writel to
dwapb_read&dwapb_write") missed this readl_relaxed() usage, I'm not
sure the reason, maybe for performance reason? But if we do care
the performance, we could use the relaxed io in dwapb_read and
dwapb_write.

Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
 drivers/gpio/gpio-dwapb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Linus Walleij April 24, 2017, 1:09 p.m. | #1
On Thu, Apr 13, 2017 at 11:46 AM, Jisheng Zhang <jszhang@marvell.com> wrote:

> Commit 67809b974a07 ("GPIO: gpio-dwapb: Change readl&writel to
> dwapb_read&dwapb_write") missed this readl_relaxed() usage, I'm not
> sure the reason, maybe for performance reason? But if we do care
> the performance, we could use the relaxed io in dwapb_read and
> dwapb_write.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>

Patch applied.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
index 9c15ee4ef4e9..fe6cdb5d03d9 100644
--- a/drivers/gpio/gpio-dwapb.c
+++ b/drivers/gpio/gpio-dwapb.c
@@ -128,7 +128,7 @@  static void dwapb_toggle_trigger(struct dwapb_gpio *gpio, unsigned int offs)
 
 static u32 dwapb_do_irq(struct dwapb_gpio *gpio)
 {
-	u32 irq_status = readl_relaxed(gpio->regs + GPIO_INTSTATUS);
+	u32 irq_status = dwapb_read(gpio, GPIO_INTSTATUS);
 	u32 ret = irq_status;
 
 	while (irq_status) {