Patchwork [03/15] rtc: Remove duplicate unlikely from IS_ERR

login
register
mail settings
Submitter Joe Perches
Date Dec. 9, 2010, 8:03 p.m.
Message ID <29ab1782961e5d9b56972818f12eb7a2e5bd4329.1291923889.git.joe@perches.com>
Download mbox | patch
Permalink /patch/74976/
State New
Headers show

Comments

Joe Perches - Dec. 9, 2010, 8:03 p.m.
IS_ERR already uses unlikely, remove unlikely from the call sites.

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/rtc/rtc-bfin.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Mike Frysinger - Dec. 9, 2010, 8:06 p.m.
On Thu, Dec 9, 2010 at 15:03, Joe Perches wrote:
> IS_ERR already uses unlikely, remove unlikely from the call sites.

Tobias already submitted a patch for this.  and i cc-ed you on it.
-mike
Joe Perches - Dec. 9, 2010, 8:28 p.m.
On Thu, 2010-12-09 at 15:06 -0500, Mike Frysinger wrote:
> On Thu, Dec 9, 2010 at 15:03, Joe Perches wrote:
> > IS_ERR already uses unlikely, remove unlikely from the call sites.
> Tobias already submitted a patch for this.

Thanks Tobias.  Turns out you did them all after all.
Could you please cc linux-kernel for these sorts of patches?

As far as I can tell, the rtc-bfin patch didn't hit lkml,
only the c2port patch did for whatever reason.

The patches aren't marked as an n/m series which would also help
identify the patch scope.  I thought it was a singleton.

Jiri and all others, please ignore my duplicate patchset.

cheers, Joe
Tobias Klauser - Dec. 10, 2010, 9:19 a.m.
On 2010-12-09 at 21:28:47 +0100, Joe Perches <joe@perches.com> wrote:
> On Thu, 2010-12-09 at 15:06 -0500, Mike Frysinger wrote:
> > On Thu, Dec 9, 2010 at 15:03, Joe Perches wrote:
> > > IS_ERR already uses unlikely, remove unlikely from the call sites.
> > Tobias already submitted a patch for this.
> 
> Thanks Tobias.  Turns out you did them all after all.
> Could you please cc linux-kernel for these sorts of patches?

I'll do so in the future. Sorry about that. I only cc'ed them all to
kernel-janitors.

> As far as I can tell, the rtc-bfin patch didn't hit lkml,
> only the c2port patch did for whatever reason.

That was because I didn't find anyone else to send it to in MAINTAINERS.

> The patches aren't marked as an n/m series which would also help
> identify the patch scope.  I thought it was a singleton.

I thought I'll send them unnumbered because they touch various different
subsystems and drivers. But in this case I'll send such patche series
numbered too in the future.

Thanks a lot
Tobias

Patch

diff --git a/drivers/rtc/rtc-bfin.c b/drivers/rtc/rtc-bfin.c
index b4b6087..4ba3e33 100644
--- a/drivers/rtc/rtc-bfin.c
+++ b/drivers/rtc/rtc-bfin.c
@@ -383,7 +383,7 @@  static int __devinit bfin_rtc_probe(struct platform_device *pdev)
 	/* Register our RTC with the RTC framework */
 	rtc->rtc_dev = rtc_device_register(pdev->name, dev, &bfin_rtc_ops,
 						THIS_MODULE);
-	if (unlikely(IS_ERR(rtc->rtc_dev))) {
+	if (IS_ERR(rtc->rtc_dev)) {
 		ret = PTR_ERR(rtc->rtc_dev);
 		goto err;
 	}