| Message ID | BM1PR01MB072299B8CAFBB379F8BF8DE584000@BM1PR01MB0722.INDPRD01.PROD.OUTLOOK.COM |
|---|---|
| State | New |
| Headers | show |
On Tue, Apr 11, 2017 at 08:04:43PM +0000, Prerna Garg wrote: > From 9e25fdf1ea3e4f52a72bfefc053a701989b7af24 Mon Sep 17 00:00:00 2001 > From: Prerna Garg <prerna.garg@live.com> > Date: Wed, 12 Apr 2017 01:29:40 +0530 Please resend using git-send-email(1) so that email is properly formatted for git-am(1) and other tools who will process it. qemu-devel@nongnu.org receives many patch emails every day that both human maintainers and bots process. Unfortunately free-form patch submission doesn't scale so we all have to follow the guidelines: http://wiki.qemu-project.org/Contribute/SubmitAPatch I suggest sending the email to just yourself first so you can confirm that it meets the guidelines. > Subject: [PATCH 2/2] Changed malloc and free to g_malloc and g_free in > util/compatfd.c Please follow the commit message conventions: compatfd: replace malloc() with g_malloc() The first part is a prefix that indicates which component in QEMU is affected. You can use "git log path/to/file.c" to see what prefix is commonly used for a file. The second part is a brief summary written in present imperative. > > Signed-off-by: Prerna Garg <prerna.garg@live.com> > --- > util/compatfd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/util/compatfd.c b/util/compatfd.c > index 980bd33..7bf1344 100644 > --- a/util/compatfd.c > +++ b/util/compatfd.c > @@ -71,14 +71,14 @@ static int qemu_signalfd_compat(const sigset_t *mask) > QemuThread thread; > int fds[2]; > > - info = malloc(sizeof(*info)); > + info = g_malloc(sizeof(*info)); > if (info == NULL) { > errno = ENOMEM; > return -1; > } > > if (pipe(fds) == -1) { > - free(info); > + g_free(info); > return -1; > } Looks good.
From 9e25fdf1ea3e4f52a72bfefc053a701989b7af24 Mon Sep 17 00:00:00 2001 From: Prerna Garg <prerna.garg@live.com> Date: Wed, 12 Apr 2017 01:29:40 +0530 Subject: [PATCH 2/2] Changed malloc and free to g_malloc and g_free in util/compatfd.c Signed-off-by: Prerna Garg <prerna.garg@live.com> --- util/compatfd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/compatfd.c b/util/compatfd.c index 980bd33..7bf1344 100644 --- a/util/compatfd.c +++ b/util/compatfd.c @@ -71,14 +71,14 @@ static int qemu_signalfd_compat(const sigset_t *mask) QemuThread thread; int fds[2]; - info = malloc(sizeof(*info)); + info = g_malloc(sizeof(*info)); if (info == NULL) { errno = ENOMEM; return -1; } if (pipe(fds) == -1) { - free(info); + g_free(info); return -1; } -- 2.7.4