From patchwork Tue Apr 11 17:21:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Daney X-Patchwork-Id: 749571 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3w2Yl36v9Mz9s8Y for ; Wed, 12 Apr 2017 03:22:07 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=CAVIUMNETWORKS.onmicrosoft.com header.i=@CAVIUMNETWORKS.onmicrosoft.com header.b="H1OtimWY"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751890AbdDKRV0 (ORCPT ); Tue, 11 Apr 2017 13:21:26 -0400 Received: from mail-by2nam01on0051.outbound.protection.outlook.com ([104.47.34.51]:36944 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751824AbdDKRVV (ORCPT ); Tue, 11 Apr 2017 13:21:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=vEkNADrcI/yYCW12RWdyeqTfc1ShU4webbFwo2Ufw78=; b=H1OtimWYJMzChutt5FDUnviB5SkTCHjCEM7zVVaZF/lx/OMGLQJzMuaWaiBSlXFo8UZFT4OEOxD0VacxRaPy4TCdGUg0Cl8fbb7Q3OWEyNp4EkhXhzv3o1jZJ301gBRA8gS24g3rVsxs84lXrkQyiNEJKIornaFaq9vKscE/GmA= Authentication-Results: linaro.org; dkim=none (message not signed) header.d=none; linaro.org; dmarc=none action=none header.from=cavium.com; Received: from localhost.caveonetworks.com (50.233.148.156) by DM5PR07MB3498.namprd07.prod.outlook.com (10.164.153.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1019.17; Tue, 11 Apr 2017 17:21:18 +0000 From: David Daney To: Linus Walleij , Alexandre Courbot , Rob Herring , Mark Rutland , Marc Zyngier , Thomas Gleixner , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, David Daney Subject: [PATCH v6 3/6] irqdomain: Add irq_domain_{push, pop}_irq() functions. Date: Tue, 11 Apr 2017 10:21:06 -0700 Message-Id: <1491931269-15650-4-git-send-email-david.daney@cavium.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1491931269-15650-1-git-send-email-david.daney@cavium.com> References: <1491931269-15650-1-git-send-email-david.daney@cavium.com> MIME-Version: 1.0 X-Originating-IP: [50.233.148.156] X-ClientProxiedBy: SN2PR07CA009.namprd07.prod.outlook.com (10.255.174.26) To DM5PR07MB3498.namprd07.prod.outlook.com (10.164.153.29) X-MS-Office365-Filtering-Correlation-Id: 78c3d197-2ef3-4324-9585-08d480ff2ac0 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:DM5PR07MB3498; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3498; 3:okj3+4aBUOCocJB1XXitaLOKg4DSyytZSuMj35woj7Gshgp69WEauAMwQhcAZiv1ggPgZXIqy6YgoNNJ3LTtR5FHMd8DNFS6yBnDqyB3QJrVdWRCe84QGKsslutIXjdKrWGs+RRYWOoe2bDPfYPxUh4WNiG5s0qDdaxtBWAedvNcnazizHSOSdLZ3qekcw+ugYFWc4kqFo6KZV99xkP1PlTRIQnqupwk8aNXjl/Opo/AshGLHV7BRuDphNdOqoO4fX6NmhyJOPyQKh/rmuwHYvzAaSq3TS+wkwcJCSpvVJJvOVlIzo4GbNAYDJNeoRstAu7aXRwcFN/lxbyTSl+2iQ==; 25:WsoV124n1gN6RSWqhXp2+xeaT7X5EsBgOkmlaP4C5C4l0HLpjvqAPX1WKBloOnLY9BWyRRbtdhaEYjdIXgyGKW4r2byVKmHgHY1tCVDB4NanCLPIc/A3oDy7ba0ZeZBEXZleSLn8bQGAwb+TSbEInC1rs18DD0RaLjPJMVfY6ejmnEgEw2ZL1MsZHDgKSGrVAZkQ+eW2hmhg7nP4a7K9k/V77uMmA/8MVRj0sJQhpB+pfx24KrM8QmaGvfb1ZPPaN5tlAMtzmcpzvu9Yp73SiuqbAJ/cU/jM5c2OCkXg73O2sK08zDT77tOzLpDh0fJtKaCvFLy9Z0bxJyDcBeKvD69VSzBpO18kyD7w0cwesPErz4OSNh7v2gtj3eAtft/fOSkkNI1vkXdjgqZovZK8C9zhoD8UR2SY+caVWXkDYt6WH9KDCWT+yI/WqkRHIEISSwXoFT5nZZfNy6LAoqMyhw== X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3498; 31:oJSPfys4XjceSa7jBzYFvCASxTYvrpm8cSgh4t9xjav+lj46DYrpyXs+CrkffAM+jzLxzqyFe4j1uCg0+3irM/34hc9VVekTCfB/ldok4dYUelildNXB0dBCKjYjz3CsWWDm7iDfnFW3b5wJOX+E8q7OvixqnhcNzGL8hEbcwzrquxmR8/nWOKu0bteWiVPpSCGGz3IxkUS2ns5EKiRsLaz6rkdz9kQQkeuDup53bMo=; 20:l2EdOFWZDNELIfkr0VHsJ1jxdUiRqFHvX7faUfmsyM31/8ouHH7TViY8Psboas/6sMDL8cZSJ5Fwn3UoLjdhJKtKG0NzCq+xhu6Tu9q2/A5J4pzpzNfrDKMg6f6ORSLpXJLXzYoONMCxk7sp9SxPtIV6N2yva1iD6+GGg2VF/srymkGzv+tAUsVLkr/xzDqwNSvZu05dkkP32rbTGtFvyvUDh2mdIUFyWbGLr031A148/mvjf7zU8QRQE4Qlo5rCCCwXvDSX6/ejAZavqAWjnY7skSmQ2Ru68jZ1a3P44BtJ/onV8v4u5QZzgQPZ/tUD+VTsFy/HJU/UoBG41aJo+qAUxyeGWiE8JrMttZSLa1LZxmnPv1/AJu/6gWY6EIgsZvlEY1HaPzJ26RDby1Xg3KSgpCoug/oAY3i265y2/U/XF6a+Y3Wwcj0fbIoZJFn7V1R0HWf9dKsUc6/tlNN7mrEb8eNgqb+KQ6cKEkYwQEzyl2ehSAb0y1DszbBjx4Pe X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(6041248)(20161123555025)(20161123564025)(20161123562025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(6072148); SRVR:DM5PR07MB3498; BCL:0; PCL:0; RULEID:; SRVR:DM5PR07MB3498; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3498; 4:nrnJAwaxkzwy6dP5MqSTW50qtPfDv4cfzY9HOW2UJljtBkzHBL5B5mkGjstHyjtmAbBxAHg2t7yNpTTCJ9WhREMua8yqNiQ+4Y6pwpHian+TJ/G08Ej1JQjCeAT9nsrQvPkcxdVo9g29U/MhwXwZTyL9mUeYmTuIT1Jdubk/nLk7LSQUT7WySUOabwopuRMkrD1NJLKAM+CNe0XoYeeBXajpBoE2UUYAkmNXhkT66cCyXMQI5loK/2zbrjpqBTgQ2CH3Ze1SbBR6Jvs8gTb/9tr0mtg/HbD/jKT7pNVBixJ/QvlET9MnHyp/xr/47dK2Rfv1HE1Mi7aIrLdN5hM1ADp8gp7IBSpEgJNjz0P0hwgVF5oWrKvOfffSKhfMAL2nekG3LTDoCwuUU1EVXEH3QerUjdNPsNHu3SHEQG1sknjuOfQsewYr2jfljK67BHfPQPpTCkN/giOvs3bAZSVS6ycfAkCEfUbgbfT3Gy2GVeHMPlDz9lOV5pOsNOY2qSnrQSHG+2x4MgX3atYfZmPUO2WG0F7FUGMq7zoTBLpFi2VxjzEQYWHXEjla6UDGcZJGneNSyx81Ckfep5jcw6apaCduV2UafeZMoj+eITGf0etjLBheXDvouswTWvJsPl+a7e/Mo+Hzvh5jhBymgOXYuUdhj9Qe4UAoLKwHh908Zah8Kmzr3cHH06I5lJitE3cJNyAuLREdHd6E/wSdjDSAtA== X-Forefront-PRVS: 0274272F87 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6069001)(39450400003)(39400400002)(39850400002)(39840400002)(39410400002)(47776003)(36756003)(5660300001)(66066001)(7736002)(305945005)(5003940100001)(42186005)(53416004)(76506005)(2950100002)(4720700003)(189998001)(6666003)(53936002)(6116002)(25786009)(50986999)(50466002)(76176999)(3846002)(48376002)(6486002)(6512007)(8676002)(81166006)(50226002)(6506006)(33646002)(107886003)(4326008)(86362001)(2906002)(38730400002)(142933001); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB3498; H:localhost.caveonetworks.com; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR07MB3498; 23:jOSACtSIuOPtrSHgMdS+63Re1ytzHrKqst0koEJyO?= =?us-ascii?Q?hlWUiQXYX8on/yWQu6RKmlEDAWBkqH5+oQ3FYlVsDJ1YykS3xVYjrOhJ3W1o?= =?us-ascii?Q?uiLI5tRjraNZeUc6KRW1ak1HiOtR+UpIV73w+nkBjq4NgLBFlnD7CsXArert?= =?us-ascii?Q?gFRVFWEkf+55tbEgPwiDaAPKGFidvUGeollMY6sBSXZAF1tn0qa4xd1VMam7?= =?us-ascii?Q?WPqMGGBAh9ALq7xLCrRHHJJSmkkwPEMOY+plVqm3jxoTdgs1TDFY+afkXPf7?= =?us-ascii?Q?v7YcDV1Wb2TX3AgYkqnz//lFf9A+ZZpXpwLWfcIo5ZSiQBabhRx05LMk7BfB?= =?us-ascii?Q?98OGWb7ZMYbMTMc2slxQtvmAzDwYY2pY7PdPe/wEhXFdRFu2pwYTRob434nC?= =?us-ascii?Q?XO/ryFXpSg2DBQWy2OYj5YB0Rq5EqhnBIDS8fduBP8/SUNGkBy/L9Za17C45?= =?us-ascii?Q?BrXyaF41urNaP1Lzgjs7F0cXRDVnmqDOvcLzTPvm3AwcPtxdvXYFawCuszPz?= =?us-ascii?Q?ZiXZQ96TcRZUaBIR5sI2Bz0NxbfqpBveLtTKNve8vr2zUru2XKm2li8WtNzx?= =?us-ascii?Q?ieBk/9h/lXmvasSasQt1k/XeApmQWP0LJf40kx5gkOM4ilxj0bxGO8MgkS5Y?= =?us-ascii?Q?PBRSGKvhtfdfjZb+CF7vh1I0SmcYjzIwG2gp3rMp55Fgchf8vO/uUOkoeRCE?= =?us-ascii?Q?XLjVPTYJMLUAYSF0qj9p3j4inKKUFrQ+EXy3rf/eCoJUE7G7JDCPs0Q9BYI4?= =?us-ascii?Q?22Os0x9yWNR/VZUQx2wB8PWGtxjU2Cn46mNhVt8Mp9I+bW7hf6sIbsZwnZFQ?= =?us-ascii?Q?2Mmp1nwg4PBnt/58QDMUvxX3DRYiLTTpCBTiR8hdEvYbfFDIZ4L+JHGZHPVO?= =?us-ascii?Q?7c1Hyc16SU7YPzj/UcI/8H8kNKcR8IkObhOQ0g2L2kVyA4Dh1vvqWw1aRbsX?= =?us-ascii?Q?pbo4L2YbY+WRUZJho0TAJDdtZEV+4Xx/xTX/WEuWWIdbdbIUBQDDOsI3f8GU?= =?us-ascii?Q?dQF/X3mNTb93JSRj1mFpPqhxLKEabxxdC8Uqm1uKThgxuiUZNxRxehAoWG8b?= =?us-ascii?Q?bvrW0DDNGcXV48BoRPvA/TnImhjax5rydw24m5qMcioYkHBcA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3498; 6:v/aKDnbcF3qO64e0EzrvYVCM+vE3DpdrNxGsKm1T2A4h29H82K07JyKbz8YnJTwLBIFGKnP/RGt2lY41gH3TkyXu2mibtk6ABOCcGFQIoImM/mLdtyIWajaCWtq0+9NKbbpIeN0GgwcJDsDLNsQXYv/yEqUrG88DxmS/znjiEO9n45yJnLM59g2BgCENTWAlvubu4eMJp/eGrXgjzldG96KtB4aR5PEVor+thD2oPRv7HpL80UPNj1ttKtXD1YPc6nqER5sPGTxaV0ZIO87++DTUWMsySIs4tq66DUv9MUmtRNmzdY3OYH0tbV5efBvwV56hkOpEFdUgr7JnBFy9FZDEX/Oyix5hTAaQ90cAJ2R710QPF+0xjsX93+4pZlOfKBilog7Ew2FAMjBVKMU6dGCUIwLUgzfcOGpL+agd3ZALvX8y2XWkxj+3EOao5wytvvGjd2Bn35IdcAHC/hs/cA==; 5:Hx7XGsWkWgD4bXvVRqzn5uta+2Qom3q0352YGGSEbnO0UsnfRjtKk3lfcYNTfMwNo0JKtdNe4sZxl0l/tJEfFuks62MgoH65Lr0/puGgDsMP685XPOdkOCMihoKW33XDOBfqD46goTowiWa3wAyt6Q==; 24:r/oHkeSb7ca2CM9y+FK3n4PDcLmf6keu3Ro7Qd0OY2DFA24gchiNxtassDeMgtLqmkhc8loXfg8oLNQVMBL7sTPt7x5VHOf+ULI2Bicgo3I= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3498; 7:fry64o+/IDZ+S3aP8KG8tgD/t4EXsPoLJeJYcUlfrqg2TbWYNzwu3ds6F3m9dhLg7wX9L3lj/DkwTh4b6TGjDQsWoBphwc3ThI/PH9h+QL1BorzQ00GyteM+fYX8mj3sZTteoyKx/Ywy8YurMVGwlKwaKCByWecfDV/yPMxopOVxAvgmhCDoVMZXwsPK3vRnrQtzw0XwT1mO/+6biXBkmxhhQhezr47PY2/9TDugVIC96TzGkAyHgR6pASpRRo56AOO3AD26hcmXwlt5+cSB9LQwzGXgQYmYK6a8Sic7Zk4jmz3G6q4vnLjNCvw+pDIX//UDhYnWg+s6p8e4e+P+fA== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2017 17:21:18.0367 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3498 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org For an already existing irqdomain hierarchy, as might be obtained via a call to pci_enable_msix_range(), a PCI driver wishing to add an additional irqdomain to the hierarchy needs to be able to insert the irqdomain to that already initialized hierarchy. Calling irq_domain_create_hierarchy() allows the new irqdomain to be created, but no existing code allows for initializing the associated irq_data. Add a couple of helper functions (irq_domain_push_irq() and irq_domain_pop_irq()) to initialize the irq_data for the new irqdomain added to an existing hierarchy. Signed-off-by: David Daney --- include/linux/irqdomain.h | 3 + kernel/irq/irqdomain.c | 178 ++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 181 insertions(+) diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h index 9f36160..0316846 100644 --- a/include/linux/irqdomain.h +++ b/include/linux/irqdomain.h @@ -425,6 +425,9 @@ extern void irq_domain_free_irqs_common(struct irq_domain *domain, extern void irq_domain_free_irqs_top(struct irq_domain *domain, unsigned int virq, unsigned int nr_irqs); +extern int irq_domain_push_irq(struct irq_domain *domain, int virq, void *arg); +extern int irq_domain_pop_irq(struct irq_domain *domain, int virq); + extern int irq_domain_alloc_irqs_parent(struct irq_domain *domain, unsigned int irq_base, unsigned int nr_irqs, void *arg); diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c index 31805f2..ea9d30d 100644 --- a/kernel/irq/irqdomain.c +++ b/kernel/irq/irqdomain.c @@ -1304,6 +1304,184 @@ int __irq_domain_alloc_irqs(struct irq_domain *domain, int irq_base, return ret; } +/* The irq_data was moved, fix the revmap to refer to the new location */ +static void irq_domain_fix_revmap(struct irq_data *d) +{ + void **slot; + + if (d->hwirq < d->domain->revmap_size) + return; /* Not using radix tree. */ + + /* Fix up the revmap. */ + mutex_lock(&revmap_trees_mutex); + slot = radix_tree_lookup_slot(&d->domain->revmap_tree, d->hwirq); + if (slot) + radix_tree_replace_slot(&d->domain->revmap_tree, slot, d); + mutex_unlock(&revmap_trees_mutex); +} + +/** + * irq_domain_push_irq() - Push a domain in to the top of a hierarchy. + * @domain: Domain to push. + * @virq: Irq to push the domain in to. + * @arg: Passed to the irq_domain_ops alloc() function. + * + * For an already existing irqdomain hierarchy, as might be obtained + * via a call to pci_enable_msix(), add an additional domain to the + * head of the processing chain. Must be called before request_irq() + * has been called. + */ +int irq_domain_push_irq(struct irq_domain *domain, int virq, void *arg) +{ + struct irq_data *child_irq_data; + struct irq_data *root_irq_data = irq_get_irq_data(virq); + struct irq_desc *desc; + int rv = 0; + + /* + * Check that no action has been set, which indicates the virq + * is in a state where this function doesn't have to deal with + * races between interrupt handling and maintaining the + * hierarchy. This will catch gross misuse. Attempting to + * make the check race free would require holding locks across + * calls to struct irq_domain_ops->alloc(), which could lead + * to deadlock, so we just do a simple check before starting. + */ + desc = irq_to_desc(virq); + if (!desc) + return -EINVAL; + if (WARN_ON(desc->action)) + return -EBUSY; + + if (domain == NULL) + return -EINVAL; + + if (WARN_ON(!domain->ops->alloc)) + return -EINVAL; + + if (!root_irq_data) + return -EINVAL; + + child_irq_data = kzalloc_node(sizeof(*child_irq_data), GFP_KERNEL, + irq_data_get_node(root_irq_data)); + if (!child_irq_data) + return -ENOMEM; + + mutex_lock(&irq_domain_mutex); + + /* Copy the original irq_data. */ + *child_irq_data = *root_irq_data; + + irq_domain_fix_revmap(child_irq_data); + + /* + * Overwrite the root_irq_data, which is embedded in struct + * irq_desc, with values for this domain. + */ + root_irq_data->parent_data = child_irq_data; + root_irq_data->domain = domain; + root_irq_data->mask = 0; + root_irq_data->hwirq = 0; + root_irq_data->chip = NULL; + root_irq_data->chip_data = NULL; + rv = domain->ops->alloc(domain, virq, 1, arg); + if (rv) { + /* Restore the original irq_data. */ + *root_irq_data = *child_irq_data; + irq_domain_fix_revmap(root_irq_data); + goto error; + } + + if (root_irq_data->hwirq < domain->revmap_size) { + domain->linear_revmap[root_irq_data->hwirq] = virq; + } else { + mutex_lock(&revmap_trees_mutex); + radix_tree_insert(&domain->revmap_tree, + root_irq_data->hwirq, root_irq_data); + mutex_unlock(&revmap_trees_mutex); + } +error: + mutex_unlock(&irq_domain_mutex); + + return rv; +} +EXPORT_SYMBOL_GPL(irq_domain_push_irq); + +/** + * irq_domain_pop_irq() - Remove a domain from the top of a hierarchy. + * @domain: Domain to remove. + * @virq: Irq to remove the domain from. + * + * Undo the effects of a call to irq_domain_push_irq(). Must be + * called either before request_irq() or after free_irq(). + */ +int irq_domain_pop_irq(struct irq_domain *domain, int virq) +{ + struct irq_data *root_irq_data = irq_get_irq_data(virq); + struct irq_data *child_irq_data; + struct irq_data *tmp_irq_data; + struct irq_desc *desc; + + /* + * Check that no action is set, which indicates the virq is in + * a state where this function doesn't have to deal with races + * between interrupt handling and maintaining the hierarchy. + * This will catch gross misuse. Attempting to make the check + * race free would require holding locks across calls to + * struct irq_domain_ops->free(), which could lead to + * deadlock, so we just do a simple check before starting. + */ + desc = irq_to_desc(virq); + if (!desc) + return -EINVAL; + if (WARN_ON(desc->action)) + return -EBUSY; + + if (domain == NULL) + return -EINVAL; + + if (!root_irq_data) + return -EINVAL; + + tmp_irq_data = irq_domain_get_irq_data(domain, virq); + + /* We can only "pop" if this domain is at the top of the list */ + if (WARN_ON(root_irq_data != tmp_irq_data)) + return -EINVAL; + + if (WARN_ON(root_irq_data->domain != domain)) + return -EINVAL; + + child_irq_data = root_irq_data->parent_data; + if (WARN_ON(!child_irq_data)) + return -EINVAL; + + mutex_lock(&irq_domain_mutex); + + root_irq_data->parent_data = NULL; + + if (root_irq_data->hwirq >= domain->revmap_size) { + mutex_lock(&revmap_trees_mutex); + radix_tree_delete(&domain->revmap_tree, root_irq_data->hwirq); + mutex_unlock(&revmap_trees_mutex); + } + + if (domain->ops->free) + domain->ops->free(domain, virq, 1); + + /* Restore the original irq_data. */ + *root_irq_data = *child_irq_data; + + irq_domain_fix_revmap(root_irq_data); + + mutex_unlock(&irq_domain_mutex); + + kfree(child_irq_data); + + return 0; +} +EXPORT_SYMBOL_GPL(irq_domain_pop_irq); + /** * irq_domain_free_irqs - Free IRQ number and associated data structures * @virq: base IRQ number