Message ID | 1491909188-8971-2-git-send-email-fugang.duan@nxp.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show
Return-Path: <netdev-owner@vger.kernel.org> X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3w2Pbv4LmCz9sCZ for <patchwork-incoming@ozlabs.org>; Tue, 11 Apr 2017 21:15:23 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754690AbdDKLPW (ORCPT <rfc822;patchwork-incoming@ozlabs.org>); Tue, 11 Apr 2017 07:15:22 -0400 Received: from mail-sn1nam02on0063.outbound.protection.outlook.com ([104.47.36.63]:11776 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753246AbdDKLPT (ORCPT <rfc822;netdev@vger.kernel.org>); Tue, 11 Apr 2017 07:15:19 -0400 Received: from DM2PR03CA0052.namprd03.prod.outlook.com (10.141.96.51) by BN3PR03MB2273.namprd03.prod.outlook.com (10.166.74.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1019.17; Tue, 11 Apr 2017 11:15:15 +0000 Received: from BL2FFO11FD043.protection.gbl (2a01:111:f400:7c09::120) by DM2PR03CA0052.outlook.office365.com (2a01:111:e400:2428::51) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1019.17 via Frontend Transport; Tue, 11 Apr 2017 11:15:15 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BL2FFO11FD043.mail.protection.outlook.com (10.173.161.139) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1019.14 via Frontend Transport; Tue, 11 Apr 2017 11:15:15 +0000 Received: from b54642-OptiPlex-3020.ap.freescale.net (b54642-OptiPlex-3020.ap.freescale.net [10.192.242.47]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id v3BBF8NC001129; Tue, 11 Apr 2017 04:15:13 -0700 From: Fugang Duan <fugang.duan@nxp.com> To: <davem@davemloft.net> CC: <netdev@vger.kernel.org>, <bhutchings@solarflare.com>, <stephen@networkplumber.org>, <fugang.duan@nxp.com> Subject: [PATCH net-next 1/6] net: fec: add return value check after calling .of_property_read_u32() Date: Tue, 11 Apr 2017 19:13:03 +0800 Message-ID: <1491909188-8971-2-git-send-email-fugang.duan@nxp.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1491909188-8971-1-git-send-email-fugang.duan@nxp.com> References: <1491909188-8971-1-git-send-email-fugang.duan@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131363829153648907; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39380400002)(39850400002)(39840400002)(39860400002)(39450400003)(39410400002)(39400400002)(2980300002)(1109001)(1110001)(339900001)(189002)(199003)(9170700003)(104016004)(356003)(305945005)(5660300001)(38730400002)(86362001)(4326008)(5003940100001)(189998001)(97736004)(110136004)(85426001)(47776003)(53936002)(48376002)(8676002)(2906002)(81166006)(8656002)(2950100002)(8936002)(50226002)(50466002)(6916009)(6666003)(2351001)(36756003)(77096006)(76176999)(105606002)(106466001)(50986999)(33646002)(54906002)(15760500002)(142923001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR03MB2273; H:az84smr01.freescale.net; FPR:; SPF:Fail; MLV:ovrnspm; MX:1; A:1; PTR:InfoDomainNonexistent; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD043; 1:BEXsbms16O4gqZW6rXVY59Fjiv2wYBDtuG2excMkEV5w3S9qbNqpq+whJACno007tqhaNEdu6kaT30PKuocXEEdMEvLQwbhMOSGEW0tqOqciTLuBNlDWx3G6w5xhIUx33HSgXngAint1vhuJEnRW68veNOdmZ0VroOlJ79ntU8ls8BRsViNE5ygcg4lDRPHyMoR7Z5TXzf/8+orVRVCsE9qtBPNEnr6APr6UYjAjTits/34KeZaW6QWZZhBolwWl+KuFVu6CF5Cng6W50VFsWMWaV5ZrttRND+4j2ZWrwP5XcrbcPJCQXbVHSvzEwXU4+nyCEEMQ0ZczPngios69ALh9on1wEIGf/kQZ4pi4zFFMj5QKUSdEscxBg6PPMaxwnsGUjM+Pp5ZkSIWM+CijxDb7vN+xXRBFvZ4cRkWq3+JXyXmdOjGZTTGvhKS/kbTQ/PxInHhhyFohqTGFS+ekOuv7hdQp3FludFl+pu4Lv9s/2f1voa7hhxXH3vK9kW5EcB+E+3BzyDimOgunFZPvbsIcoh6Q7FoP8l1rNchQCdyPne1NjjXY/TyGl61rQ5EkK4FUZuJqJ5DVDZE4hAREU8Zzk+yFAJU/CoyoYaqOrnMkriOpnHK3s24Eu1b9o+WLBzEcpxipVen/qxM8M8FAlnprFeNM/Vc5lX/hDfyeFBinvDDY+gh5yyD/FB7EtFMQcvmW5DXniX2jCKp7445Fg4JhXtJmgIoYdPO6mRvgcdA= MIME-Version: 1.0 Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: fbd34466-8c88-4b07-d10b-08d480cc0780 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030255120)(201703131430075)(201703131517081); SRVR:BN3PR03MB2273; X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2273; 3:/k8eZAp4fCncp3FnX3rCq6teM7Zrh8qnfn5geq3QSJTnZ4CsiiIinbLr0QzIUVw+utzSgca/iT9q9CJiHYxYqz2PIyUL5+RvKwWnLboI9GEknA6gQQYjyZ6dclu0fUDZCPrL+QZts5RirjmQj9j/ND5sbvb7ply34OBeVTRnG342HXiAk1zE6zwpgWk/1dkgfCMNQPYZOvz+j1or7v8y32roPLbQLTFau+raMq2ayLC/jlrWdQ6YSFhmJfloapp5CbQENAWw8NMDL/qaSC5TvSs6vfL31Nqgw6Kbjwh8TwdGocp9PlMvagM/51/wfB3X6rmr5RGwJkgXJT/sKw23Nxqk6z9JJvDUX11KbbRN6ECKAzfDoI5tequEKM6Letco2AFeVG1xubIHNGOdwc+JQf7Yf6snvQKWt9zcaUiDfHeSKWklsE24chX6dr5hzElyLjr0kdN2xaFiYVXkR70znQ==; 25:zEHp7umZZyTI7aFKd8ppN38NLG19OuayOpVHho+em94sYx6i3vCet5sEd1925ZrmMERNskxq+4s+clYSDAaljnSnemr0MseSP/0iYLO1sXtEruvye9NcfIS+R5RPD5srXPuE7d5Cu63XV2hC27+4z/A8FysQNfvS0FehV25uL+1a1Rn9JdV3HFTf54GDpbrfIsTmMUzHwhGD/w0od4cAYI8gmN1SRvVaDa/nXL7iYH/ZnjdhdZ7zvLwgczSskRUqhlv/GQ/Xp+g1nrRUaVcOFnvyysJbSzMfXHwp48PpBIvY0V46PKI5RzHdvJGbKuV/3EXIuo8bHs9Mh9mYPkhdrpY5decTOeriVNZYhlNIwSDGiW2goyfkxxpkOf/AnrL8YPgKsylSpwY9m5YFqmrYme3XqbZMu4cI1aihqNSBpXVhz7IyZrlCDaJXYO5oKu+f0j+TfahUPHYVBo8SF9sKhg== X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2273; 31:OCTtID8bImp482B+tQOA0CHaRCjvzzc4t4a2tHjMi3YvbDN2GJl3UcqhEV9dIj1lpSXrxuLcpQSDaYBr/XM4ftjWy7JfG/V7ed8wdA8Qz/7KIzOJiLQjwM6R4B2dzc0FbwVgMKSxnYIDiZbeCA657c++96R8V3Ly3bm14CIYPv7Er3uzrY+k+ii0zv1GkQqk78IMIklbrVhCZZ0RSqOtPLZetQodKdFqc3D5dVGHkDi0R37MUtnVWrV2hmMivQBDhy1tgE/9OR3WrVkNG28RLQ== X-Microsoft-Antispam-PRVS: <BN3PR03MB2273ECE493E13D310CA87104FF000@BN3PR03MB2273.namprd03.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(601004)(2401047)(13015025)(8121501046)(5005006)(13017025)(13024025)(13023025)(13018025)(93006095)(93001095)(10201501046)(3002001)(6055026)(6096035)(20161123563025)(20161123561025)(201703131430075)(201703131448075)(201703131433075)(201703161259075)(20161123556025)(20161123565025); SRVR:BN3PR03MB2273; BCL:0; PCL:0; RULEID:(400006); SRVR:BN3PR03MB2273; X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2273; 4:87YvItc4/KyK6s6lXIbW91BSM4l6vqjlUyz+r4/5veut2xwTDTgJthbrRSBan3Q1qF7Pf+Q1hIwp2k4kjR6oesF1bFvKsu9uik0yV3N/8J14fCBynyweelq/4LIqEsvqMcrsQmqGZf40tPSzC5d+4IYqaERuJK60MJlXvhewX70GVOvM9vGlW+YjvIeooi4yzNxfxqTsHL+SJT2USPS26SatSSajzDO1jQkeOmtCHgFG/ZivwGULevR2ipFZLhEOHKBCtl+xhrarOtkznsa2Jy4UypWoMK+rteqpbI6r1HC5NKCgj6Wcfq+O2G0Z8FbOi613rUCPlQx4YXwFWgkdKxhE9CGuDLygofqFOxvUOUMlHQbZQ9yxFCbsORMiSbG4r3v/WEAOr0nqalVzGMB/8bSu5CJs1fOgvqdHE2/Q6+MlADwxAth2xJsyY4oyvvcAL2xjSBEQMcJC0Az44/tvBnnodeANvNJn25CSjmdkmr0+GBDW+8oNhygfG1p/B2CUYz6ZMCpzma2f3ZbYDDeLdpJJry93Zc0PMs03OQvIgMny6myApiG/9hpvn5anWvjragkypiYtuHAOfAU4cxr9v4SS/ZmLdSDaWLgltMQ4Ot3Qs9GZI4nbLkqliBNvp3mu1ZFHD8XppcKtEis1JiFAP+Cv5FMYp17qmW7ElplwCFR/dYFiomL/G0vsMEYD/7SAfZ8VO3RxuhJgORNoNLyK2T/npvaJ+02YSEo2rXkv3XX6WxakNlynK6i6epxRPelszeKTZLQSDD+nWX9xamAHOXLLek/3979hbvalmWjVbs+i5J5zTbBUR/pRBV48X/ZBS6dWvUZ1Qr2hurolj8BZGh+J7NDG6IetobOiEiE4ZsAmDzYXiozHs5LJGhQ2SAEsPOFP8FkZPyjAA7vtQyr4vg== X-Forefront-PRVS: 0274272F87 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR03MB2273; 23:MW6GUzDCOZiH0JCG5cCFAlvHJwPlcB5uI4GltfkfH?= =?us-ascii?Q?WMJeXA8GwFp2q8dLEA/V0H8TPCZt1mrt3Bm61+tvJs0daA0V6okP3ve8dg/T?= =?us-ascii?Q?GFnUWK6pd8OoYhL8Vgouekc3pbFzmGc/GBgXOZOPIXrQNajPpAM20T4E+VOA?= =?us-ascii?Q?2Rqz8POSW8UbJe9JbxZvVyIYbCR3SyLDBYX80RVA0O38awomYH2paalPTp1D?= =?us-ascii?Q?IypuiiUn3W+pHJHVW5FwZ5uAVFO2NeKqH2Tnn4VJXQK+uhlOj6qaw9VVDVqn?= =?us-ascii?Q?RgMjjFRuAF9eeN+DXvIsWubWHvOnyHeZXqzGxdlaV3wq+oynEXrA23MSaYBS?= =?us-ascii?Q?o0//FKksRD1sQcCsUHQ+++mTfDM2ulb5LwoJy4tnsx1c3Z4t1lEHPRYQbIUr?= =?us-ascii?Q?Op/a8SHU6rD3h2g7BEKGCxdNdXNm1PfT/FJjv3XMzD30OKnzmqMwDFcy4LwX?= =?us-ascii?Q?6/0YSX7rClT7SyB2tdTUyRDJAxGnDlc8e+OayO3iYrMv5ZkMUiS0xp/Hcyla?= =?us-ascii?Q?V2OSNluQKL1WXL/5rmJR8QSaqIeUlM9gOKfVPStFQzknUulGqYuBhkw+BgDH?= =?us-ascii?Q?tqoBjFGi24Q9Xki9Fai0dNkaTzKtyzRqzl2Hlh9WSUpIR+kLlJ8rBRcdPS/3?= =?us-ascii?Q?7zAUHYfQhcDCD518wwH0nvstPtU1xE/vqoFXbUZ1fFkSn6zH56CUxYcN3W/I?= =?us-ascii?Q?S/c8KVil5/O8y2MbFn0yP4Y+rUeZbsLw8nDz/KrkN2zcBK4LB9qNfgb6DThy?= =?us-ascii?Q?4uancdeeQ5Cn8l3tCGVE3QnTEMyQq8fCXvejDMBq9R7q+mOTY0TFN5XBcIss?= =?us-ascii?Q?6m10lTqq4UWpiL09bNnb8uqqIgGw08rqQjb3QekdJP0HMWPNmAquTyUgdBFp?= =?us-ascii?Q?gRGujLbDKw4heJCc99DvNDCf0XXHtjGSGxs0wgELhrdfE0BCJafjWR3Kcbrl?= =?us-ascii?Q?G6ECaxYuPSULYJiJ50Mooi7q8W0kDQZOjrYXJqVm7kVgOSnMWdVBfSgDVBgf?= =?us-ascii?Q?wQ4Lu5KQIh5AlarTfc5XOn4S9q/mD3WoBn4vL23ho6j0VKQLrkT6PY7Kmakf?= =?us-ascii?Q?k0OIJ90aLblz2eSaUR0rEqPahEFpuHaPQwroVJ2bXfQ8LDSKSgVdeYCIzCHm?= =?us-ascii?Q?Rd17RLgUg6yum5pJCsFCvIsa8fiICstb2J8ytunEf0UfcGD2cfBCjVtZxbyf?= =?us-ascii?Q?43Ivqan1QA2qHjiUaNEBon8EXPMmQdlBRzMtJMO+nyAh+RfAfBHddu47PN85?= =?us-ascii?Q?6HVb21gynqY7hM/PgWQtXi0fRcirjNOC13ebGBgRDpO/JZrXSb3wLIhJgjmD?= =?us-ascii?B?QT09?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2273; 6:jCcRE8HFEg/i+GB8bA0CqcVcoQDL8mgqO7AWtDJeXYggs0ZvQXLAiBDYO7PmCTNd+xQFAiZanx1j7uk27BjA9/daEauY6IW/TaTrYPauXmupv01X89K+nVxQVtSc1LPxttCwzBBqY1ZmqyURxLhOhUiczqpoKmDhgwXqr17ACEIKzKxIaVrWgF91CGWGownqsBVmd+r8iQ4nehmrUHXykm6Vf2dcW6QoyGcWiiy+Ck+cM9hiLe+kr3WJTSKJDHcgaUnp/WcALcwKKrhdsNaUzz9tHknC8MqZRni9ZlZOzeiyn0e2aXdyXTbvfkWa6kdYIDl5t+k5NOO6KoOt2xm8ZdAwJhpExjhB5bLyftAmWi4n35rFlLECj4YpLbLSY+MimjFtq/5w2DNPk6rLr7wYBHasaYo0b+qEZ2WAYJITDtwiKx806PYd9d+R7K9pVRyVOZTQL9DBaNTGCkuSEnTcHw==; 5:LXjUWMwUmDyRvPiXNfQxhf7hnhFsra5NYlSgM3zy83p/veeubPWMLW/944lhVsxqysjbhGdLjV0lIKVUz6BT5zYjAd/NReDTVjn0gjnsfj39qFjHHbojjJZ2b9e8toeInKolQHAAtZehr3wK3IIB+PreAttTi8pgk3rRTrshYaZPjzOAmDrYt7rlQOJhQYjY; 24:x9L7hKfD/VlabMPLbvttIwpwF5rYqcXLyzMyVFf+okcyrVUOCbmVw6hwlq8jOq4fNFzgsjTv3+lZFclTtZ2RPpgp38xvVaJmCbQUE3X527A= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN3PR03MB2273; 7:n2MI+VRtu6NgW2gAwXYxu/UGUkAzARTXwuiWAMfD+7WAiuB3zkzWI8/XEI+/kwI60CRfcYK4+Cyx/G1irqH8weMDkVGpiuo+OeVmqOfQNQYSaId6eNzxvcryDD79hDSdC8eK4zVkTL2qwY6muvhcOkmTLqPms8SgF3DWIYQJDKUZsME1QLfjoI2+pHiiSPSSMSzQDnqUNnxOVa+93DUKb8zQrTdoQE97lgctMwasuvsUk28L2o4GT4cjWKlvf6ZIlM0/yv5kWxfC4tYejptiqknZH4n/VKlXea/gA2L4vtNCATAL3Ghz75MukZ2q2Iqah4gpBRAy+XlvmdjRHUPNYw== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2017 11:15:15.1464 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB2273 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: <netdev.vger.kernel.org> X-Mailing-List: netdev@vger.kernel.org |
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 91a1664..886a9c9 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -3197,9 +3197,9 @@ static void fec_reset_phy(struct platform_device *pdev) if (!np) return; - of_property_read_u32(np, "phy-reset-duration", &msec); + err = of_property_read_u32(np, "phy-reset-duration", &msec); /* A sane reset duration should not be longer than 1s */ - if (msec > 1000) + if (!err && msec > 1000) msec = 1; phy_reset = of_get_named_gpio(np, "phy-reset-gpios", 0);
Add return value check after calling .of_property_read_u32() to avoid the warning reported by coverity. Signed-off-by: Fugang Duan <fugang.duan@nxp.com> --- drivers/net/ethernet/freescale/fec_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)