From patchwork Mon Apr 10 15:34:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniele Palmas X-Patchwork-Id: 749088 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3w1vVn6rJYz9sNg for ; Tue, 11 Apr 2017 01:39:13 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="PwTfwLOh"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754969AbdDJPin (ORCPT ); Mon, 10 Apr 2017 11:38:43 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:33852 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754765AbdDJPe5 (ORCPT ); Mon, 10 Apr 2017 11:34:57 -0400 Received: by mail-wm0-f67.google.com with SMTP id x75so10299432wma.1; Mon, 10 Apr 2017 08:34:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CoCEExCBKvsI/2jwOFGyizMD9NRWsAA+Vcf/84wJW0o=; b=PwTfwLOhiStuPuqeclpEUMfS6Ur8Pbvoig2/+EqaBHCp9ns6CeU65RyNqYFYnhGj0l S3iafhCxqJ2VuGzD2jUl6wFnp9+kHsI/lFr/lEcIWIVzxD4y8Hx8a8GvD2xyhcPvo5mq ictRoSCyHh/CRq3g/Sj24Z7PqfS+ebXcxze5XC9dmuin9cnFojvCt3jv/rdpvSnH6iW5 IrqKAf3pQpS1QRAwjJaSf8LSqvKBXSqTqmAuSK7Wd032stcD2vb9skEsQ5K6+gnt2J2R aO2is47nCI64EDcYuIzN4mn5Lk3g57EBTuA5pT7whiROuat8oaa+3JD/oNmfIOzugPCX JMkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CoCEExCBKvsI/2jwOFGyizMD9NRWsAA+Vcf/84wJW0o=; b=iiruVdJTajL4HU6frbVLmzjP4JC/X8r+ySF1jnzMDETq53sadV9DxR/cW7Ff0sn9NZ eQ4eVSznaHt69VrXpH7pxvAfnyKS38CCSnIQ7P7v9xkvK/+4lEgIDKE9jC3mx0y1waKB 47gE+rAkyi2TR6Kwgp78yTkScKxYphVgr2QQk06TSEU/9DqV6gQROmdP0s19qJ/jpbWO 2FPDOVQneLsCTyqqxJ8CrxIg6hoXjcI8sxVleBncwFHX7sX96UIxPylwXwR3V2ZgnrA9 27xTnhk1w3T91LvaVbasu7qQNm8TAcahPbAC4SMzGr6s5+yAsTyouJYJJO3ITxsTLkKb qgnA== X-Gm-Message-State: AN3rC/7Jfdqr2tJk7BFcjoQm+Tp2yMJZjt4pSLDYUOSpxnzH7LXtVLdi BsNlqD2YKBSjLQ== X-Received: by 10.28.195.7 with SMTP id t7mr9583882wmf.62.1491838486190; Mon, 10 Apr 2017 08:34:46 -0700 (PDT) Received: from localhost.localdomain ([213.205.6.118]) by smtp.gmail.com with ESMTPSA id e21sm10778722wma.5.2017.04.10.08.34.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 10 Apr 2017 08:34:45 -0700 (PDT) From: Daniele Palmas To: =?UTF-8?q?Bj=C3=B8rn=20Mork?= Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org, Daniele Palmas Subject: [PATCH 1/1] drivers: net: usb: qmi_wwan: add QMI_QUIRK_SET_DTR for Telit PID 0x1201 Date: Mon, 10 Apr 2017 17:34:23 +0200 Message-Id: <1491838463-20299-1-git-send-email-dnlplm@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Telit LE920A4 uses the same pid 0x1201 of LE920, but modem implementation is different, since it requires DTR to be set for answering to qmi messages. This patch replaces QMI_FIXED_INTF with QMI_QUIRK_SET_DTR: tests on LE920 have been performed in order to verify backward compatibility. Signed-off-by: Daniele Palmas --- Hi Bjørn, as a side note in latest kernels I had troubles with qmi devices (e.g. I/O error when using qmicli). I found your suggestion in libqmi mailing list to revert commit 833415a3e781a26fe480a34d45086bdb4fe1e4c0 cdc-wdm: fix "out-of-sync" due to missing notifications and this seems to work. Regards, Daniele --- drivers/net/usb/qmi_wwan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index 156f7f8..2474618 100644 --- a/drivers/net/usb/qmi_wwan.c +++ b/drivers/net/usb/qmi_wwan.c @@ -908,7 +908,7 @@ static const struct usb_device_id products[] = { {QMI_FIXED_INTF(0x2357, 0x9000, 4)}, /* TP-LINK MA260 */ {QMI_QUIRK_SET_DTR(0x1bc7, 0x1040, 2)}, /* Telit LE922A */ {QMI_FIXED_INTF(0x1bc7, 0x1200, 5)}, /* Telit LE920 */ - {QMI_FIXED_INTF(0x1bc7, 0x1201, 2)}, /* Telit LE920 */ + {QMI_QUIRK_SET_DTR(0x1bc7, 0x1201, 2)}, /* Telit LE920, LE920A4 */ {QMI_FIXED_INTF(0x1c9e, 0x9b01, 3)}, /* XS Stick W100-2 from 4G Systems */ {QMI_FIXED_INTF(0x0b3c, 0xc000, 4)}, /* Olivetti Olicard 100 */ {QMI_FIXED_INTF(0x0b3c, 0xc001, 4)}, /* Olivetti Olicard 120 */