Patchwork [U-Boot] Blackfin: bf518f-ezbrd: don't require SPI logic all the time

login
register
mail settings
Submitter Mike Frysinger
Date Dec. 9, 2010, 10:40 a.m.
Message ID <1291891215-12374-1-git-send-email-vapier@gentoo.org>
Download mbox | patch
Permalink /patch/74873/
State Superseded
Headers show

Comments

Mike Frysinger - Dec. 9, 2010, 10:40 a.m.
Only the first run of boards had a ksz switch on it, so if building for a
newer silicon rev or SPI is disabled, don't bother checking for the ksz.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 board/bf518f-ezbrd/bf518f-ezbrd.c |   30 ++++++++++++++++++++++--------
 1 files changed, 22 insertions(+), 8 deletions(-)
Wolfgang Denk - Dec. 18, 2010, 11:19 p.m.
Dear Mike Frysinger,

In message <1291891215-12374-1-git-send-email-vapier@gentoo.org> you wrote:
> Only the first run of boards had a ksz switch on it, so if building for a
> newer silicon rev or SPI is disabled, don't bother checking for the ksz.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
...
> +	if (!switch_is_alive)
>  		return -1;
> +	else
> +		return 0;
> +}

Drop the else, and unindent the return 0;

> +int board_eth_init(bd_t *bis)
> +{
> +	if (KSZ_POSSIBLE)
> +		if (board_ksz_init() == -1)
> +			return 0;

Braces needed for multiline statements.

Best regards,

Wolfgang Denk

Patch

diff --git a/board/bf518f-ezbrd/bf518f-ezbrd.c b/board/bf518f-ezbrd/bf518f-ezbrd.c
index ff1ac4c..4bd02ee 100644
--- a/board/bf518f-ezbrd/bf518f-ezbrd.c
+++ b/board/bf518f-ezbrd/bf518f-ezbrd.c
@@ -57,6 +57,13 @@  static void board_init_enetaddr(uchar *mac_addr)
 	eth_setenv_enetaddr("ethaddr", mac_addr);
 }
 
+/* Only the first run of boards had a KSZ switch */
+#if defined(CONFIG_BFIN_SPI) && __SILICON_REVISION__ == 0
+# define KSZ_POSSIBLE 1
+#else
+# define KSZ_POSSIBLE 0
+#endif
+
 #define KSZ_MAX_HZ    5000000
 
 #define KSZ_WRITE     0x02
@@ -109,17 +116,16 @@  static int ksz8893m_reset(struct spi_slave *slave)
 	return ret;
 }
 
-int board_eth_init(bd_t *bis)
+static int board_ksz_init(void)
 {
-	static bool switch_is_alive = false, phy_is_ksz = true;
-	int ret;
+	static bool switch_is_alive = false;
 
 	if (!switch_is_alive) {
 		struct spi_slave *slave = spi_setup_slave(0, 1, KSZ_MAX_HZ, SPI_MODE_3);
 		if (slave) {
 			if (!spi_claim_bus(slave)) {
-				phy_is_ksz = (ksz8893m_reg_read(slave, KSZ_REG_CHID) == 0x88);
-				ret = phy_is_ksz ? ksz8893m_reset(slave) : 0;
+				bool phy_is_ksz = (ksz8893m_reg_read(slave, KSZ_REG_CHID) == 0x88);
+				int ret = phy_is_ksz ? ksz8893m_reset(slave) : 0;
 				switch_is_alive = (ret == 0);
 				spi_release_bus(slave);
 			}
@@ -127,10 +133,18 @@  int board_eth_init(bd_t *bis)
 		}
 	}
 
-	if (switch_is_alive)
-		return bfin_EMAC_initialize(bis);
-	else
+	if (!switch_is_alive)
 		return -1;
+	else
+		return 0;
+}
+
+int board_eth_init(bd_t *bis)
+{
+	if (KSZ_POSSIBLE)
+		if (board_ksz_init() == -1)
+			return 0;
+	return bfin_EMAC_initialize(bis);
 }
 #endif