Disable CONFIG_HVC_UDBG on ppc64el

Submitted by Breno Leitao on April 7, 2017, 7:11 p.m.

Details

Message ID 1491592307-16596-1-git-send-email-leitao@debian.org
State New
Headers show

Commit Message

Breno Leitao April 7, 2017, 7:11 p.m.
From: Breno Leitao <breno.leitao@gmail.com>

BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1680888

Disabling CONFIG_HVC_UDBG on ppc64el config because it is not
required on production environment (fake hypervisor console debug), and
it is causing some issues that are still being investigated.

Signed-off-by: Breno Leitao <breno.leitao@gmail.com>

Comments

Tim Gardner April 7, 2017, 9:03 p.m.
Zesty only ?
Breno Leitao April 8, 2017, 9:13 p.m.
Hi Tim,

On Fri, Apr 07, 2017 at 10:03:58PM +0100, Tim Gardner wrote:
> Zesty only ?

No, I think we can disable it on yakkety also, please.

Thanks,
Breno
Seth Forshee April 10, 2017, 4:46 p.m.
On Fri, Apr 07, 2017 at 04:11:47PM -0300, Breno Leitao wrote:
> From: Breno Leitao <breno.leitao@gmail.com>
> 
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1680888
> 
> Disabling CONFIG_HVC_UDBG on ppc64el config because it is not
> required on production environment (fake hypervisor console debug), and
> it is causing some issues that are still being investigated.
> 
> Signed-off-by: Breno Leitao <breno.leitao@gmail.com>

Acked-by: Seth Forshee <seth.forshee@canonical.com>
Seth Forshee April 10, 2017, 4:54 p.m.
On Fri, Apr 07, 2017 at 04:11:47PM -0300, Breno Leitao wrote:
> From: Breno Leitao <breno.leitao@gmail.com>
> 
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1680888
> 
> Disabling CONFIG_HVC_UDBG on ppc64el config because it is not
> required on production environment (fake hypervisor console debug), and
> it is causing some issues that are still being investigated.
> 
> Signed-off-by: Breno Leitao <breno.leitao@gmail.com>

Applied to zesty master-next with subject changed to "UBUNTU: [Config]
Disable CONFIG_HVC_UDBG on ppc64el."
Thadeu Lima de Souza Cascardo April 25, 2017, 3:49 p.m.
On Sat, Apr 08, 2017 at 06:13:05PM -0300, Breno Leitao wrote:
> Hi Tim,
> 
> On Fri, Apr 07, 2017 at 10:03:58PM +0100, Tim Gardner wrote:
> > Zesty only ?
> 
> No, I think we can disable it on yakkety also, please.
> 
> Thanks,
> Breno
> 

This doesn't apply to yakkety, as yakkety still has the annotation for
powerpc. Since this has been on for a long time on powerpc, I would
rather keep it. More so, as you are disabling this on ppc64el for issues
you are still investigating. Can you send another patch for Yakkety?

Thanks.
Cascardo.
Breno Leitao April 26, 2017, 2:30 p.m.
Hi Cascardo,

On Tue, Apr 25, 2017 at 12:49:09PM -0300, Thadeu Lima de Souza Cascardo wrote:
> On Sat, Apr 08, 2017 at 06:13:05PM -0300, Breno Leitao wrote:
> > Hi Tim,
> > 
> > On Fri, Apr 07, 2017 at 10:03:58PM +0100, Tim Gardner wrote:
> > > Zesty only ?
> > 
> > No, I think we can disable it on yakkety also, please.
> > 
> > Thanks,
> > Breno
> > 
> 
> This doesn't apply to yakkety, as yakkety still has the annotation for
> powerpc. Since this has been on for a long time on powerpc, I would
> rather keep it. More so, as you are disabling this on ppc64el for issues
> you are still investigating. Can you send another patch for Yakkety?
 
Maybe we do not need this fix on Yakkety anymore, let me explain.
 
In the past, we were using Yakkety just to be able to install our POWER9
machines and then upgrade to the HWE kernel (4.10), since 4.10 is the
kernel we are caring about for these new features. Since this was a
problem we were facing during install, we requested this fix for Yakkety
also.

Now I finally have a 16.04.3 internal install image, thus, Yaketty
importance is decreasing for POWER9 features. 

Since this is a POWER9 "request", having it on Zesty only should be
fine.

Thanks,
Breno

Patch hide | download patch | download mbox

diff --git a/debian.master/config/annotations b/debian.master/config/annotations
index f511ec13a71e..22c169853f78 100644
--- a/debian.master/config/annotations
+++ b/debian.master/config/annotations
@@ -630,7 +630,7 @@  CONFIG_HVC_RTAS                                 policy<{'ppc64el': 'y'}>
 CONFIG_HVC_IUCV                                 policy<{'s390x': 'y'}>
 CONFIG_HVC_XEN                                  policy<{'amd64': 'y', 'arm64': 'y', 'i386': 'y'}>
 CONFIG_HVC_XEN_FRONTEND                         policy<{'amd64': 'y', 'arm64': 'y', 'i386': 'y'}>
-CONFIG_HVC_UDBG                                 policy<{'ppc64el': 'y'}>
+CONFIG_HVC_UDBG                                 policy<{'ppc64el': 'n'}>
 CONFIG_HVC_DCC                                  policy<{'arm64': 'n', 'armhf': 'n'}>
 CONFIG_HVCS                                     policy<{'ppc64el': 'm'}>
 CONFIG_VIRTIO_CONSOLE                           policy<{'amd64': 'y', 'arm64': 'y', 'armhf': 'y', 'i386': 'y', 'ppc64el': 'y', 's390x': 'y'}>
@@ -11117,3 +11117,5 @@  CONFIG_QCOM_QDF2400_ERRATUM_0065		policy<{'arm64': 'y'}>
 CONFIG_ARM64_ERRATUM_843419			mark<ENFORCED> note<LP#1647793>
 CONFIG_ARM64_ERRATUM_858921			mark<ENFORCED> note<LP#1675509>
 CONFIG_QCOM_QDF2400_ERRATUM_0065		mark<ENFORCED> note<LP#1672486>
+#
+CONFIG_HVC_UDBG				mark<ENFORCED> note<LP#1680888>
diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
index b4e264b1d98e..8a48079c1b7b 100644
--- a/debian.master/config/config.common.ubuntu
+++ b/debian.master/config/config.common.ubuntu
@@ -3419,7 +3419,7 @@  CONFIG_HVC_IUCV=y
 CONFIG_HVC_OLD_HVSI=y
 CONFIG_HVC_OPAL=y
 CONFIG_HVC_RTAS=y
-CONFIG_HVC_UDBG=y
+# CONFIG_HVC_UDBG is not set
 CONFIG_HVC_XEN=y
 CONFIG_HVC_XEN_FRONTEND=y
 CONFIG_HV_PERF_CTRS=y