| Message ID | 20170407143100.21536-1-niklass@axis.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
Hello! On 04/07/2017 05:30 PM, Niklas Cassel wrote: > From: Niklas Cassel <niklas.cassel@axis.com> > > The hardware has a LPI interrupt. > There is already code in the stmmac driver to parse and handle the > interrupt. However, this information was missing from the DT binding. > > Signed-off-by: Niklas Cassel <niklas.cassel@axis.com> > --- > Documentation/devicetree/bindings/net/stmmac.txt | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/stmmac.txt b/Documentation/devicetree/bindings/net/stmmac.txt > index f652b0c384ce..8977abc266ac 100644 > --- a/Documentation/devicetree/bindings/net/stmmac.txt > +++ b/Documentation/devicetree/bindings/net/stmmac.txt > @@ -8,8 +8,8 @@ Required properties: > that services interrupts for this device > - interrupts: Should contain the STMMAC interrupts > - interrupt-names: Should contain the interrupt names "macirq" > - "eth_wake_irq" if this interrupt is supported in the "interrupts" > - property > + "eth_wake_irq" if this interrupt is supported in the "interrupts property Missed closing quote? > + "eth_lpi" if this interrupt is supported in the "interrupts" property > - phy-mode: See ethernet.txt file in the same directory. > - snps,reset-gpio gpio number for phy reset. > - snps,reset-active-low boolean flag to indicate if phy reset is active low. [...] MBR, Sergei
On 04/07/2017 06:48 PM, Sergei Shtylyov wrote: > Hello! > > On 04/07/2017 05:30 PM, Niklas Cassel wrote: > >> From: Niklas Cassel <niklas.cassel@axis.com> >> >> The hardware has a LPI interrupt. >> There is already code in the stmmac driver to parse and handle the >> interrupt. However, this information was missing from the DT binding. >> >> Signed-off-by: Niklas Cassel <niklas.cassel@axis.com> >> --- >> Documentation/devicetree/bindings/net/stmmac.txt | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/stmmac.txt b/Documentation/devicetree/bindings/net/stmmac.txt >> index f652b0c384ce..8977abc266ac 100644 >> --- a/Documentation/devicetree/bindings/net/stmmac.txt >> +++ b/Documentation/devicetree/bindings/net/stmmac.txt >> @@ -8,8 +8,8 @@ Required properties: >> that services interrupts for this device >> - interrupts: Should contain the STMMAC interrupts >> - interrupt-names: Should contain the interrupt names "macirq" >> - "eth_wake_irq" if this interrupt is supported in the "interrupts" >> - property >> + "eth_wake_irq" if this interrupt is supported in the "interrupts property > > Missed closing quote? Thanks for pointing it out. Will send a v2. > >> + "eth_lpi" if this interrupt is supported in the "interrupts" property >> - phy-mode: See ethernet.txt file in the same directory. >> - snps,reset-gpio gpio number for phy reset. >> - snps,reset-active-low boolean flag to indicate if phy reset is active low. > [...] > > MBR, Sergei >
diff --git a/Documentation/devicetree/bindings/net/stmmac.txt b/Documentation/devicetree/bindings/net/stmmac.txt index f652b0c384ce..8977abc266ac 100644 --- a/Documentation/devicetree/bindings/net/stmmac.txt +++ b/Documentation/devicetree/bindings/net/stmmac.txt @@ -8,8 +8,8 @@ Required properties: that services interrupts for this device - interrupts: Should contain the STMMAC interrupts - interrupt-names: Should contain the interrupt names "macirq" - "eth_wake_irq" if this interrupt is supported in the "interrupts" - property + "eth_wake_irq" if this interrupt is supported in the "interrupts property + "eth_lpi" if this interrupt is supported in the "interrupts" property - phy-mode: See ethernet.txt file in the same directory. - snps,reset-gpio gpio number for phy reset. - snps,reset-active-low boolean flag to indicate if phy reset is active low. @@ -152,8 +152,8 @@ Examples: compatible = "st,spear600-gmac"; reg = <0xe0800000 0x8000>; interrupt-parent = <&vic1>; - interrupts = <24 23>; - interrupt-names = "macirq", "eth_wake_irq"; + interrupts = <24 23 22>; + interrupt-names = "macirq", "eth_wake_irq", "eth_lpi"; mac-address = [000000000000]; /* Filled in by U-Boot */ max-frame-size = <3800>; phy-mode = "gmii";