diff mbox

[0/5,V2] Firewire networking assorted fixes

Message ID 1291858961.3331.4.camel@maxim-laptop
State Not Applicable, archived
Delegated to: David Miller
Headers show

Commit Message

Maxim Levitsky Dec. 9, 2010, 1:42 a.m. UTC 
On Wed, 2010-12-08 at 05:32 +0200, Maxim Levitsky wrote:
> On Mon, 2010-11-29 at 04:09 +0200, Maxim Levitsky wrote:
> > Hi,
> > 
> > This is updated version of the patches.
> > I updated the changelogs, addressed comments on patch #2
> > 
> > Best regards,
> > 	Maxim Levitsky
> > 
> 
> Today I have achieved the ultimate goal,
> full support of firewire networking via NetworkManager.
> 
> Currently it is patched with few hacks but much less that I expected.
> 
> I also had to patch dhclient as it unfortunately sends raw packets
> together with hardware header (ethernet of course...)
> 
> I will soon clean up these hacks to turn them into patches and send to
> developers.
> 
> The kernel side needs only the attached patch.
> It adds the link state detection to firewire-net
> 
> Just for fun, this is screenshot that proves that NM works:
> http://img210.imageshack.us/img210/6019/screenshotdjk.png

And cleaned up patches that add the support attached.
Will send these to NM and dhcp ML soon.

Best regards,
	Maxim Levitsky
diff mbox

Patch

From 93129738ca8450899e416420f630aee17c8301d5 Mon Sep 17 00:00:00 2001
From: Maxim Levitsky <maximlevitsky@gmail.com>
Date: Thu, 9 Dec 2010 00:30:55 +0200
Subject: [PATCH] NM: allow use of IPV4 over firewire

Don't ignore these devices since NM
works just fine with them iff the dhclient
works.
Patches are posted to make it work with
firewire networking link

Signed-off-by: Maxim Levitsky <maximlevitsky@gmail.com>
---
 src/nm-udev-manager.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/src/nm-udev-manager.c b/src/nm-udev-manager.c
index ff0ef68..3cd2970 100644
--- a/src/nm-udev-manager.c
+++ b/src/nm-udev-manager.c
@@ -408,7 +408,9 @@  net_add (NMUdevManager *self, GUdevDevice *device)
 	g_return_if_fail (device != NULL);
 
 	etype = g_udev_device_get_sysfs_attr_as_int (device, "type");
-	if (etype != 1) {
+
+	/* firewire devices are similiar to ethernet, so allow them too */
+	if (etype != 1 && etype != 24) {
 		nm_log_dbg (LOGD_HW, "ignoring interface with type %d", etype);
 		return; /* Not using ethernet encapsulation, don't care */
 	}
-- 
1.7.1