diff mbox

powerpc/mm: Remove reduntant initmem information from log

Message ID 20170407065311.8599-1-khandual@linux.vnet.ibm.com (mailing list archive)
State Accepted
Commit ea6145557400b38faa6b3cee946ebceed8999872
Headers show

Commit Message

Anshuman Khandual April 7, 2017, 6:53 a.m. UTC 
Generic core VM already prints these information in the log
buffer, hence there is no need for a second print. This just
removes the second print from arch powerpc NUMA init path.

Before the patch:

$dmesg | grep "Initmem"

numa: Initmem setup node 0 [mem 0x00000000-0xffffffff]
numa: Initmem setup node 1 [mem 0x100000000-0x1ffffffff]
numa: Initmem setup node 2 [mem 0x200000000-0x2ffffffff]
numa: Initmem setup node 3 [mem 0x300000000-0x3ffffffff]
numa: Initmem setup node 4 [mem 0x400000000-0x4ffffffff]
numa: Initmem setup node 5 [mem 0x500000000-0x5ffffffff]
numa: Initmem setup node 6 [mem 0x600000000-0x6ffffffff]
numa: Initmem setup node 7 [mem 0x700000000-0x7ffffffff]
Initmem setup node 0 [mem 0x0000000000000000-0x00000000ffffffff]
Initmem setup node 1 [mem 0x0000000100000000-0x00000001ffffffff]
Initmem setup node 2 [mem 0x0000000200000000-0x00000002ffffffff]
Initmem setup node 3 [mem 0x0000000300000000-0x00000003ffffffff]
Initmem setup node 4 [mem 0x0000000400000000-0x00000004ffffffff]
Initmem setup node 5 [mem 0x0000000500000000-0x00000005ffffffff]
Initmem setup node 6 [mem 0x0000000600000000-0x00000006ffffffff]
Initmem setup node 7 [mem 0x0000000700000000-0x00000007ffffffff]

After the patch:

$dmesg | grep "Initmem"

Initmem setup node 0 [mem 0x0000000000000000-0x00000000ffffffff]
Initmem setup node 1 [mem 0x0000000100000000-0x00000001ffffffff]
Initmem setup node 2 [mem 0x0000000200000000-0x00000002ffffffff]
Initmem setup node 3 [mem 0x0000000300000000-0x00000003ffffffff]
Initmem setup node 4 [mem 0x0000000400000000-0x00000004ffffffff]
Initmem setup node 5 [mem 0x0000000500000000-0x00000005ffffffff]
Initmem setup node 6 [mem 0x0000000600000000-0x00000006ffffffff]
Initmem setup node 7 [mem 0x0000000700000000-0x00000007ffffffff]

Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com>
---
Generic core VM prints the information inside free_area_init_node
function but only when CONFIG_HAVE_MEMBLOCK_NODE_MAP is enabled.
So if there are other PPC platforms which dont enable the config,
we can put the code section inside applicable platform configs
instead of removing it completely.

 arch/powerpc/mm/numa.c | 7 -------
 1 file changed, 7 deletions(-)

Comments

Michael Ellerman April 7, 2017, 12:46 p.m. UTC | #1 
Anshuman Khandual <khandual@linux.vnet.ibm.com> writes:

> Generic core VM already prints these information in the log
> buffer, hence there is no need for a second print. This just
> removes the second print from arch powerpc NUMA init path.
>
> Before the patch:
>
> $dmesg | grep "Initmem"
>
> numa: Initmem setup node 0 [mem 0x00000000-0xffffffff]
> numa: Initmem setup node 1 [mem 0x100000000-0x1ffffffff]
> numa: Initmem setup node 2 [mem 0x200000000-0x2ffffffff]
> numa: Initmem setup node 3 [mem 0x300000000-0x3ffffffff]
> numa: Initmem setup node 4 [mem 0x400000000-0x4ffffffff]
> numa: Initmem setup node 5 [mem 0x500000000-0x5ffffffff]
> numa: Initmem setup node 6 [mem 0x600000000-0x6ffffffff]
> numa: Initmem setup node 7 [mem 0x700000000-0x7ffffffff]
> Initmem setup node 0 [mem 0x0000000000000000-0x00000000ffffffff]
> Initmem setup node 1 [mem 0x0000000100000000-0x00000001ffffffff]
> Initmem setup node 2 [mem 0x0000000200000000-0x00000002ffffffff]
> Initmem setup node 3 [mem 0x0000000300000000-0x00000003ffffffff]
> Initmem setup node 4 [mem 0x0000000400000000-0x00000004ffffffff]
> Initmem setup node 5 [mem 0x0000000500000000-0x00000005ffffffff]
> Initmem setup node 6 [mem 0x0000000600000000-0x00000006ffffffff]
> Initmem setup node 7 [mem 0x0000000700000000-0x00000007ffffffff]
>
> After the patch:
>
> $dmesg | grep "Initmem"
>
> Initmem setup node 0 [mem 0x0000000000000000-0x00000000ffffffff]
> Initmem setup node 1 [mem 0x0000000100000000-0x00000001ffffffff]
> Initmem setup node 2 [mem 0x0000000200000000-0x00000002ffffffff]
> Initmem setup node 3 [mem 0x0000000300000000-0x00000003ffffffff]
> Initmem setup node 4 [mem 0x0000000400000000-0x00000004ffffffff]
> Initmem setup node 5 [mem 0x0000000500000000-0x00000005ffffffff]
> Initmem setup node 6 [mem 0x0000000600000000-0x00000006ffffffff]
> Initmem setup node 7 [mem 0x0000000700000000-0x00000007ffffffff]
>
> Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com>

Looks good.

> ---
> Generic core VM prints the information inside free_area_init_node
> function but only when CONFIG_HAVE_MEMBLOCK_NODE_MAP is enabled.
> So if there are other PPC platforms which dont enable the config,
> we can put the code section inside applicable platform configs
> instead of removing it completely.

Are there other PPC platforms which don't enable it?

...

config PPC
        ...
	select HAVE_MEMBLOCK
	select HAVE_MEMBLOCK_NODE_MAP


No.

So this should be fine for all PPC.

cheers
Michael Ellerman April 10, 2017, 10:49 p.m. UTC | #2 
On Fri, 2017-04-07 at 06:53:11 UTC, Anshuman Khandual wrote:
> Generic core VM already prints these information in the log
> buffer, hence there is no need for a second print. This just
> removes the second print from arch powerpc NUMA init path.
> 
> Before the patch:
> 
> $dmesg | grep "Initmem"
> 
> numa: Initmem setup node 0 [mem 0x00000000-0xffffffff]
> numa: Initmem setup node 1 [mem 0x100000000-0x1ffffffff]
> numa: Initmem setup node 2 [mem 0x200000000-0x2ffffffff]
> numa: Initmem setup node 3 [mem 0x300000000-0x3ffffffff]
> numa: Initmem setup node 4 [mem 0x400000000-0x4ffffffff]
> numa: Initmem setup node 5 [mem 0x500000000-0x5ffffffff]
> numa: Initmem setup node 6 [mem 0x600000000-0x6ffffffff]
> numa: Initmem setup node 7 [mem 0x700000000-0x7ffffffff]
> Initmem setup node 0 [mem 0x0000000000000000-0x00000000ffffffff]
> Initmem setup node 1 [mem 0x0000000100000000-0x00000001ffffffff]
> Initmem setup node 2 [mem 0x0000000200000000-0x00000002ffffffff]
> Initmem setup node 3 [mem 0x0000000300000000-0x00000003ffffffff]
> Initmem setup node 4 [mem 0x0000000400000000-0x00000004ffffffff]
> Initmem setup node 5 [mem 0x0000000500000000-0x00000005ffffffff]
> Initmem setup node 6 [mem 0x0000000600000000-0x00000006ffffffff]
> Initmem setup node 7 [mem 0x0000000700000000-0x00000007ffffffff]
> 
> After the patch:
> 
> $dmesg | grep "Initmem"
> 
> Initmem setup node 0 [mem 0x0000000000000000-0x00000000ffffffff]
> Initmem setup node 1 [mem 0x0000000100000000-0x00000001ffffffff]
> Initmem setup node 2 [mem 0x0000000200000000-0x00000002ffffffff]
> Initmem setup node 3 [mem 0x0000000300000000-0x00000003ffffffff]
> Initmem setup node 4 [mem 0x0000000400000000-0x00000004ffffffff]
> Initmem setup node 5 [mem 0x0000000500000000-0x00000005ffffffff]
> Initmem setup node 6 [mem 0x0000000600000000-0x00000006ffffffff]
> Initmem setup node 7 [mem 0x0000000700000000-0x00000007ffffffff]
> 
> Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/ea6145557400b38faa6b3cee946ebc

cheers
diff mbox

Patch

diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
index 9befaee..371792e 100644
--- a/arch/powerpc/mm/numa.c
+++ b/arch/powerpc/mm/numa.c
@@ -875,13 +875,6 @@  static void __init setup_node_data(int nid, u64 start_pfn, u64 end_pfn)
 	void *nd;
 	int tnid;
 
-	if (spanned_pages)
-		pr_info("Initmem setup node %d [mem %#010Lx-%#010Lx]\n",
-			nid, start_pfn << PAGE_SHIFT,
-			(end_pfn << PAGE_SHIFT) - 1);
-	else
-		pr_info("Initmem setup node %d\n", nid);
-
 	nd_pa = memblock_alloc_try_nid(nd_size, SMP_CACHE_BYTES, nid);
 	nd = __va(nd_pa);