diff mbox

[wwwdocs,v2] C++ terminology: the One Definition Rule in diagnostics

Message ID 1491512301.9159.18.camel@redhat.com
State New
Headers show

Commit Message

David Malcolm April 6, 2017, 8:58 p.m. UTC 
On Thu, 2017-04-06 at 10:44 -0600, Jeff Law wrote:
> On 03/24/2017 03:29 AM, Martin Liška wrote:
> > I would like to ping that. I'm not sure what's agreement after I
> > read
> > discussion in: https://gcc.gnu.org/ml/gcc/2017-03/msg00070.html
> > 
> > Martin Sebor may know, CC'ing him.
> Not sure if you're pinging the internal_error_cont stuff, or the ODR 
> diagnostics changes.
> 
> WRT the ODR diagnostics, I'd say let's go with the C++17 style 
> (all-lowercase with a hyphen).

Here's an updated version of the patch for the coding conventions page
of the website, which makes that recommendation (with a leading "the").

For easy of review, the pertinent table headings are:

    <th>Use...</th><th>...instead of</th><th>Rationale</th>

OK to commit?

(I've got a followup patch to update the diagnostics accordingly)

> If you've got a pointer to the internal_err_cont changes, please pass
> it 
> along.
> 
> jeff
>

Comments

Gerald Pfeifer April 10, 2017, 7:38 a.m. UTC | #1 
On Thu, 6 Apr 2017, David Malcolm wrote:
> OK to commit?

If that's what the standard uses, yes, thanks.  (We still may
want to add "C++" in there, unless you feel the context is always
clear enough anyway, which I could well see...)

Gerald
diff mbox

Patch

Index: htdocs/codingconventions.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/codingconventions.html,v
retrieving revision 1.80
diff -u -p -r1.80 codingconventions.html
--- htdocs/codingconventions.html	13 Mar 2017 22:01:05 -0000	1.80
+++ htdocs/codingconventions.html	6 Apr 2017 20:55:51 -0000
@@ -448,6 +448,12 @@  and code.  The following table lists som
     <td>"Objective C"</td>
   </tr>
   <tr>
+    <td>"the one-definition rule"</td>
+    <td>"One Definition Rule", "the C++ One Definition Rule",
+      or "one definition rule"</td>
+    <td>Style used in the C++17 standard</td>
+  </tr>
+  <tr>
     <td>"prologue"</td>
     <td>"prolog"</td>
     <td>Established convention</td>