Message ID | 1491488461-24621-4-git-send-email-ldewangan@nvidia.com |
---|---|
State | Superseded |
Headers | show |
On 06/04/17 15:21, Laxman Dewangan wrote: > In some of NVIDIA Tegra's platform, PWM controller is used to > control the PWM controlled regulators. PWM signal is connected to > the VID pin of the regulator where duty cycle of PWM signal decide > the voltage level of the regulator output. > > The tristate (high impedance of PWM pin form Tegra) also define s/form/from/ s/define/defines/ > one of the state of PWM regulator which needs to be configure in > suspend state of system. It maybe clearer to say that when the system enters suspend the regulator requires the pwm output to be tristated. > Add DT binding details to provide the pin configuration state > from PWM and pinctrl DT node in suspend and active state of > the system. > > Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> > --- > Changes from v1: > - Use standard pinctrl names for sleep and active state. > > .../devicetree/bindings/pwm/nvidia,tegra20-pwm.txt | 43 ++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt b/Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt > index b4e7377..4128cdc 100644 > --- a/Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt > +++ b/Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt > @@ -19,6 +19,19 @@ Required properties: > - reset-names: Must include the following entries: > - pwm > > +Optional properties: > +============================ > +In some of the interface like PWM based regulator device, it is required > +to configure the pins differently in different states, especially in suspend > +state of the system. The configuration of pin is provided via the pinctrl > +DT node as detailed in the pinctrl DT binding document > + Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt > + > +The PWM node will have following optional properties. > +pinctrl-names: Pin state names. Must be "default" and "sleep". > +pinctrl-0: Node handle for the default/active state of pi configurations. s/pi/pin/ s/Node handle/phandle/ > +pinctrl-1: Node handle for the sleep state of pin configurations. > + > Example: > > pwm: pwm@7000a000 { > @@ -29,3 +42,33 @@ Example: > resets = <&tegra_car 17>; > reset-names = "pwm"; > }; > + > + > +Example with the pin configuration for suspend and resume: > +========================================================= > +Pin PE7 is used as PWM interface. Nit-pick. On what devices? Sounds like this is verbatim. Maybe state what device this is an example for. Jon
On Thursday 06 April 2017 08:56 PM, Jon Hunter wrote: > On 06/04/17 15:21, Laxman Dewangan wrote: >> In some of NVIDIA Tegra's platform, PWM controller is used to >> control the PWM controlled regulators. PWM signal is connected to >> the VID pin of the regulator where duty cycle of PWM signal decide >> the voltage level of the regulator output. >> >> The tristate (high impedance of PWM pin form Tegra) also define > s/form/from/ > s/define/defines/ > >> one of the state of PWM regulator which needs to be configure in >> suspend state of system. > It maybe clearer to say that when the system enters suspend the > regulator requires the pwm output to be tristated. Not necessarily that every PWM regulator interfaces needs it. It depends on the devices. So I will say: When system enters suspend, in some of PWM regulator interface, it is required to to set the PWM output to be tristated. > pwm: pwm@7000a000 { > @@ -29,3 +42,33 @@ Example: > resets = <&tegra_car 17>; > reset-names = "pwm"; > }; > + > + > +Example with the pin configuration for suspend and resume: > +========================================================= > +Pin PE7 is used as PWM interface. > Nit-pick. On what devices? Sounds like this is verbatim. Maybe state > what device this is an example for. Let me phrase it as: Suppose pin PE7 (On tegra210) interfaced with the regulator device and this requires PWM output to be tristated when system enters suspend. Following will be DT binding to achieve this: -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 06/04/17 17:48, Laxman Dewangan wrote: > > On Thursday 06 April 2017 08:56 PM, Jon Hunter wrote: >> On 06/04/17 15:21, Laxman Dewangan wrote: >>> In some of NVIDIA Tegra's platform, PWM controller is used to >>> control the PWM controlled regulators. PWM signal is connected to >>> the VID pin of the regulator where duty cycle of PWM signal decide >>> the voltage level of the regulator output. >>> >>> The tristate (high impedance of PWM pin form Tegra) also define >> s/form/from/ >> s/define/defines/ >> >>> one of the state of PWM regulator which needs to be configure in >>> suspend state of system. >> It maybe clearer to say that when the system enters suspend the >> regulator requires the pwm output to be tristated. > > Not necessarily that every PWM regulator interfaces needs it. It > depends on the devices. Yes I understand that. I am just saying the description could be a little clearer. > So I will say: > > When system enters suspend, in some of PWM regulator interface, it is > required to to set the PWM output to be tristated. Ok, but I think you should say why that is, because from the above sentence alone it is not clear. Maybe you should say that some PWM client/slave devices require the PWM output to be tristated. Jon
diff --git a/Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt b/Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt index b4e7377..4128cdc 100644 --- a/Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt +++ b/Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt @@ -19,6 +19,19 @@ Required properties: - reset-names: Must include the following entries: - pwm +Optional properties: +============================ +In some of the interface like PWM based regulator device, it is required +to configure the pins differently in different states, especially in suspend +state of the system. The configuration of pin is provided via the pinctrl +DT node as detailed in the pinctrl DT binding document + Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt + +The PWM node will have following optional properties. +pinctrl-names: Pin state names. Must be "default" and "sleep". +pinctrl-0: Node handle for the default/active state of pi configurations. +pinctrl-1: Node handle for the sleep state of pin configurations. + Example: pwm: pwm@7000a000 { @@ -29,3 +42,33 @@ Example: resets = <&tegra_car 17>; reset-names = "pwm"; }; + + +Example with the pin configuration for suspend and resume: +========================================================= +Pin PE7 is used as PWM interface. + +#include <dt-bindings/pinctrl/pinctrl-tegra.h> + + pinmux@70000868 { + pwm_active_state: pwm_active_state { + pe7 { + nvidia,pins = "pe7"; + nvidia,tristate = <TEGRA_PIN_DISABLE>; + }; + }; + + pwm_sleep_state: pwm_sleep_state { + pe7 { + nvidia,pins = "pe7"; + nvidia,tristate = <TEGRA_PIN_ENABLE>; + }; + }; + }; + + pwm@7000a000 { + /* Mandatory PWM properties */ + pinctrl-names = "default", "sleep"; + pinctrl-0 = <&pwm_active_state>; + pinctrl-1 = <&pwm_sleep_state>; + };
In some of NVIDIA Tegra's platform, PWM controller is used to control the PWM controlled regulators. PWM signal is connected to the VID pin of the regulator where duty cycle of PWM signal decide the voltage level of the regulator output. The tristate (high impedance of PWM pin form Tegra) also define one of the state of PWM regulator which needs to be configure in suspend state of system. Add DT binding details to provide the pin configuration state from PWM and pinctrl DT node in suspend and active state of the system. Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> --- Changes from v1: - Use standard pinctrl names for sleep and active state. .../devicetree/bindings/pwm/nvidia,tegra20-pwm.txt | 43 ++++++++++++++++++++++ 1 file changed, 43 insertions(+)