Message ID | 20170406141450.16060-1-khandual@linux.vnet.ibm.com (mailing list archive) |
---|---|
State | Rejected |
Headers | show |
On 04/06/2017 07:44 PM, Anshuman Khandual wrote: > The commit (16a05bff1: powerpc: start loop at section start of > start in vmemmap_populated()) reused 'start' variable to compute > the starting address of the memory section where the given address > belongs. Then the same variable is used for iterating over starting > address of all memory sections before reaching the 'end' address. > Renaming it as 'section_start' makes the logic more clear. > > Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com> > --- > Previous discussions on this http://patchwork.ozlabs.org/patch/584103/ Hello Michael, Are you okay with this cleanup, we had discussed about this before which can be pulled up from the link above. The other two patches are just in-code documentation addition to relevant files. Regards Anshuman
diff --git a/arch/powerpc/mm/init_64.c b/arch/powerpc/mm/init_64.c index c22f207..2a15986 100644 --- a/arch/powerpc/mm/init_64.c +++ b/arch/powerpc/mm/init_64.c @@ -104,11 +104,15 @@ static unsigned long __meminit vmemmap_section_start(unsigned long page) */ static int __meminit vmemmap_populated(unsigned long start, int page_size) { - unsigned long end = start + page_size; - start = (unsigned long)(pfn_to_page(vmemmap_section_start(start))); + unsigned long end, section_start; - for (; start < end; start += (PAGES_PER_SECTION * sizeof(struct page))) - if (pfn_valid(page_to_pfn((struct page *)start))) + end = start + page_size; + section_start = (unsigned long)(pfn_to_page + (vmemmap_section_start(start))); + + for (; section_start < end; section_start + += (PAGES_PER_SECTION * sizeof(struct page))) + if (pfn_valid(page_to_pfn((struct page *)section_start))) return 1; return 0;
The commit (16a05bff1: powerpc: start loop at section start of start in vmemmap_populated()) reused 'start' variable to compute the starting address of the memory section where the given address belongs. Then the same variable is used for iterating over starting address of all memory sections before reaching the 'end' address. Renaming it as 'section_start' makes the logic more clear. Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com> --- Previous discussions on this http://patchwork.ozlabs.org/patch/584103/ arch/powerpc/mm/init_64.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)