Patchwork Fix two s390.md nits

login
register
mail settings
Submitter Jakub Jelinek
Date Dec. 8, 2010, 9:27 p.m.
Message ID <20101208212749.GI29412@tyan-ft48-01.lab.bos.redhat.com>
Download mbox | patch
Permalink /patch/74781/
State New
Headers show

Comments

Jakub Jelinek - Dec. 8, 2010, 9:27 p.m.
Hi!

Two nits I've noticed today, the lgoc -> locg patch left the wrong spelling
in comment, and I see new warnings:
warning: source missing a mode?
(8 times) on the sync_old_<atomic><mode> pattern.

Ok for trunk?

2010-12-08  Jakub Jelinek  <jakub@redhat.com>

	* config/s390/s390.md (*mov<mode>cc): Change lgoc and stgoc to
	locg and stocg even in comment.
	(sync_old_<atomic><mode>): Give mode to UNSPEC_VOLATILE.


	Jakub
Andreas Krebbel - Dec. 9, 2010, 8:38 a.m.
> 2010-12-08  Jakub Jelinek  <jakub@redhat.com>
> 
> 	* config/s390/s390.md (*mov<mode>cc): Change lgoc and stgoc to
> 	locg and stocg even in comment.
> 	(sync_old_<atomic><mode>): Give mode to UNSPEC_VOLATILE.

This is ok. Thanks!

Bye,

-Andreas-

Patch

--- gcc/config/s390/s390.md.jj	2010-11-17 10:13:17.581278815 +0100
+++ gcc/config/s390/s390.md	2010-12-08 22:19:57.769654839 +0100
@@ -5338,7 +5338,7 @@ 
   "operands[1] = s390_emit_compare (GET_CODE (operands[1]),
                                     XEXP (operands[1], 0), XEXP (operands[1], 1));")
 
-; locr, loc, stoc, locgr, lgoc, stgoc
+; locr, loc, stoc, locgr, locg, stocg
 (define_insn_and_split "*mov<mode>cc"
   [(set (match_operand:GPR 0 "nonimmediate_operand"   "=d,d, d, d,QS,QS,&d")
 	(if_then_else:GPR
@@ -8845,7 +8845,7 @@ 
     [(set (match_operand:GPR 0 "register_operand" "=d")
 	  (match_operand:GPR 1 "memory_operand"   "+QS"))
      (set (match_dup 1)
-	  (unspec_volatile
+	  (unspec_volatile:GPR
 	   [(ATOMIC_Z196:GPR (match_dup 1)
 			     (match_operand:GPR 2 "general_operand" "d"))]
 	   UNSPECV_ATOMIC_OP))