[1/2] verify tracking bug really exists

Message ID 20170405140831.12826-1-cascardo@canonical.com
State New
Headers show

Commit Message

Thadeu Lima de Souza Cascardo April 5, 2017, 2:08 p.m.
---
 maintscripts/verify-release-ready | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

Comments

Thadeu Lima de Souza Cascardo April 5, 2017, 2:37 p.m. | #1
On Wed, Apr 05, 2017 at 03:08:30PM +0100, Thadeu Lima de Souza Cascardo wrote:
> ---
>  maintscripts/verify-release-ready | 15 ++++++++++++++-
>  1 file changed, 14 insertions(+), 1 deletion(-)
> 

Please, ignore this patch, still working on it.

Cascardo.

> diff --git a/maintscripts/verify-release-ready b/maintscripts/verify-release-ready
> index f9ad400..a99b7b3 100755
> --- a/maintscripts/verify-release-ready
> +++ b/maintscripts/verify-release-ready
> @@ -266,7 +266,9 @@ class VerifyReleaseReady():
>  
>          # Verify the bugs in the changelog are public, targeted against linux and the
>          # proper series, and marked Fix Committed.
> -        s.verify_changelog_bugs()
> +        tracker = s.verify_changelog_bugs()
> +
> +        s.verify_tracker_bug(tracker)
>  
>          s.verify_content()
>  
> @@ -348,6 +350,8 @@ class VerifyReleaseReady():
>          changelog_series = changelog[1]['series']
>          changelog_source_package = changelog[1]['package']
>  
> +        tracker = None
> +
>          for bug in changelog_bugs:
>              # Error on private or invalid bugs
>              try:
> @@ -358,6 +362,7 @@ class VerifyReleaseReady():
>  
>              # Ignore kernel-release-tracking-bug's
>              if 'kernel-release-tracking-bug' in lp_bug.tags:
> +                tracker = lp_bug
>                  continue
>  
>              # check bug tasks, is series/package/status correct?
> @@ -385,6 +390,14 @@ class VerifyReleaseReady():
>              if not is_fix_committed:
>                  s.status('LP: #%s is not fix committed' % bug, 'warning')
>  
> +        return tracker
> +
> +    def verify_tracker_bug(s, bug):
> +        if bug == None:
> +            s.status('No tracker bug found', 'warning')
> +            return
> +	s.status('Tracker bug found', bug.id)
> +
>      def verify_content(s):
>          changelog = Debian.changelog()
>          content = changelog[1]['content']
> -- 
> 2.9.3
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Brad Figg April 17, 2017, 2:40 p.m. | #2

Patch

diff --git a/maintscripts/verify-release-ready b/maintscripts/verify-release-ready
index f9ad400..a99b7b3 100755
--- a/maintscripts/verify-release-ready
+++ b/maintscripts/verify-release-ready
@@ -266,7 +266,9 @@  class VerifyReleaseReady():
 
         # Verify the bugs in the changelog are public, targeted against linux and the
         # proper series, and marked Fix Committed.
-        s.verify_changelog_bugs()
+        tracker = s.verify_changelog_bugs()
+
+        s.verify_tracker_bug(tracker)
 
         s.verify_content()
 
@@ -348,6 +350,8 @@  class VerifyReleaseReady():
         changelog_series = changelog[1]['series']
         changelog_source_package = changelog[1]['package']
 
+        tracker = None
+
         for bug in changelog_bugs:
             # Error on private or invalid bugs
             try:
@@ -358,6 +362,7 @@  class VerifyReleaseReady():
 
             # Ignore kernel-release-tracking-bug's
             if 'kernel-release-tracking-bug' in lp_bug.tags:
+                tracker = lp_bug
                 continue
 
             # check bug tasks, is series/package/status correct?
@@ -385,6 +390,14 @@  class VerifyReleaseReady():
             if not is_fix_committed:
                 s.status('LP: #%s is not fix committed' % bug, 'warning')
 
+        return tracker
+
+    def verify_tracker_bug(s, bug):
+        if bug == None:
+            s.status('No tracker bug found', 'warning')
+            return
+	s.status('Tracker bug found', bug.id)
+
     def verify_content(s):
         changelog = Debian.changelog()
         content = changelog[1]['content']