| Message ID | 20170405112007.17390-1-khandual@linux.vnet.ibm.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
Hi Anshuman Khandual <khandual@linux.vnet.ibm.com> a écrit : > This just adds user space exported ABI definitions for 2MB, 16MB, 1GB, > 16GB non default huge page sizes to be used with mmap() system call. Why not add all possible huge page sizes ? For instance the 8xx (only) supports 512k and 8M hugepages Christophe > > Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com> > --- > These defined values will be used along with MAP_HUGETLB while calling > mmap() system call if the desired HugeTLB page size is not the default > one. Follows similar definitions present in x86. > > arch/x86/include/uapi/asm/mman.h:#define MAP_HUGE_2MB (21 << > MAP_HUGE_SHIFT) > arch/x86/include/uapi/asm/mman.h:#define MAP_HUGE_1GB (30 << > MAP_HUGE_SHIFT) > > Changes in V3: > - Added comment about how these defines will help create 'flags' > argument for mmap() system call per Balbir > > Changes in V2: > - Added definitions for 2MB and 1GB HugeTLB pages per Aneesh > > arch/powerpc/include/uapi/asm/mman.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/powerpc/include/uapi/asm/mman.h > b/arch/powerpc/include/uapi/asm/mman.h > index 03c06ba..0c84e14 100644 > --- a/arch/powerpc/include/uapi/asm/mman.h > +++ b/arch/powerpc/include/uapi/asm/mman.h > @@ -29,4 +29,14 @@ > #define MAP_STACK 0x20000 /* give out an address that is best > suited for process/thread stacks */ > #define MAP_HUGETLB 0x40000 /* create a huge page mapping */ > > +/* > + * These defines should be used for creating 'flags' argument > + * (26:31 bits) for the mmap() system call should the caller > + * decide to use non default HugeTLB page size. > + */ > +#define MAP_HUGE_2MB (21 << MAP_HUGE_SHIFT) /* 2MB HugeTLB Page */ > +#define MAP_HUGE_16MB (24 << MAP_HUGE_SHIFT) /* 16MB HugeTLB Page */ > +#define MAP_HUGE_1GB (30 << MAP_HUGE_SHIFT) /* 1GB HugeTLB Page */ > +#define MAP_HUGE_16GB (34 << MAP_HUGE_SHIFT) /* 16GB HugeTLB Page */ > + > #endif /* _UAPI_ASM_POWERPC_MMAN_H */ > -- > 1.8.5.2
On 04/07/2017 12:33 AM, LEROY Christophe wrote: > Hi > > Anshuman Khandual <khandual@linux.vnet.ibm.com> a écrit : > >> This just adds user space exported ABI definitions for 2MB, 16MB, 1GB, >> 16GB non default huge page sizes to be used with mmap() system call. > > Why not add all possible huge page sizes ? > For instance the 8xx (only) supports 512k and 8M hugepages Sure, can do that.
diff --git a/arch/powerpc/include/uapi/asm/mman.h b/arch/powerpc/include/uapi/asm/mman.h index 03c06ba..0c84e14 100644 --- a/arch/powerpc/include/uapi/asm/mman.h +++ b/arch/powerpc/include/uapi/asm/mman.h @@ -29,4 +29,14 @@ #define MAP_STACK 0x20000 /* give out an address that is best suited for process/thread stacks */ #define MAP_HUGETLB 0x40000 /* create a huge page mapping */ +/* + * These defines should be used for creating 'flags' argument + * (26:31 bits) for the mmap() system call should the caller + * decide to use non default HugeTLB page size. + */ +#define MAP_HUGE_2MB (21 << MAP_HUGE_SHIFT) /* 2MB HugeTLB Page */ +#define MAP_HUGE_16MB (24 << MAP_HUGE_SHIFT) /* 16MB HugeTLB Page */ +#define MAP_HUGE_1GB (30 << MAP_HUGE_SHIFT) /* 1GB HugeTLB Page */ +#define MAP_HUGE_16GB (34 << MAP_HUGE_SHIFT) /* 16GB HugeTLB Page */ + #endif /* _UAPI_ASM_POWERPC_MMAN_H */
This just adds user space exported ABI definitions for 2MB, 16MB, 1GB, 16GB non default huge page sizes to be used with mmap() system call. Signed-off-by: Anshuman Khandual <khandual@linux.vnet.ibm.com> --- These defined values will be used along with MAP_HUGETLB while calling mmap() system call if the desired HugeTLB page size is not the default one. Follows similar definitions present in x86. arch/x86/include/uapi/asm/mman.h:#define MAP_HUGE_2MB (21 << MAP_HUGE_SHIFT) arch/x86/include/uapi/asm/mman.h:#define MAP_HUGE_1GB (30 << MAP_HUGE_SHIFT) Changes in V3: - Added comment about how these defines will help create 'flags' argument for mmap() system call per Balbir Changes in V2: - Added definitions for 2MB and 1GB HugeTLB pages per Aneesh arch/powerpc/include/uapi/asm/mman.h | 10 ++++++++++ 1 file changed, 10 insertions(+)