| Message ID | 20170404202429.14643-6-ehabkost@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 04.04.2017 22:24, Eduardo Habkost wrote: > sysbus-fdc and SUNW,fdtwo devices need IRQs to be wired and mmio > to be mapped, and can't be used with -device. Unset > user_creatable on their device classes. > > Cc: John Snow <jsnow@redhat.com> > Cc: Kevin Wolf <kwolf@redhat.com> > Cc: Max Reitz <mreitz@redhat.com> > Cc: qemu-block@nongnu.org > Cc: Thomas Huth <thuth@redhat.com> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > --- > Changes v1 -> v2: > * Commit message rewrite only > --- > hw/block/fdc.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/hw/block/fdc.c b/hw/block/fdc.c > index 3d05565628..a328693d15 100644 > --- a/hw/block/fdc.c > +++ b/hw/block/fdc.c > @@ -2880,11 +2880,6 @@ static void sysbus_fdc_class_init(ObjectClass *klass, void *data) > > dc->props = sysbus_fdc_properties; > set_bit(DEVICE_CATEGORY_STORAGE, dc->categories); > - /* > - * FIXME: Set only because we are not sure yet if this device > - * will be outside the q35 sysbus whitelist. > - */ > - dc->user_creatable = true; > } > > static const TypeInfo sysbus_fdc_info = { > @@ -2911,11 +2906,6 @@ static void sun4m_fdc_class_init(ObjectClass *klass, void *data) > > dc->props = sun4m_fdc_properties; > set_bit(DEVICE_CATEGORY_STORAGE, dc->categories); > - /* > - * FIXME: Set only because we are not sure yet if this device > - * will be outside the q35 sysbus whitelist. > - */ > - dc->user_creatable = true; > } > > static const TypeInfo sun4m_fdc_info = { > Reviewed-by: Thomas Huth <thuth@redhat.com>
diff --git a/hw/block/fdc.c b/hw/block/fdc.c index 3d05565628..a328693d15 100644 --- a/hw/block/fdc.c +++ b/hw/block/fdc.c @@ -2880,11 +2880,6 @@ static void sysbus_fdc_class_init(ObjectClass *klass, void *data) dc->props = sysbus_fdc_properties; set_bit(DEVICE_CATEGORY_STORAGE, dc->categories); - /* - * FIXME: Set only because we are not sure yet if this device - * will be outside the q35 sysbus whitelist. - */ - dc->user_creatable = true; } static const TypeInfo sysbus_fdc_info = { @@ -2911,11 +2906,6 @@ static void sun4m_fdc_class_init(ObjectClass *klass, void *data) dc->props = sun4m_fdc_properties; set_bit(DEVICE_CATEGORY_STORAGE, dc->categories); - /* - * FIXME: Set only because we are not sure yet if this device - * will be outside the q35 sysbus whitelist. - */ - dc->user_creatable = true; } static const TypeInfo sun4m_fdc_info = {
sysbus-fdc and SUNW,fdtwo devices need IRQs to be wired and mmio to be mapped, and can't be used with -device. Unset user_creatable on their device classes. Cc: John Snow <jsnow@redhat.com> Cc: Kevin Wolf <kwolf@redhat.com> Cc: Max Reitz <mreitz@redhat.com> Cc: qemu-block@nongnu.org Cc: Thomas Huth <thuth@redhat.com> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> --- Changes v1 -> v2: * Commit message rewrite only --- hw/block/fdc.c | 10 ---------- 1 file changed, 10 deletions(-)