| Message ID | 20170404202429.14643-5-ehabkost@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 04/04/2017 11:24 PM, Eduardo Habkost wrote: > amd-iommu and intel-iommu are really meant to be used with > -device, so they need user_creatable=true. Remove the FIXME > comment. > > Cc: Marcel Apfelbaum <marcel@redhat.com> > Cc: "Michael S. Tsirkin" <mst@redhat.com> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > --- > Changes v1 -> v2: > * (none) > --- > hw/i386/amd_iommu.c | 5 +---- > hw/i386/intel_iommu.c | 5 +---- > 2 files changed, 2 insertions(+), 8 deletions(-) > > diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c > index 7b92c8c15a..efcc93cbfd 100644 > --- a/hw/i386/amd_iommu.c > +++ b/hw/i386/amd_iommu.c > @@ -1186,10 +1186,7 @@ static void amdvi_class_init(ObjectClass *klass, void* data) > dc->vmsd = &vmstate_amdvi; > dc->hotpluggable = false; > dc_class->realize = amdvi_realize; > - /* > - * FIXME: Set only because we are not sure yet if this device > - * will be outside the q35 sysbus whitelist. > - */ > + /* Supported by the pc-q35-* machine types */ > dc->user_creatable = true; > } > > diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c > index d71d52c328..b14db306ef 100644 > --- a/hw/i386/intel_iommu.c > +++ b/hw/i386/intel_iommu.c > @@ -2601,10 +2601,7 @@ static void vtd_class_init(ObjectClass *klass, void *data) > dc->hotpluggable = false; > x86_class->realize = vtd_realize; > x86_class->int_remap = vtd_int_remap; > - /* > - * FIXME: Set only because we are not sure yet if this device > - * will be outside the q35 sysbus whitelist. > - */ > + /* Supported by the pc-q35-* machine types */ > dc->user_creatable = true; > } > > Reviewed-by: Marcel Apfelbaum <marcel@redhat.com> Thanks, Marcel
diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c index 7b92c8c15a..efcc93cbfd 100644 --- a/hw/i386/amd_iommu.c +++ b/hw/i386/amd_iommu.c @@ -1186,10 +1186,7 @@ static void amdvi_class_init(ObjectClass *klass, void* data) dc->vmsd = &vmstate_amdvi; dc->hotpluggable = false; dc_class->realize = amdvi_realize; - /* - * FIXME: Set only because we are not sure yet if this device - * will be outside the q35 sysbus whitelist. - */ + /* Supported by the pc-q35-* machine types */ dc->user_creatable = true; } diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index d71d52c328..b14db306ef 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -2601,10 +2601,7 @@ static void vtd_class_init(ObjectClass *klass, void *data) dc->hotpluggable = false; x86_class->realize = vtd_realize; x86_class->int_remap = vtd_int_remap; - /* - * FIXME: Set only because we are not sure yet if this device - * will be outside the q35 sysbus whitelist. - */ + /* Supported by the pc-q35-* machine types */ dc->user_creatable = true; }
amd-iommu and intel-iommu are really meant to be used with -device, so they need user_creatable=true. Remove the FIXME comment. Cc: Marcel Apfelbaum <marcel@redhat.com> Cc: "Michael S. Tsirkin" <mst@redhat.com> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> --- Changes v1 -> v2: * (none) --- hw/i386/amd_iommu.c | 5 +---- hw/i386/intel_iommu.c | 5 +---- 2 files changed, 2 insertions(+), 8 deletions(-)