diff mbox

[U-Boot,6/7] Enable print log file to lcd

Message ID 1491057777-1640-7-git-send-email-eric.gao@rock-chips.com
State Superseded
Delegated to: Simon Glass
Headers show

Commit Message

eric.gao@rock-chips.com April 1, 2017, 2:42 p.m. UTC 
From: "eric.gao" <eric.gao@rock-chips.com>

Signed-off-by: eric.gao <eric.gao@rock-chips.com>
---

 configs/evb-rk3399_defconfig    | 1 +
 include/configs/rk3399_common.h | 5 ++++-
 2 files changed, 5 insertions(+), 1 deletion(-)

Comments

Simon Glass April 6, 2017, 3:44 a.m. UTC | #1 
On 1 April 2017 at 08:42,  <eric.gao@rock-chips.com> wrote:
> From: "eric.gao" <eric.gao@rock-chips.com>
>
> Signed-off-by: eric.gao <eric.gao@rock-chips.com>
> ---
>
>  configs/evb-rk3399_defconfig    | 1 +
>  include/configs/rk3399_common.h | 5 ++++-
>  2 files changed, 5 insertions(+), 1 deletion(-)
>

Reviewed-by: Simon Glass <sjg@chromium.org>


> diff --git a/configs/evb-rk3399_defconfig b/configs/evb-rk3399_defconfig
> index b9cb0e8..89b2e17 100644
> --- a/configs/evb-rk3399_defconfig
> +++ b/configs/evb-rk3399_defconfig
> @@ -68,3 +68,4 @@ CONFIG_DM_VIDEO=y
>  CONFIG_DISPLAY=y
>  CONFIG_VIDEO_ROCKCHIP=y
>  CONFIG_DISPLAY_MIPI=y
> +CONFIG_VIDCONSOLE_AS_LCD=y

But do you need this option?

> diff --git a/include/configs/rk3399_common.h b/include/configs/rk3399_common.h
> index 4ba81ac..6183f4e 100644
> --- a/include/configs/rk3399_common.h
> +++ b/include/configs/rk3399_common.h
> @@ -69,7 +69,10 @@
>  #define CONFIG_EXTRA_ENV_SETTINGS \
>         ENV_MEM_LAYOUT_SETTINGS \
>         "partitions=" PARTS_DEFAULT \
> -       BOOTENV
> +       BOOTENV \
> +       "stdin=serial,cros-ec-keyb\0" \
> +       "stdout=serial,vidconsole\0" \
> +       "stderr=serial,vidconsole\0"
>
>  #endif
>
> --
> 1.9.1
>
>
eric.gao@rock-chips.com April 6, 2017, 8:48 a.m. UTC | #2 
Dear Glass,

     Thank you, I will drop this patch and move it to README file.


On 2017年04月06日 11:44, Simon Glass wrote:
> On 1 April 2017 at 08:42,  <eric.gao@rock-chips.com> wrote:
>> From: "eric.gao" <eric.gao@rock-chips.com>
>>
>> Signed-off-by: eric.gao <eric.gao@rock-chips.com>
>> ---
>>
>>   configs/evb-rk3399_defconfig    | 1 +
>>   include/configs/rk3399_common.h | 5 ++++-
>>   2 files changed, 5 insertions(+), 1 deletion(-)
>>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
>
>> diff --git a/configs/evb-rk3399_defconfig b/configs/evb-rk3399_defconfig
>> index b9cb0e8..89b2e17 100644
>> --- a/configs/evb-rk3399_defconfig
>> +++ b/configs/evb-rk3399_defconfig
>> @@ -68,3 +68,4 @@ CONFIG_DM_VIDEO=y
>>   CONFIG_DISPLAY=y
>>   CONFIG_VIDEO_ROCKCHIP=y
>>   CONFIG_DISPLAY_MIPI=y
>> +CONFIG_VIDCONSOLE_AS_LCD=y
> But do you need this option?
>
>> diff --git a/include/configs/rk3399_common.h b/include/configs/rk3399_common.h
>> index 4ba81ac..6183f4e 100644
>> --- a/include/configs/rk3399_common.h
>> +++ b/include/configs/rk3399_common.h
>> @@ -69,7 +69,10 @@
>>   #define CONFIG_EXTRA_ENV_SETTINGS \
>>          ENV_MEM_LAYOUT_SETTINGS \
>>          "partitions=" PARTS_DEFAULT \
>> -       BOOTENV
>> +       BOOTENV \
>> +       "stdin=serial,cros-ec-keyb\0" \
>> +       "stdout=serial,vidconsole\0" \
>> +       "stderr=serial,vidconsole\0"
>>
>>   #endif
>>
>> --
>> 1.9.1
>>
>>
>
>
diff mbox

Patch

diff --git a/configs/evb-rk3399_defconfig b/configs/evb-rk3399_defconfig
index b9cb0e8..89b2e17 100644
--- a/configs/evb-rk3399_defconfig
+++ b/configs/evb-rk3399_defconfig
@@ -68,3 +68,4 @@  CONFIG_DM_VIDEO=y
 CONFIG_DISPLAY=y
 CONFIG_VIDEO_ROCKCHIP=y
 CONFIG_DISPLAY_MIPI=y
+CONFIG_VIDCONSOLE_AS_LCD=y
diff --git a/include/configs/rk3399_common.h b/include/configs/rk3399_common.h
index 4ba81ac..6183f4e 100644
--- a/include/configs/rk3399_common.h
+++ b/include/configs/rk3399_common.h
@@ -69,7 +69,10 @@ 
 #define CONFIG_EXTRA_ENV_SETTINGS \
 	ENV_MEM_LAYOUT_SETTINGS \
 	"partitions=" PARTS_DEFAULT \
-	BOOTENV
+	BOOTENV \
+	"stdin=serial,cros-ec-keyb\0" \
+	"stdout=serial,vidconsole\0" \
+	"stderr=serial,vidconsole\0"
 
 #endif