diff mbox

[ovs-dev,2/2] netdev-dpdk: Show Rx checksum status when false.

Message ID 1491312874-17223-2-git-send-email-ktraynor@redhat.com
State Superseded
Delegated to: Darrell Ball
Headers show

Commit Message

Kevin Traynor April 4, 2017, 1:34 p.m. UTC
Currently ovs-appctl dpctl/show only shows the Rx checksum offload
status when true. Change to also show the status when false.

Cc: Sugesh Chandran <sugesh.chandran@intel.com>
Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
---
 lib/netdev-dpdk.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Chandran, Sugesh April 10, 2017, 3:32 p.m. UTC | #1
Regards
_Sugesh


> -----Original Message-----
> From: Kevin Traynor [mailto:ktraynor@redhat.com]
> Sent: Tuesday, April 4, 2017 6:35 AM
> To: dev@openvswitch.org
> Cc: Kevin Traynor <ktraynor@redhat.com>; Chandran, Sugesh
> <sugesh.chandran@intel.com>
> Subject: [PATCH 2/2] netdev-dpdk: Show Rx checksum status when false.
> 
> Currently ovs-appctl dpctl/show only shows the Rx checksum offload status
> when true. Change to also show the status when false.
> 
> Cc: Sugesh Chandran <sugesh.chandran@intel.com>
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> ---
>  lib/netdev-dpdk.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index d5a9800..b1fecfa
> 100644
> --- a/lib/netdev-dpdk.c
> +++ b/lib/netdev-dpdk.c
> @@ -1092,4 +1092,6 @@ netdev_dpdk_get_config(const struct netdev
> *netdev, struct smap *args)
>          if (dev->hw_ol_features & NETDEV_RX_CHECKSUM_OFFLOAD) {
>              smap_add(args, "rx_csum_offload", "true");
> +        } else {
> +            smap_add(args, "rx_csum_offload", "false");
[Sugesh] Thank you for adding it, I verified in my test setup.

>          }
>      }
> --
> 1.8.3.1
diff mbox

Patch

diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index d5a9800..b1fecfa 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -1092,4 +1092,6 @@  netdev_dpdk_get_config(const struct netdev *netdev, struct smap *args)
         if (dev->hw_ol_features & NETDEV_RX_CHECKSUM_OFFLOAD) {
             smap_add(args, "rx_csum_offload", "true");
+        } else {
+            smap_add(args, "rx_csum_offload", "false");
         }
     }