hw/phb[3/4]: Increase the severity level for pcie slot link timeouts

Submitted by ppaidipe@linux.vnet.ibm.com on April 4, 2017, 6:05 a.m.

Details

Message ID 1491285921-14965-1-git-send-email-ppaidipe@linux.vnet.ibm.com
State New
Headers show

Commit Message

ppaidipe@linux.vnet.ibm.com April 4, 2017, 6:05 a.m.
Currently waiting for PHB pcie slot link timeout error messages
are in debug log level. Make them to PR_ERR, so that users can
check in console itself, as well as tests can catch these errors
easily.

Signed-off-by: Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com>
---
 hw/phb3.c | 4 ++--
 hw/phb4.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

Patch hide | download patch | download mbox

diff --git a/hw/phb3.c b/hw/phb3.c
index 9bc9d78..b37cf65 100644
--- a/hw/phb3.c
+++ b/hw/phb3.c
@@ -2281,7 +2281,7 @@  static int64_t phb3_poll_link(struct pci_slot *slot)
 		}
 
 		if (slot->retries-- == 0) {
-			PHBDBG(p, "LINK: Timeout waiting for electrical link\n");
+			PHBERR(p, "LINK: Timeout waiting for electrical link\n");
 			PHBDBG(p, "LINK: DLP train control: 0x%016llx\n", reg);
 			rc = phb3_retry_state(slot);
 			if (rc >= OPAL_SUCCESS)
@@ -2302,7 +2302,7 @@  static int64_t phb3_poll_link(struct pci_slot *slot)
 		}
 
 		if (slot->retries-- == 0) {
-			PHBDBG(p, "LINK: Timeout waiting for link up\n");
+			PHBERR(p, "LINK: Timeout waiting for link up\n");
 			PHBDBG(p, "LINK: DLP train control: 0x%016llx\n", reg);
 			rc = phb3_retry_state(slot);
 			if (rc >= OPAL_SUCCESS)
diff --git a/hw/phb4.c b/hw/phb4.c
index 571f703..590bb30 100644
--- a/hw/phb4.c
+++ b/hw/phb4.c
@@ -1807,7 +1807,7 @@  static int64_t phb4_poll_link(struct pci_slot *slot)
 		}
 
 		if (slot->retries-- == 0) {
-			PHBDBG(p, "LINK: Timeout waiting for electrical link\n");
+			PHBERR(p, "LINK: Timeout waiting for electrical link\n");
 			PHBDBG(p, "LINK: DLP train control: 0x%016llx\n", reg);
 			rc = phb4_retry_state(slot);
 			if (rc >= OPAL_SUCCESS)
@@ -1828,7 +1828,7 @@  static int64_t phb4_poll_link(struct pci_slot *slot)
 		}
 
 		if (slot->retries-- == 0) {
-			PHBDBG(p, "LINK: Timeout waiting for link up\n");
+			PHBERR(p, "LINK: Timeout waiting for link up\n");
 			PHBDBG(p, "LINK: DLP train control: 0x%016llx\n", reg);
 			rc = phb4_retry_state(slot);
 			if (rc >= OPAL_SUCCESS)