Message ID | 20170403182522.GA32592@mwanda |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
> We should be returning -ENOMEM if qed_mcp_cmd_add_elem() fails. The > current code returns success. > > Fixes: 4ed1eea82a21 ("qed: Revise MFW command locking") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Thanks Acked-by: Tomer Tayar <Tomer.Tayar@cavium.com>
From: Dan Carpenter <dan.carpenter@oracle.com> Date: Mon, 3 Apr 2017 21:25:22 +0300 > We should be returning -ENOMEM if qed_mcp_cmd_add_elem() fails. The > current code returns success. > > Fixes: 4ed1eea82a21 ("qed: Revise MFW command locking") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Applied.
diff --git a/drivers/net/ethernet/qlogic/qed/qed_mcp.c b/drivers/net/ethernet/qlogic/qed/qed_mcp.c index 619eac845028..ff6080df2246 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_mcp.c +++ b/drivers/net/ethernet/qlogic/qed/qed_mcp.c @@ -455,8 +455,10 @@ _qed_mcp_cmd_and_union(struct qed_hwfn *p_hwfn, qed_mcp_reread_offsets(p_hwfn, p_ptt); seq_num = ++p_hwfn->mcp_info->drv_mb_seq; p_cmd_elem = qed_mcp_cmd_add_elem(p_hwfn, p_mb_params, seq_num); - if (!p_cmd_elem) + if (!p_cmd_elem) { + rc = -ENOMEM; goto err; + } __qed_mcp_cmd_and_union(p_hwfn, p_ptt, p_mb_params, seq_num); spin_unlock_bh(&p_hwfn->mcp_info->cmd_lock);
We should be returning -ENOMEM if qed_mcp_cmd_add_elem() fails. The current code returns success. Fixes: 4ed1eea82a21 ("qed: Revise MFW command locking") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>