| Message ID | 20170403181827.GA6505@mwanda |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Dan Carpenter <dan.carpenter@oracle.com> Date: Mon, 2017-Apr-03 21:18:27 +0300 > There is a cut and paste bug here so we accidentally clear the first > few bytes of "resp" a second time instead clearing "ctx". > > Fixes: 50c0add534d2 ("liquidio: refactor interrupt moderation code") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > diff --git a/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c b/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c > index fac02ed2c449..dab10c7e4443 100644 > --- a/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c > +++ b/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c > @@ -1359,7 +1359,7 @@ static int octnet_get_intrmod_cfg(struct lio *lio, > memset(resp, 0, sizeof(struct oct_intrmod_resp)); > > ctx = (struct oct_intrmod_context *)sc->ctxptr; > - memset(resp, 0, sizeof(struct oct_intrmod_context)); > + memset(ctx, 0, sizeof(struct oct_intrmod_context)); > WRITE_ONCE(ctx->cond, 0); > ctx->octeon_id = lio_get_device_id(oct_dev); > init_waitqueue_head(&ctx->wc); Good catch, Dan. Thanks. Acked-by: Felix Manlunas <felix.manlunas@cavium.com>
From: Dan Carpenter <dan.carpenter@oracle.com> Date: Mon, 3 Apr 2017 21:18:27 +0300 > There is a cut and paste bug here so we accidentally clear the first > few bytes of "resp" a second time instead clearing "ctx". > > Fixes: 50c0add534d2 ("liquidio: refactor interrupt moderation code") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Applied.
diff --git a/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c b/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c index fac02ed2c449..dab10c7e4443 100644 --- a/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c +++ b/drivers/net/ethernet/cavium/liquidio/lio_ethtool.c @@ -1359,7 +1359,7 @@ static int octnet_get_intrmod_cfg(struct lio *lio, memset(resp, 0, sizeof(struct oct_intrmod_resp)); ctx = (struct oct_intrmod_context *)sc->ctxptr; - memset(resp, 0, sizeof(struct oct_intrmod_context)); + memset(ctx, 0, sizeof(struct oct_intrmod_context)); WRITE_ONCE(ctx->cond, 0); ctx->octeon_id = lio_get_device_id(oct_dev); init_waitqueue_head(&ctx->wc);
There is a cut and paste bug here so we accidentally clear the first few bytes of "resp" a second time instead clearing "ctx". Fixes: 50c0add534d2 ("liquidio: refactor interrupt moderation code") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>