diff mbox

[U-Boot,v2,07/29] ARM: i.MX6QP: sabresd: Add initial devicetree support

Message ID 1491227616-15042-8-git-send-email-jagan@openedev.com
State Superseded
Delegated to: Stefano Babic
Headers show

Commit Message

Jagan Teki April 3, 2017, 1:53 p.m. UTC 
From: Jagan Teki <jagan@amarulasolutions.com>

Add initial dts support for i.MX6 Quad Plus Sabresd board.

Boot from MMC:
-------------
U-Boot SPL 2017.03-33690-ga80e4f6-dirty (Mar 30 2017 - 00:40:29)
Trying to boot from MMC1

U-Boot 2017.03-33690-ga80e4f6-dirty (Mar 30 2017 - 00:40:29 +0530)

CPU:   Freescale i.MX6QP rev1.0 996 MHz (running at 792 MHz)
CPU:   Automotive temperature grade (-40C to 125C) at 29C
Reset cause: POR
Model: Freescale i.MX6 Quad Plus SABRE Smart Device Board
Board: MX6-SabreSD
I2C:   ready
DRAM:  1 GiB
PMIC:  PFUZE100 ID=0x10
MMC:   FSL_SDHC: 0, FSL_SDHC: 1, FSL_SDHC: 2
*** Warning - bad CRC, using default environment

gpio@020a4000: dir_output: error: gpio GPIO3_19 not reserved
gpio@020a4000: set_value: error: gpio GPIO3_19 not reserved
gpio@020b4000: dir_output: error: gpio GPIO7_12 not reserved
gpio@020b4000: set_value: error: gpio GPIO7_12 not reserved
PCI:   pcie phy link never came up
No panel detected: default to Hannstar-XGA
gpio@0209c000: dir_output: error: gpio GPIO1_21 not reserved
Display: Hannstar-XGA (1024x768)
In:    serial
Out:   serial
Err:   serial
Net:   gpio@0209c000: dir_output: error: gpio GPIO1_25 not reserved
gpio@0209c000: set_value: error: gpio GPIO1_25 not reserved
FEC [PRIME]
Hit any key to stop autoboot:  0
=>

Cc: Stefano Babic <sbabic@denx.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Michael Trimarchi <michael@amarulasolutions.com>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 board/freescale/mx6sabresd/MAINTAINERS |  1 +
 configs/imx6qp_sabresd_defconfig       | 60 ++++++++++++++++++++++++++++++++++
 2 files changed, 61 insertions(+)
 create mode 100644 configs/imx6qp_sabresd_defconfig

Comments

Fabio Estevam April 3, 2017, 7:16 p.m. UTC | #1 
On Mon, Apr 3, 2017 at 10:53 AM, Jagan Teki <jagan@openedev.com> wrote:
> From: Jagan Teki <jagan@amarulasolutions.com>
>
> Add initial dts support for i.MX6 Quad Plus Sabresd board.
>
> Boot from MMC:
> -------------
> U-Boot SPL 2017.03-33690-ga80e4f6-dirty (Mar 30 2017 - 00:40:29)
> Trying to boot from MMC1
>
> U-Boot 2017.03-33690-ga80e4f6-dirty (Mar 30 2017 - 00:40:29 +0530)
>
> CPU:   Freescale i.MX6QP rev1.0 996 MHz (running at 792 MHz)
> CPU:   Automotive temperature grade (-40C to 125C) at 29C
> Reset cause: POR
> Model: Freescale i.MX6 Quad Plus SABRE Smart Device Board
> Board: MX6-SabreSD
> I2C:   ready
> DRAM:  1 GiB
> PMIC:  PFUZE100 ID=0x10
> MMC:   FSL_SDHC: 0, FSL_SDHC: 1, FSL_SDHC: 2
> *** Warning - bad CRC, using default environment
>
> gpio@020a4000: dir_output: error: gpio GPIO3_19 not reserved
> gpio@020a4000: set_value: error: gpio GPIO3_19 not reserved
> gpio@020b4000: dir_output: error: gpio GPIO7_12 not reserved
> gpio@020b4000: set_value: error: gpio GPIO7_12 not reserved

Do you plan to fix these errors?
Jagan Teki April 4, 2017, 5:39 a.m. UTC | #2 
On Tue, Apr 4, 2017 at 12:46 AM, Fabio Estevam <festevam@gmail.com> wrote:
> On Mon, Apr 3, 2017 at 10:53 AM, Jagan Teki <jagan@openedev.com> wrote:
>> From: Jagan Teki <jagan@amarulasolutions.com>
>>
>> Add initial dts support for i.MX6 Quad Plus Sabresd board.
>>
>> Boot from MMC:
>> -------------
>> U-Boot SPL 2017.03-33690-ga80e4f6-dirty (Mar 30 2017 - 00:40:29)
>> Trying to boot from MMC1
>>
>> U-Boot 2017.03-33690-ga80e4f6-dirty (Mar 30 2017 - 00:40:29 +0530)
>>
>> CPU:   Freescale i.MX6QP rev1.0 996 MHz (running at 792 MHz)
>> CPU:   Automotive temperature grade (-40C to 125C) at 29C
>> Reset cause: POR
>> Model: Freescale i.MX6 Quad Plus SABRE Smart Device Board
>> Board: MX6-SabreSD
>> I2C:   ready
>> DRAM:  1 GiB
>> PMIC:  PFUZE100 ID=0x10
>> MMC:   FSL_SDHC: 0, FSL_SDHC: 1, FSL_SDHC: 2
>> *** Warning - bad CRC, using default environment
>>
>> gpio@020a4000: dir_output: error: gpio GPIO3_19 not reserved
>> gpio@020a4000: set_value: error: gpio GPIO3_19 not reserved
>> gpio@020b4000: dir_output: error: gpio GPIO7_12 not reserved
>> gpio@020b4000: set_value: error: gpio GPIO7_12 not reserved
>
> Do you plan to fix these errors?

Yes the subsequent patches are fixing these, see 0000-cover-letter for
final u-boot print.

thanks!
Peng Fan April 6, 2017, 1:59 a.m. UTC | #3 
On Mon, Apr 03, 2017 at 07:23:14PM +0530, Jagan Teki wrote:
>From: Jagan Teki <jagan@amarulasolutions.com>
>
>Add initial dts support for i.MX6 Quad Plus Sabresd board.
>
>Boot from MMC:
>-------------
>U-Boot SPL 2017.03-33690-ga80e4f6-dirty (Mar 30 2017 - 00:40:29)
>Trying to boot from MMC1
>
>U-Boot 2017.03-33690-ga80e4f6-dirty (Mar 30 2017 - 00:40:29 +0530)
>
>CPU:   Freescale i.MX6QP rev1.0 996 MHz (running at 792 MHz)
>CPU:   Automotive temperature grade (-40C to 125C) at 29C
>Reset cause: POR
>Model: Freescale i.MX6 Quad Plus SABRE Smart Device Board
>Board: MX6-SabreSD
>I2C:   ready
>DRAM:  1 GiB
>PMIC:  PFUZE100 ID=0x10
>MMC:   FSL_SDHC: 0, FSL_SDHC: 1, FSL_SDHC: 2
>*** Warning - bad CRC, using default environment
>
>gpio@020a4000: dir_output: error: gpio GPIO3_19 not reserved
>gpio@020a4000: set_value: error: gpio GPIO3_19 not reserved
>gpio@020b4000: dir_output: error: gpio GPIO7_12 not reserved
>gpio@020b4000: set_value: error: gpio GPIO7_12 not reserved
>PCI:   pcie phy link never came up
>No panel detected: default to Hannstar-XGA
>gpio@0209c000: dir_output: error: gpio GPIO1_21 not reserved
>Display: Hannstar-XGA (1024x768)
>In:    serial
>Out:   serial
>Err:   serial
>Net:   gpio@0209c000: dir_output: error: gpio GPIO1_25 not reserved
>gpio@0209c000: set_value: error: gpio GPIO1_25 not reserved
>FEC [PRIME]
>Hit any key to stop autoboot:  0
>=>
>
>Cc: Stefano Babic <sbabic@denx.de>
>Cc: Fabio Estevam <fabio.estevam@nxp.com>
>Cc: Michael Trimarchi <michael@amarulasolutions.com>
>Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
>---
> board/freescale/mx6sabresd/MAINTAINERS |  1 +
> configs/imx6qp_sabresd_defconfig       | 60 ++++++++++++++++++++++++++++++++++

Could this be renamed to imx6qp_sabresd_spl_defconfig?

Thanks,
Peng.
Jagan Teki April 6, 2017, 4:05 a.m. UTC | #4 
On Thu, Apr 6, 2017 at 7:29 AM, Peng Fan <van.freenix@gmail.com> wrote:
> On Mon, Apr 03, 2017 at 07:23:14PM +0530, Jagan Teki wrote:
>>From: Jagan Teki <jagan@amarulasolutions.com>
>>
>>Add initial dts support for i.MX6 Quad Plus Sabresd board.
>>
>>Boot from MMC:
>>-------------
>>U-Boot SPL 2017.03-33690-ga80e4f6-dirty (Mar 30 2017 - 00:40:29)
>>Trying to boot from MMC1
>>
>>U-Boot 2017.03-33690-ga80e4f6-dirty (Mar 30 2017 - 00:40:29 +0530)
>>
>>CPU:   Freescale i.MX6QP rev1.0 996 MHz (running at 792 MHz)
>>CPU:   Automotive temperature grade (-40C to 125C) at 29C
>>Reset cause: POR
>>Model: Freescale i.MX6 Quad Plus SABRE Smart Device Board
>>Board: MX6-SabreSD
>>I2C:   ready
>>DRAM:  1 GiB
>>PMIC:  PFUZE100 ID=0x10
>>MMC:   FSL_SDHC: 0, FSL_SDHC: 1, FSL_SDHC: 2
>>*** Warning - bad CRC, using default environment
>>
>>gpio@020a4000: dir_output: error: gpio GPIO3_19 not reserved
>>gpio@020a4000: set_value: error: gpio GPIO3_19 not reserved
>>gpio@020b4000: dir_output: error: gpio GPIO7_12 not reserved
>>gpio@020b4000: set_value: error: gpio GPIO7_12 not reserved
>>PCI:   pcie phy link never came up
>>No panel detected: default to Hannstar-XGA
>>gpio@0209c000: dir_output: error: gpio GPIO1_21 not reserved
>>Display: Hannstar-XGA (1024x768)
>>In:    serial
>>Out:   serial
>>Err:   serial
>>Net:   gpio@0209c000: dir_output: error: gpio GPIO1_25 not reserved
>>gpio@0209c000: set_value: error: gpio GPIO1_25 not reserved
>>FEC [PRIME]
>>Hit any key to stop autoboot:  0
>>=>
>>
>>Cc: Stefano Babic <sbabic@denx.de>
>>Cc: Fabio Estevam <fabio.estevam@nxp.com>
>>Cc: Michael Trimarchi <michael@amarulasolutions.com>
>>Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
>>---
>> board/freescale/mx6sabresd/MAINTAINERS |  1 +
>> configs/imx6qp_sabresd_defconfig       | 60 ++++++++++++++++++++++++++++++++++
>
> Could this be renamed to imx6qp_sabresd_spl_defconfig?

See my 28/29 patch comment, We are not keeping non-spl so there is no
need to explicitly specify the name _spl

thanks!
diff mbox

Patch

diff --git a/board/freescale/mx6sabresd/MAINTAINERS b/board/freescale/mx6sabresd/MAINTAINERS
index 434548a..40507f8 100644
--- a/board/freescale/mx6sabresd/MAINTAINERS
+++ b/board/freescale/mx6sabresd/MAINTAINERS
@@ -7,3 +7,4 @@  F:	configs/mx6dlsabresd_defconfig
 F:	configs/mx6qsabresd_defconfig
 F:	configs/mx6sabresd_spl_defconfig
 F:	configs/imx6q_sabresd_defconfig
+F:	configs/imx6qp_sabresd_defconfig
diff --git a/configs/imx6qp_sabresd_defconfig b/configs/imx6qp_sabresd_defconfig
new file mode 100644
index 0000000..73fbdb2
--- /dev/null
+++ b/configs/imx6qp_sabresd_defconfig
@@ -0,0 +1,60 @@ 
+CONFIG_ARM=y
+CONFIG_ARCH_MX6=y
+CONFIG_SPL_GPIO_SUPPORT=y
+CONFIG_SPL_LIBCOMMON_SUPPORT=y
+CONFIG_SPL_LIBGENERIC_SUPPORT=y
+CONFIG_TARGET_MX6SABRESD=y
+CONFIG_SPL_MMC_SUPPORT=y
+CONFIG_SPL_SERIAL_SUPPORT=y
+CONFIG_SPL_LIBDISK_SUPPORT=y
+CONFIG_SPL_WATCHDOG_SUPPORT=y
+CONFIG_VIDEO=y
+CONFIG_DEFAULT_DEVICE_TREE="imx6qp-sabresd"
+CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=arch/arm/imx-common/spl_sd.cfg,MX6Q"
+CONFIG_BOOTDELAY=3
+CONFIG_DEFAULT_FDT_FILE="imx6qp-sabresd.dtb"
+# CONFIG_CONSOLE_MUX is not set
+CONFIG_SYS_CONSOLE_IS_IN_ENV=y
+CONFIG_SYS_CONSOLE_OVERWRITE_ROUTINE=y
+CONFIG_SPL=y
+CONFIG_SPL_EXT_SUPPORT=y
+CONFIG_SPL_I2C_SUPPORT=y
+CONFIG_SPL_OS_BOOT=y
+CONFIG_HUSH_PARSER=y
+CONFIG_CMD_BOOTZ=y
+# CONFIG_CMD_IMLS is not set
+# CONFIG_CMD_FLASH is not set
+CONFIG_CMD_MMC=y
+CONFIG_CMD_SF=y
+CONFIG_CMD_I2C=y
+CONFIG_CMD_USB=y
+CONFIG_CMD_GPIO=y
+CONFIG_CMD_DHCP=y
+CONFIG_CMD_MII=y
+CONFIG_CMD_PING=y
+CONFIG_CMD_CACHE=y
+CONFIG_CMD_EXT2=y
+CONFIG_CMD_EXT4=y
+CONFIG_CMD_EXT4_WRITE=y
+CONFIG_CMD_FAT=y
+CONFIG_CMD_FS_GENERIC=y
+CONFIG_SPI_FLASH=y
+CONFIG_SPI_FLASH_STMICRO=y
+CONFIG_PCI=y
+CONFIG_USB=y
+CONFIG_USB_STORAGE=y
+CONFIG_USB_GADGET=y
+CONFIG_CI_UDC=y
+CONFIG_USB_GADGET_DOWNLOAD=y
+CONFIG_G_DNL_MANUFACTURER="FSL"
+CONFIG_G_DNL_VENDOR_NUM=0x0525
+CONFIG_G_DNL_PRODUCT_NUM=0xa4a5
+# CONFIG_VIDEO_SW_CURSOR is not set
+CONFIG_OF_LIBFDT=y
+CONFIG_OF_CONTROL=y
+CONFIG_DM_GPIO=y
+CONFIG_DM_MMC=y
+# CONFIG_BLK is not set
+# CONFIG_DM_MMC_OPS is not set
+CONFIG_PINCTRL=y
+CONFIG_PINCTRL_IMX6=y