From patchwork Mon Apr 3 13:47:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartlomiej Zolnierkiewicz X-Patchwork-Id: 746457 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3vxYNL5wtwz9s7y for ; Mon, 3 Apr 2017 23:48:34 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752055AbdDCNrr (ORCPT ); Mon, 3 Apr 2017 09:47:47 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:48876 "EHLO epoutp01.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753366AbdDCNrn (ORCPT ); Mon, 3 Apr 2017 09:47:43 -0400 Received: from epcas1p2.samsung.com (unknown [182.195.41.46]) by epoutp01.samsung.com (KnoxPortal) with ESMTP id 20170403134740epoutp018680714440d57193ec90202a71d2cae4~x50rxE5M-0318203182epoutp018; Mon, 3 Apr 2017 13:47:40 +0000 (GMT) Received: from epsmges1p2.samsung.com (unknown [182.195.42.54]) by epcas1p1.samsung.com (KnoxPortal) with ESMTP id 20170403134739epcas1p180cc70b7a512211386a9659417e29fac~x50qpx-NS0881008810epcas1p1j; Mon, 3 Apr 2017 13:47:39 +0000 (GMT) Received: from epcas1p4.samsung.com ( [182.195.41.48]) by epsmges1p2.samsung.com (Symantec Messaging Gateway) with SMTP id 67.7D.11213.B7252E85; Mon, 3 Apr 2017 22:47:39 +0900 (KST) Received: from epcpsbgm1new.samsung.com (u26.gpu120.samsung.co.kr [203.254.230.26]) by epcas1p4.samsung.com (KnoxPortal) with ESMTP id 20170403134738epcas1p43be0c60fa93d85364914fc6de0cee3e2~x50p_dEh42841928419epcas1p4x; Mon, 3 Apr 2017 13:47:38 +0000 (GMT) X-AuditID: b6c32a36-f79446d000002bcd-b6-58e2527bfdf6 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1new.samsung.com (EPCPMTA) with SMTP id 3E.17.05715.A7252E85; Mon, 3 Apr 2017 22:47:38 +0900 (KST) Received: from AMDC3058.DIGITAL.local ([106.120.53.102]) by mmp2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0ONU003916AWJW90@mmp2.samsung.com>; Mon, 03 Apr 2017 22:47:38 +0900 (KST) From: Bartlomiej Zolnierkiewicz To: Thierry Reding , Jean Delvare , Guenter Roeck , Kamil Debski Cc: Tomasz Figa , linux-pwm@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, b.zolnierkie@samsung.com Subject: [PATCH 2/3] pwm: pwm-samsung: fix suspend/resume support Date: Mon, 03 Apr 2017 15:47:05 +0200 Message-id: <1491227226-12972-3-git-send-email-b.zolnierkie@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1491227226-12972-1-git-send-email-b.zolnierkie@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrAIsWRmVeSWpSXmKPExsWy7bCmgW510KMIg/3rZCw2zljPanF2QqDF zBPtrBbtr7cyWlzeNYfN4u7dVYwWM87vY7J4svAMk8XPXfNYLFbt+sPowOWxc9Zddo+d3xvY Pfq2rGL0WL/lKovH501yHleONLIHsEVx2aSk5mSWpRbp2yVwZcze3MdUsECvou3GGpYGxqOq XYycHBICJhJNJ4+zQNhiEhfurWfrYuTiEBLYwSgxrecCE4TTziSxdPY3dpiOIy1rWSEScxgl 1n28xgjh/GKUaJ+1AqyKTcBKYmL7KrCEiMB0RonzV/YxgySYBfYxSrw7VwJiCws4SkzvBxnF ycEioCrR/HcD2CG8Ah4Sa288ZoJYJydx8thksBpOAU+J9xNXMYMMlRDoZ5fY0H0AyOEAcmQl Nh1ghqh3kZg95Q1Ur7DEq+NboM6Wllj17xZUHOig7b8lIOZsZpRYtXsCVJG1xOHjF1khDuWT ePe1hxViPq9ER5sQRImHxO7J36EB5iixr3sJEzwo5h74zzKBUWYBI8MqRrHUguLc9NRiwwIj veLE3OLSvHS95PzcTYzgeNcy28G46JzPIUYBDkYlHt4FTo8ihFgTy4orcw8xSnAwK4nwTvAD CvGmJFZWpRblxxeV5qQWH2KU5mBREucVXX8tQkggPbEkNTs1tSC1CCbLxMEp1cB4OC9Q1r82 5un6RhnDS5JZsi+Czz34wXCtl3X66pZryrNvV7BPXR7NbPfl7YLXM8tvbznuuv7u7D2P1zCZ XzkrE72seKfM62dnOwKPPd5Vt874l5ZbduwEs3MSFi4S7kuV3Tv8ynj8tsdv2nT0ov6m7qX1 O9fKeMb8fvXvDa+YkLb48htXJl99psRSnJFoqMVcVJwIAN8DTEvzAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpkkeLIzCtJLcpLzFFi42I5/e+xoG5V0KMIg8NfdCw2zljPanF2QqDF zBPtrBbtr7cyWlzeNYfN4u7dVYwWM87vY7J4svAMk8XPXfNYLFbt+sPowOWxc9Zddo+d3xvY Pfq2rGL0WL/lKovH501yHleONLIHsEW52WSkJqakFimk5iXnp2TmpdsqhYa46VooKeQl5qba KkXo+oYEKSmUJeaUAnlGBmjAwTnAPVhJ3y7BLWP25j6mggV6FW031rA0MB5V7WLk5JAQMJE4 0rKWFcIWk7hwbz0biC0kMItR4sFLky5GLiD7F6PEq8af7CAJNgEriYntqxhBEiIC0xklZszc zgriMAvsY5RY3TWFGaRKWMBRYno/xFgWAVWJ5r8bWEBsXgEPibU3HjNBrJOTOHlsMlgNp4Cn xPuJq5ghVntIbGqexDqBkXcBI8MqRonUguSC4qT0XMO81HK94sTc4tK8dL3k/NxNjODgfya1 g/HgLvdDjAIcjEo8vAucHkUIsSaWFVfmHmKU4GBWEuGd4AcU4k1JrKxKLcqPLyrNSS0+xGgK dNhEZinR5HxgZOaVxBuamJuYGxtYmFtamhgpifM2zn4WLiSQnliSmp2aWpBaBNPHxMEp1cDI nrVkccFxwRep98N4tDOO3l9+S8Y84N0a55W2LHLXDhitb7gw9dplEZe9/1zvrmM7F2nR/1Co 8Iffu2LPd72e80u6l3Kdfde0mP+xx0czV1/hRXfiXPSWzvrFxah3gev0NkPTTZMPKC6c9WoR a9zmJxKzjR7H/Vr+elPTRvM/5a/lHGIYpoUxK7EUZyQaajEXFScCABrXa7uUAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170403134738epcas1p43be0c60fa93d85364914fc6de0cee3e2 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-CMS-RootMailID: 20170403134738epcas1p43be0c60fa93d85364914fc6de0cee3e2 X-RootMTR: 20170403134738epcas1p43be0c60fa93d85364914fc6de0cee3e2 References: <1491227226-12972-1-git-send-email-b.zolnierkie@samsung.com> Sender: linux-pwm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org Fix suspend/resume support: - add disabled_mask to struct samsung_pwm_chip to track PWM disabled state information in pwm_samsung_{disable,enable}() - rename pwm_samsung_config() to __pwm_samsung_config() and add extra force_period parameter to be used during resume (to force tin_ns and tcnt recalculation) - add pwm_samsung_config() wrapper for preserving old behavior - properly restore PWM configuration in pwm_samsung_resume() - remove no longer needed pwm_samsung_suspend() - update Copyrights Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/pwm/pwm-samsung.c | 67 +++++++++++++++++++++++++---------------------- 1 file changed, 35 insertions(+), 32 deletions(-) diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c index 9ea7638..aeb39b6 100644 --- a/drivers/pwm/pwm-samsung.c +++ b/drivers/pwm/pwm-samsung.c @@ -3,6 +3,7 @@ * Copyright (c) 2008 Simtec Electronics * Ben Dooks , * Copyright (c) 2013 Tomasz Figa + * Copyright (c) 2017 Samsung Electronics Co., Ltd. * * PWM driver for Samsung SoCs * @@ -74,6 +75,7 @@ struct samsung_pwm_channel { * @chip: generic PWM chip * @variant: local copy of hardware variant data * @inverter_mask: inverter status for all channels - one bit per channel + * @disabled_mask: disabled status for all channels - one bit per channel * @base: base address of mapped PWM registers * @base_clk: base clock used to drive the timers * @tclk0: external clock 0 (can be ERR_PTR if not present) @@ -83,6 +85,7 @@ struct samsung_pwm_chip { struct pwm_chip chip; struct samsung_pwm_variant variant; u8 inverter_mask; + u8 disabled_mask; void __iomem *base; struct clk *base_clk; @@ -257,6 +260,8 @@ static int pwm_samsung_enable(struct pwm_chip *chip, struct pwm_device *pwm) tcon |= TCON_START(tcon_chan) | TCON_AUTORELOAD(tcon_chan); writel(tcon, our_chip->base + REG_TCON); + our_chip->disabled_mask &= ~BIT(pwm->hwpwm); + spin_unlock_irqrestore(&samsung_pwm_lock, flags); return 0; @@ -275,6 +280,8 @@ static void pwm_samsung_disable(struct pwm_chip *chip, struct pwm_device *pwm) tcon &= ~TCON_AUTORELOAD(tcon_chan); writel(tcon, our_chip->base + REG_TCON); + our_chip->disabled_mask |= BIT(pwm->hwpwm); + spin_unlock_irqrestore(&samsung_pwm_lock, flags); } @@ -297,8 +304,8 @@ static void pwm_samsung_manual_update(struct samsung_pwm_chip *chip, spin_unlock_irqrestore(&samsung_pwm_lock, flags); } -static int pwm_samsung_config(struct pwm_chip *chip, struct pwm_device *pwm, - int duty_ns, int period_ns) +static int __pwm_samsung_config(struct pwm_chip *chip, struct pwm_device *pwm, + int duty_ns, int period_ns, bool force_period) { struct samsung_pwm_chip *our_chip = to_samsung_pwm_chip(chip); struct samsung_pwm_channel *chan = pwm_get_chip_data(pwm); @@ -319,7 +326,7 @@ static int pwm_samsung_config(struct pwm_chip *chip, struct pwm_device *pwm, ++tcnt; /* Check to see if we are changing the clock rate of the PWM. */ - if (chan->period_ns != period_ns) { + if (chan->period_ns != period_ns || force_period) { unsigned long tin_rate; u32 period; @@ -378,6 +385,12 @@ static int pwm_samsung_config(struct pwm_chip *chip, struct pwm_device *pwm, return 0; } +static int pwm_samsung_config(struct pwm_chip *chip, struct pwm_device *pwm, + int duty_ns, int period_ns) +{ + return __pwm_samsung_config(chip, pwm, duty_ns, period_ns, false); +} + static void pwm_samsung_set_invert(struct samsung_pwm_chip *chip, unsigned int channel, bool invert) { @@ -589,51 +602,41 @@ static int pwm_samsung_remove(struct platform_device *pdev) } #ifdef CONFIG_PM_SLEEP -static int pwm_samsung_suspend(struct device *dev) +static int pwm_samsung_resume(struct device *dev) { - struct samsung_pwm_chip *chip = dev_get_drvdata(dev); + struct samsung_pwm_chip *our_chip = dev_get_drvdata(dev); + struct pwm_chip *chip = &our_chip->chip; unsigned int i; - /* - * No one preserves these values during suspend so reset them. - * Otherwise driver leaves PWM unconfigured if same values are - * passed to pwm_config() next time. - */ - for (i = 0; i < SAMSUNG_PWM_NUM; ++i) { - struct pwm_device *pwm = &chip->chip.pwms[i]; + for (i = 0; i < SAMSUNG_PWM_NUM; i++) { + struct pwm_device *pwm = &chip->pwms[i]; struct samsung_pwm_channel *chan = pwm_get_chip_data(pwm); if (!chan) continue; - chan->period_ns = 0; - chan->duty_ns = 0; - } - - return 0; -} + if (our_chip->variant.output_mask & BIT(i)) + pwm_samsung_set_invert(our_chip, i, + our_chip->inverter_mask & BIT(i)); -static int pwm_samsung_resume(struct device *dev) -{ - struct samsung_pwm_chip *chip = dev_get_drvdata(dev); - unsigned int chan; + if (chan->period_ns) { + __pwm_samsung_config(chip, pwm, chan->duty_ns, + chan->period_ns, true); + /* needed to make PWM disable work on Odroid-XU3 */ + pwm_samsung_manual_update(chip, pwm); + } - /* - * Inverter setting must be preserved across suspend/resume - * as nobody really seems to configure it more than once. - */ - for (chan = 0; chan < SAMSUNG_PWM_NUM; ++chan) { - if (chip->variant.output_mask & BIT(chan)) - pwm_samsung_set_invert(chip, chan, - chip->inverter_mask & BIT(chan)); + if (our_chip->disabled_mask & BIT(i)) + pwm_samsung_disable(chip, pwm); + else + pwm_samsung_enable(chip, pwm); } return 0; } #endif -static SIMPLE_DEV_PM_OPS(pwm_samsung_pm_ops, pwm_samsung_suspend, - pwm_samsung_resume); +static SIMPLE_DEV_PM_OPS(pwm_samsung_pm_ops, NULL, pwm_samsung_resume); static struct platform_driver pwm_samsung_driver = { .driver = {