| Message ID | 20170402100535.GA18340@amd (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 70a92003de599ff2f15815b3d9c4459411ca4ebf |
| Headers | show |
On Sun 2017-04-02 12:05:36, Pavel Machek wrote: > Fix overlapping NAND partitions. > > Signed-off-by: Pavel Machek <pavel@ucw.cz> Ping? Two partitions at same place are bad news... Pavel > diff --git a/arch/powerpc/boot/dts/sequoia.dts b/arch/powerpc/boot/dts/sequoia.dts > index b1d3292..e41b88a 100644 > --- a/arch/powerpc/boot/dts/sequoia.dts > +++ b/arch/powerpc/boot/dts/sequoia.dts > @@ -229,7 +229,7 @@ > }; > partition@84000 { > label = "user"; > - reg = <0x00000000 0x01f7c000>; > + reg = <0x00084000 0x01f7c000>; > }; > }; > }; > > >
On Wed, 17 May 2017 14:06:13 +0200 Pavel Machek <pavel@denx.de> wrote: > On Sun 2017-04-02 12:05:36, Pavel Machek wrote: > > Fix overlapping NAND partitions. > > > > Signed-off-by: Pavel Machek <pavel@ucw.cz> > > Ping? Two partitions at same place are bad news... Please expand on "bad news"? What are the runtime effects of this change? Decisions about which kernel(s) to patch depend on this info.
On Wed 2017-05-17 14:37:17, Andrew Morton wrote: > On Wed, 17 May 2017 14:06:13 +0200 Pavel Machek <pavel@denx.de> wrote: > > > On Sun 2017-04-02 12:05:36, Pavel Machek wrote: > > > Fix overlapping NAND partitions. > > > > > > Signed-off-by: Pavel Machek <pavel@ucw.cz> > > > > Ping? Two partitions at same place are bad news... > > Please expand on "bad news"? What are the runtime effects of this > change? Decisions about which kernel(s) to patch depend on this info. Well... two partitions at same place. If you use one, you will corrupt information on the other one. OTOH this moves partition around (so that they don't overlap) so it is probably not stable candidate. I guess this is not huge issue; people using these boards probably have custom dts changes, anyway... Best regards, Pavel
Pavel Machek <pavel@denx.de> writes: > On Wed 2017-05-17 14:37:17, Andrew Morton wrote: >> On Wed, 17 May 2017 14:06:13 +0200 Pavel Machek <pavel@denx.de> wrote: >> >> > On Sun 2017-04-02 12:05:36, Pavel Machek wrote: >> > > Fix overlapping NAND partitions. >> > > >> > > Signed-off-by: Pavel Machek <pavel@ucw.cz> >> > >> > Ping? Two partitions at same place are bad news... >> >> Please expand on "bad news"? What are the runtime effects of this >> change? Decisions about which kernel(s) to patch depend on this info. > > Well... two partitions at same place. If you use one, you will corrupt > information on the other one. > > OTOH this moves partition around (so that they don't overlap) so it is > probably not stable candidate. > > I guess this is not huge issue; people using these boards probably > have custom dts changes, anyway... Or no one's even using it anymore. I can take this via powerpc, I won't mark it for stable etc. cheers
Hi! > > Well... two partitions at same place. If you use one, you will corrupt > > information on the other one. > > > > OTOH this moves partition around (so that they don't overlap) so it is > > probably not stable candidate. > > > > I guess this is not huge issue; people using these boards probably > > have custom dts changes, anyway... > > Or no one's even using it anymore. > > I can take this via powerpc, I won't mark it for stable etc. That sounds good. Thanks, Pavel
Michael Ellerman <mpe@ellerman.id.au> writes: > Pavel Machek <pavel@denx.de> writes: > >> On Wed 2017-05-17 14:37:17, Andrew Morton wrote: >>> On Wed, 17 May 2017 14:06:13 +0200 Pavel Machek <pavel@denx.de> wrote: >>> >>> > On Sun 2017-04-02 12:05:36, Pavel Machek wrote: >>> > > Fix overlapping NAND partitions. >>> > > >>> > > Signed-off-by: Pavel Machek <pavel@ucw.cz> >>> > >>> > Ping? Two partitions at same place are bad news... >>> >>> Please expand on "bad news"? What are the runtime effects of this >>> change? Decisions about which kernel(s) to patch depend on this info. >> >> Well... two partitions at same place. If you use one, you will corrupt >> information on the other one. >> >> OTOH this moves partition around (so that they don't overlap) so it is >> probably not stable candidate. >> >> I guess this is not huge issue; people using these boards probably >> have custom dts changes, anyway... > > Or no one's even using it anymore. > > I can take this via powerpc, I won't mark it for stable etc. It became: Author: Pavel Machek <pavel@denx.de> powerpc/sequoia: Fix NAND partitions not to overlap Currently the DTS defines two partitions at the same addresses, if you use one, you will corrupt information on the other one. Fix it by shifting the second partition. Signed-off-by: Pavel Machek <pavel@ucw.cz> [mpe: Reconstruct change log from email thread] Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Minor nit, your From: address doesn't match your Signed-off-by: address, which trips my "check patch is signed-off-by author" script. I can just ignore it, but I think it's preferable if they match. cheers
Hi! > >>> > > Signed-off-by: Pavel Machek <pavel@ucw.cz> > >>> > > >>> > Ping? Two partitions at same place are bad news... > >>> > >>> Please expand on "bad news"? What are the runtime effects of this > >>> change? Decisions about which kernel(s) to patch depend on this info. > >> > >> Well... two partitions at same place. If you use one, you will corrupt > >> information on the other one. > >> > >> OTOH this moves partition around (so that they don't overlap) so it is > >> probably not stable candidate. > >> > >> I guess this is not huge issue; people using these boards probably > >> have custom dts changes, anyway... > > > > Or no one's even using it anymore. > > > > I can take this via powerpc, I won't mark it for stable etc. > > It became: > > Author: Pavel Machek <pavel@denx.de> > > powerpc/sequoia: Fix NAND partitions not to overlap > > Currently the DTS defines two partitions at the same addresses, if you > use one, you will corrupt information on the other one. Fix it by > shifting the second partition. > > Signed-off-by: Pavel Machek <pavel@ucw.cz> > [mpe: Reconstruct change log from email thread] > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> > > > Minor nit, your From: address doesn't match your Signed-off-by: address, > which trips my "check patch is signed-off-by author" script. I can > just ignore it, but I think it's preferable if they match. Sorry about that (I have automatic scripts changing From:). It is still me, but I guess denx should get the credit here, so you can use. Signed-off-by: Pavel Machek <pavel@denx.de> Thanks, Pavel
Pavel Machek <pavel@denx.de> writes: > Hi! > >> >>> > > Signed-off-by: Pavel Machek <pavel@ucw.cz> >> >>> > >> >>> > Ping? Two partitions at same place are bad news... >> >>> >> >>> Please expand on "bad news"? What are the runtime effects of this >> >>> change? Decisions about which kernel(s) to patch depend on this info. >> >> >> >> Well... two partitions at same place. If you use one, you will corrupt >> >> information on the other one. >> >> >> >> OTOH this moves partition around (so that they don't overlap) so it is >> >> probably not stable candidate. >> >> >> >> I guess this is not huge issue; people using these boards probably >> >> have custom dts changes, anyway... >> > >> > Or no one's even using it anymore. >> > >> > I can take this via powerpc, I won't mark it for stable etc. >> >> It became: >> >> Author: Pavel Machek <pavel@denx.de> >> >> powerpc/sequoia: Fix NAND partitions not to overlap >> >> Currently the DTS defines two partitions at the same addresses, if you >> use one, you will corrupt information on the other one. Fix it by >> shifting the second partition. >> >> Signed-off-by: Pavel Machek <pavel@ucw.cz> >> [mpe: Reconstruct change log from email thread] >> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> >> >> >> Minor nit, your From: address doesn't match your Signed-off-by: address, >> which trips my "check patch is signed-off-by author" script. I can >> just ignore it, but I think it's preferable if they match. > > Sorry about that (I have automatic scripts changing From:). It is > still me, but I guess denx should get the credit here, so you can use. > > Signed-off-by: Pavel Machek <pavel@denx.de> Sure, done. cheers
On Sun, 2017-04-02 at 10:05:36 UTC, Pavel Machek wrote: > Fix overlapping NAND partitions. > > Signed-off-by: Pavel Machek <pavel@ucw.cz> Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/70a92003de599ff2f15815b3d9c445 cheers
diff --git a/arch/powerpc/boot/dts/sequoia.dts b/arch/powerpc/boot/dts/sequoia.dts index b1d3292..e41b88a 100644 --- a/arch/powerpc/boot/dts/sequoia.dts +++ b/arch/powerpc/boot/dts/sequoia.dts @@ -229,7 +229,7 @@ }; partition@84000 { label = "user"; - reg = <0x00000000 0x01f7c000>; + reg = <0x00084000 0x01f7c000>; }; }; };
Fix overlapping NAND partitions. Signed-off-by: Pavel Machek <pavel@ucw.cz>