Message ID | 20170402081327.2195-3-bernd.kuhls@t-online.de |
---|---|
State | Superseded |
Headers | show |
Hello, On Sun, 2 Apr 2017 10:13:27 +0200, Bernd Kuhls wrote: > The utils provided by this package were formerly packaged with libva. > Libva contained a patch not to compile mpeg2vldemo to reduce > dependencies by avoiding C++, this patch is not moved to this package. > > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> > --- > package/Config.in | 1 + > package/libva-utils/Config.in | 15 +++++++++++++++ > package/libva-utils/libva-utils.hash | 4 ++++ > package/libva-utils/libva-utils.mk | 14 ++++++++++++++ Entry to DEVELOPERS file is missing. > diff --git a/package/Config.in b/package/Config.in > index d6d134d0c..364766e37 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -1049,6 +1049,7 @@ menu "Graphics" > source "package/libsvgtiny/Config.in" > source "package/libva/Config.in" > source "package/libva-intel-driver/Config.in" > + source "package/libva-utils/Config.in" Does it really makes sense to have this package in Libraries->Graphics when it is in fact not a library at all? > diff --git a/package/libva-utils/Config.in b/package/libva-utils/Config.in > new file mode 100644 > index 000000000..89615cad3 > --- /dev/null > +++ b/package/libva-utils/Config.in > @@ -0,0 +1,15 @@ > +config BR2_PACKAGE_LIBVA_UTILS > + bool "libva-utils" > + select BR2_PACKAGE_LIBVA > + depends on BR2_INSTALL_LIBSTDCPP > + depends on BR2_TOOLCHAIN_HAS_THREADS # libva > + depends on !BR2_STATIC_LIBS # libva Perhaps this can be summarized as: depends on BR2_PACKAGE_LIBVA indeed, someone wanting the libva tests will surely realize that he needs to enable libva in the first place, no? Thanks! Thomas
On 02-04-17 23:46, Thomas Petazzoni wrote: > Hello, > > On Sun, 2 Apr 2017 10:13:27 +0200, Bernd Kuhls wrote: >> The utils provided by this package were formerly packaged with libva. >> Libva contained a patch not to compile mpeg2vldemo to reduce >> dependencies by avoiding C++, this patch is not moved to this package. >> >> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> >> --- >> package/Config.in | 1 + >> package/libva-utils/Config.in | 15 +++++++++++++++ >> package/libva-utils/libva-utils.hash | 4 ++++ >> package/libva-utils/libva-utils.mk | 14 ++++++++++++++ > > Entry to DEVELOPERS file is missing. > >> diff --git a/package/Config.in b/package/Config.in >> index d6d134d0c..364766e37 100644 >> --- a/package/Config.in >> +++ b/package/Config.in >> @@ -1049,6 +1049,7 @@ menu "Graphics" >> source "package/libsvgtiny/Config.in" >> source "package/libva/Config.in" >> source "package/libva-intel-driver/Config.in" >> + source "package/libva-utils/Config.in" > > Does it really makes sense to have this package in Libraries->Graphics > when it is in fact not a library at all? > >> diff --git a/package/libva-utils/Config.in b/package/libva-utils/Config.in >> new file mode 100644 >> index 000000000..89615cad3 >> --- /dev/null >> +++ b/package/libva-utils/Config.in >> @@ -0,0 +1,15 @@ >> +config BR2_PACKAGE_LIBVA_UTILS >> + bool "libva-utils" >> + select BR2_PACKAGE_LIBVA >> + depends on BR2_INSTALL_LIBSTDCPP >> + depends on BR2_TOOLCHAIN_HAS_THREADS # libva >> + depends on !BR2_STATIC_LIBS # libva > > Perhaps this can be summarized as: > > depends on BR2_PACKAGE_LIBVA > > indeed, someone wanting the libva tests will surely realize that he > needs to enable libva in the first place, no? IMO, if you move the package somewhere else in the menu structure, and then replace the select with a depends, you're really making life difficult for the user because they have to go to two places to select this package. For me, it does make sense to keep the _UTILS in the library menu. I think the typical use case would be that you select libva because you know you'll need it, then you see the menu entry for the _UTILS and realize that a test program would be convenient. By the way, Bernd, the help text says "Libva-utils is a collection of tests", so would libva-tests (or perhaps libva-demos" be a more appropriate name? Regards, Arnout > > Thanks! > > Thomas >
diff --git a/package/Config.in b/package/Config.in index d6d134d0c..364766e37 100644 --- a/package/Config.in +++ b/package/Config.in @@ -1049,6 +1049,7 @@ menu "Graphics" source "package/libsvgtiny/Config.in" source "package/libva/Config.in" source "package/libva-intel-driver/Config.in" + source "package/libva-utils/Config.in" source "package/libvdpau/Config.in" source "package/libvips/Config.in" source "package/menu-cache/Config.in" diff --git a/package/libva-utils/Config.in b/package/libva-utils/Config.in new file mode 100644 index 000000000..89615cad3 --- /dev/null +++ b/package/libva-utils/Config.in @@ -0,0 +1,15 @@ +config BR2_PACKAGE_LIBVA_UTILS + bool "libva-utils" + select BR2_PACKAGE_LIBVA + depends on BR2_INSTALL_LIBSTDCPP + depends on BR2_TOOLCHAIN_HAS_THREADS # libva + depends on !BR2_STATIC_LIBS # libva + help + Libva-utils is a collection of tests for VA-API (Video + Acceleration API) + + https://01.org/linuxmedia/vaapi + +comment "libva-utils needs a toolchain w/ C++, threads, dynamic library" + depends on !BR2_INSTALL_LIBSTDCPP || \ + !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS diff --git a/package/libva-utils/libva-utils.hash b/package/libva-utils/libva-utils.hash new file mode 100644 index 000000000..5a51e86c8 --- /dev/null +++ b/package/libva-utils/libva-utils.hash @@ -0,0 +1,4 @@ +# From https://lists.01.org/pipermail/intel-vaapi-media/2017-March/000017.html +sha1 1cdd17ee0cd5ccf0da2ed85512d87bf1931b2bc1 libva-utils-1.8.0.tar.bz2 +# Locally computed +sha256 ca4574111fd5658d07dcf883fa1a9914b02f77011f51afcc880af1c302afdbcc libva-utils-1.8.0.tar.bz2 diff --git a/package/libva-utils/libva-utils.mk b/package/libva-utils/libva-utils.mk new file mode 100644 index 000000000..e8ed31b2b --- /dev/null +++ b/package/libva-utils/libva-utils.mk @@ -0,0 +1,14 @@ +################################################################################ +# +# libva-utils +# +################################################################################ + +LIBVA_UTILS_VERSION = 1.8.0 +LIBVA_UTILS_SOURCE = libva-utils-$(LIBVA_UTILS_VERSION).tar.bz2 +LIBVA_UTILS_SITE = https://github.com/01org/libva-utils/releases/download/$(LIBVA_UTILS_VERSION) +LIBVA_UTILS_LICENSE = MIT +LIBVA_UTILS_LICENSE_FILES = COPYING +LIBVA_UTILS_DEPENDENCIES = host-pkgconf libva + +$(eval $(autotools-package))
The utils provided by this package were formerly packaged with libva. Libva contained a patch not to compile mpeg2vldemo to reduce dependencies by avoiding C++, this patch is not moved to this package. Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> --- package/Config.in | 1 + package/libva-utils/Config.in | 15 +++++++++++++++ package/libva-utils/libva-utils.hash | 4 ++++ package/libva-utils/libva-utils.mk | 14 ++++++++++++++ 4 files changed, 34 insertions(+) create mode 100644 package/libva-utils/Config.in create mode 100644 package/libva-utils/libva-utils.hash create mode 100644 package/libva-utils/libva-utils.mk