Message ID | 1491057708-15934-2-git-send-email-aneesh.kumar@linux.vnet.ibm.com (mailing list archive) |
---|---|
State | Accepted |
Commit | f7327e0ba3805470cced2acfa053e795362ee41d |
Headers | show |
On Sat, 1 Apr 2017 20:11:48 +0530 "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> wrote: > For a tlbiel with pid, we need to issue tlbiel with set number > encoded. We don't need to do ptesync for each of those. Instead we > need one for the entire tlbiel pid operation. > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> Thanks Aneesh. Acked-by: Anton Blanchard <anton@samba.org> Anton > --- > arch/powerpc/mm/tlb-radix.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/mm/tlb-radix.c b/arch/powerpc/mm/tlb-radix.c > index f3e58bd60d1a..b68b5219cf45 100644 > --- a/arch/powerpc/mm/tlb-radix.c > +++ b/arch/powerpc/mm/tlb-radix.c > @@ -34,10 +34,8 @@ static inline void __tlbiel_pid(unsigned long pid, > int set, prs = 1; /* process scoped */ > r = 1; /* raidx format */ > > - asm volatile("ptesync": : :"memory"); > asm volatile(PPC_TLBIEL(%0, %4, %3, %2, %1) > : : "r"(rb), "i"(r), "i"(prs), "i"(ric), > "r"(rs) : "memory"); > - asm volatile("ptesync": : :"memory"); > } > > /* > @@ -47,9 +45,11 @@ static inline void _tlbiel_pid(unsigned long pid, > unsigned long ric) { > int set; > > + asm volatile("ptesync": : :"memory"); > for (set = 0; set < POWER9_TLB_SETS_RADIX ; set++) { > __tlbiel_pid(pid, set, ric); > } > + asm volatile("ptesync": : :"memory"); > asm volatile(PPC_INVALIDATE_ERAT "; isync" : : :"memory"); > } >
On Sat, 2017-04-01 at 14:41:48 UTC, "Aneesh Kumar K.V" wrote: > For a tlbiel with pid, we need to issue tlbiel with set number encoded. We > don't need to do ptesync for each of those. Instead we need one for the entire > tlbiel pid operation. > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> > Acked-by: Anton Blanchard <anton@samba.org> Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/f7327e0ba3805470cced2acfa053e7 cheers
diff --git a/arch/powerpc/mm/tlb-radix.c b/arch/powerpc/mm/tlb-radix.c index f3e58bd60d1a..b68b5219cf45 100644 --- a/arch/powerpc/mm/tlb-radix.c +++ b/arch/powerpc/mm/tlb-radix.c @@ -34,10 +34,8 @@ static inline void __tlbiel_pid(unsigned long pid, int set, prs = 1; /* process scoped */ r = 1; /* raidx format */ - asm volatile("ptesync": : :"memory"); asm volatile(PPC_TLBIEL(%0, %4, %3, %2, %1) : : "r"(rb), "i"(r), "i"(prs), "i"(ric), "r"(rs) : "memory"); - asm volatile("ptesync": : :"memory"); } /* @@ -47,9 +45,11 @@ static inline void _tlbiel_pid(unsigned long pid, unsigned long ric) { int set; + asm volatile("ptesync": : :"memory"); for (set = 0; set < POWER9_TLB_SETS_RADIX ; set++) { __tlbiel_pid(pid, set, ric); } + asm volatile("ptesync": : :"memory"); asm volatile(PPC_INVALIDATE_ERAT "; isync" : : :"memory"); }