| Message ID | 20170331152723.5794-1-russell@ovn.org |
|---|---|
| State | Accepted |
| Headers | show |
On Fri, Mar 31, 2017 at 11:27:23AM -0400, Russell Bryant wrote: > The RPM build makefile targets are helpful during development and testing, > but I personally almost never want the tests to run when I use them. > Leave tests on by default in the spec file for when the package is built by > distro build systems, but disable it by default in the Makefile targets and > update the documentation accordingly. > > Signed-off-by: Russell Bryant <russell@ovn.org> I'm OK with this.
On Fri, Apr 21, 2017 at 7:01 PM, Ben Pfaff <blp@ovn.org> wrote: > On Fri, Mar 31, 2017 at 11:27:23AM -0400, Russell Bryant wrote: >> The RPM build makefile targets are helpful during development and testing, >> but I personally almost never want the tests to run when I use them. >> Leave tests on by default in the spec file for when the package is built by >> distro build systems, but disable it by default in the Makefile targets and >> update the documentation accordingly. >> >> Signed-off-by: Russell Bryant <russell@ovn.org> > > I'm OK with this. Flavio, Lance, Aaron, have any opinions on this? It's not that big of a deal. I guess I was feeling both slightly annoyed and lazy that day. :-)
> From: "Russell Bryant" <russell@ovn.org> > To: "Ben Pfaff" <blp@ovn.org> > Cc: "ovs dev" <dev@openvswitch.org>, "Flavio Leitner" <fbl@redhat.com>, "Lance Richardson" <lrichard@redhat.com>, > "Aaron Conole" <aconole@redhat.com> > Sent: Thursday, 27 April, 2017 3:04:43 PM > Subject: Re: [ovs-dev] [PATCH] build: Don't run tests in rpm makefile targets. > > On Fri, Apr 21, 2017 at 7:01 PM, Ben Pfaff <blp@ovn.org> wrote: > > On Fri, Mar 31, 2017 at 11:27:23AM -0400, Russell Bryant wrote: > >> The RPM build makefile targets are helpful during development and testing, > >> but I personally almost never want the tests to run when I use them. > >> Leave tests on by default in the spec file for when the package is built > >> by > >> distro build systems, but disable it by default in the Makefile targets > >> and > >> update the documentation accordingly. > >> > >> Signed-off-by: Russell Bryant <russell@ovn.org> > > > > I'm OK with this. > > Flavio, Lance, Aaron, have any opinions on this? It's not that big of > a deal. I guess I was feeling both slightly annoyed and lazy that > day. :-) > Seems fine to me. Acked-by: Lance Richardson <lrichard@redhat.com> > -- > Russell Bryant >
On Thu, Apr 27, 2017 at 03:04:43PM -0400, Russell Bryant wrote: > On Fri, Apr 21, 2017 at 7:01 PM, Ben Pfaff <blp@ovn.org> wrote: > > On Fri, Mar 31, 2017 at 11:27:23AM -0400, Russell Bryant wrote: > >> The RPM build makefile targets are helpful during development and testing, > >> but I personally almost never want the tests to run when I use them. > >> Leave tests on by default in the spec file for when the package is built by > >> distro build systems, but disable it by default in the Makefile targets and > >> update the documentation accordingly. > >> > >> Signed-off-by: Russell Bryant <russell@ovn.org> > > > > I'm OK with this. > > Flavio, Lance, Aaron, have any opinions on this? It's not that big of > a deal. I guess I was feeling both slightly annoyed and lazy that > day. :-) I am also OK.
Lance Richardson <lrichard@redhat.com> writes: >> From: "Russell Bryant" <russell@ovn.org> >> To: "Ben Pfaff" <blp@ovn.org> >> Cc: "ovs dev" <dev@openvswitch.org>, "Flavio Leitner" >> <fbl@redhat.com>, "Lance Richardson" <lrichard@redhat.com>, >> "Aaron Conole" <aconole@redhat.com> >> Sent: Thursday, 27 April, 2017 3:04:43 PM >> Subject: Re: [ovs-dev] [PATCH] build: Don't run tests in rpm makefile targets. >> >> On Fri, Apr 21, 2017 at 7:01 PM, Ben Pfaff <blp@ovn.org> wrote: >> > On Fri, Mar 31, 2017 at 11:27:23AM -0400, Russell Bryant wrote: >> >> The RPM build makefile targets are helpful during development and testing, >> >> but I personally almost never want the tests to run when I use them. >> >> Leave tests on by default in the spec file for when the package is built >> >> by >> >> distro build systems, but disable it by default in the Makefile targets >> >> and >> >> update the documentation accordingly. >> >> >> >> Signed-off-by: Russell Bryant <russell@ovn.org> >> > >> > I'm OK with this. >> >> Flavio, Lance, Aaron, have any opinions on this? It's not that big of >> a deal. I guess I was feeling both slightly annoyed and lazy that >> day. :-) >> > > Seems fine to me. > > Acked-by: Lance Richardson <lrichard@redhat.com> +1 Acked-by: Aaron Conole <aconole@redhat.com> >> -- >> Russell Bryant >>
On Thu, Apr 27, 2017 at 5:26 PM, Aaron Conole <aconole@redhat.com> wrote: > Lance Richardson <lrichard@redhat.com> writes: > >>> From: "Russell Bryant" <russell@ovn.org> >>> To: "Ben Pfaff" <blp@ovn.org> >>> Cc: "ovs dev" <dev@openvswitch.org>, "Flavio Leitner" >>> <fbl@redhat.com>, "Lance Richardson" <lrichard@redhat.com>, >>> "Aaron Conole" <aconole@redhat.com> >>> Sent: Thursday, 27 April, 2017 3:04:43 PM >>> Subject: Re: [ovs-dev] [PATCH] build: Don't run tests in rpm makefile targets. >>> >>> On Fri, Apr 21, 2017 at 7:01 PM, Ben Pfaff <blp@ovn.org> wrote: >>> > On Fri, Mar 31, 2017 at 11:27:23AM -0400, Russell Bryant wrote: >>> >> The RPM build makefile targets are helpful during development and testing, >>> >> but I personally almost never want the tests to run when I use them. >>> >> Leave tests on by default in the spec file for when the package is built >>> >> by >>> >> distro build systems, but disable it by default in the Makefile targets >>> >> and >>> >> update the documentation accordingly. >>> >> >>> >> Signed-off-by: Russell Bryant <russell@ovn.org> >>> > >>> > I'm OK with this. >>> >>> Flavio, Lance, Aaron, have any opinions on this? It's not that big of >>> a deal. I guess I was feeling both slightly annoyed and lazy that >>> day. :-) >>> >> >> Seems fine to me. >> >> Acked-by: Lance Richardson <lrichard@redhat.com> > > +1 > > Acked-by: Aaron Conole <aconole@redhat.com> Thanks, applied to master.
diff --git a/Documentation/intro/install/fedora.rst b/Documentation/intro/install/fedora.rst index ffc77a4..b5617dc 100644 --- a/Documentation/intro/install/fedora.rst +++ b/Documentation/intro/install/fedora.rst @@ -87,15 +87,14 @@ can be added: :: - $ make rpm-fedora RPMBUILD_OPT="--with dpdk" + $ make rpm-fedora RPMBUILD_OPT="--with dpdk --without check" -The above commands automatically run the Open vSwitch unit tests, which can -take several minutes. To reduce the build time by disabling the execution of -these tests, the ``--without check`` option can be added: +You can also have the above commands automatically run the Open vSwitch unit +tests. This can take several minutes. :: - $ make rpm-fedora RPMBUILD_OPT="--without check" + $ make rpm-fedora RPMBUILD_OPT="--with check" Kernel OVS Tree Datapath RPM ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ diff --git a/rhel/automake.mk b/rhel/automake.mk index c4f043a..1265fa7 100644 --- a/rhel/automake.mk +++ b/rhel/automake.mk @@ -55,6 +55,7 @@ $(srcdir)/rhel/openvswitch-fedora.spec: rhel/openvswitch-fedora.spec.in $(top_bu $(update_rhel_spec) RPMBUILD_TOP := $(abs_top_builddir)/rpm/rpmbuild +RPMBUILD_OPT ?= --without check # Build user-space RPMs rpm-fedora: dist $(srcdir)/rhel/openvswitch-fedora.spec
The RPM build makefile targets are helpful during development and testing, but I personally almost never want the tests to run when I use them. Leave tests on by default in the spec file for when the package is built by distro build systems, but disable it by default in the Makefile targets and update the documentation accordingly. Signed-off-by: Russell Bryant <russell@ovn.org> --- Documentation/intro/install/fedora.rst | 9 ++++----- rhel/automake.mk | 1 + 2 files changed, 5 insertions(+), 5 deletions(-)