Patchwork isdn/hisax: fix compiler warning on hisax_pci_tbl

login
register
mail settings
Submitter Namhyung Kim
Date Dec. 7, 2010, 2:49 p.m.
Message ID <1291733346-11573-1-git-send-email-namhyung@gmail.com>
Download mbox | patch
Permalink /patch/74555/
State Accepted
Delegated to: David Miller
Headers show

Comments

Namhyung Kim - Dec. 7, 2010, 2:49 p.m.
Annotate hisax_pci_tbl as '__used' to fix following warning:

  CC      drivers/isdn/hisax/config.o
drivers/isdn/hisax/config.c:1920: warning: ‘hisax_pci_tbl’ defined but not used

Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
 drivers/isdn/hisax/config.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
David Miller - Dec. 8, 2010, 6:51 p.m.
From: Namhyung Kim <namhyung@gmail.com>

Date: Tue,  7 Dec 2010 23:49:06 +0900

> Annotate hisax_pci_tbl as '__used' to fix following warning:

> 

>   CC      drivers/isdn/hisax/config.o

> drivers/isdn/hisax/config.c:1920: warning: ‘hisax_pci_tbl’ defined but not used

> 

> Signed-off-by: Namhyung Kim <namhyung@gmail.com>


This only happens because the hisax driver doesn't actually use this table
for probing.  Each sub-driver does it's own thing.

What a mess.

Anyways, applied, thank you.

Patch

diff --git a/drivers/isdn/hisax/config.c b/drivers/isdn/hisax/config.c
index b133378..c110f86 100644
--- a/drivers/isdn/hisax/config.c
+++ b/drivers/isdn/hisax/config.c
@@ -1917,7 +1917,7 @@  static void EChannel_proc_rcv(struct hisax_d_if *d_if)
 #ifdef CONFIG_PCI
 #include <linux/pci.h>
 
-static struct pci_device_id hisax_pci_tbl[] __devinitdata = {
+static struct pci_device_id hisax_pci_tbl[] __devinitdata __used = {
 #ifdef CONFIG_HISAX_FRITZPCI
 	{PCI_VDEVICE(AVM,      PCI_DEVICE_ID_AVM_A1)			},
 #endif